From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XW5eMnNsbGos+TYAWB0awg (envelope-from ) for ; Fri, 31 Jul 2026 05:35:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Tiq+ZIxA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wu4khMTj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nlhm6+1v; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GVzt8O7F; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BD9801E099; Fri, 31 Jul 2026 05:35:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6EAE1E099 for ; Fri, 31 Jul 2026 05:35:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA1974B1A378 for ; Fri, 31 Jul 2026 09:35:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA1974B1A378 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Tiq+ZIxA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wu4khMTj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nlhm6+1v; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GVzt8O7F Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 3D4C64BA5435 for ; Fri, 31 Jul 2026 09:35:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D4C64BA5435 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D4C64BA5435 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785490518; cv=none; b=AVvwSWvuugt93FK+iAbsdLeft2cVSJ+BqHUSDGjj0disap05CkHzpcOHZsMfrj+VfxUlp5cXJdlhTqG0VW08FjH/OBfbfeIKeAatUpHXGhfxKVzMVX+ogjkZ7WPEIHy5xp8IRvwL6gfgOIoPvEJD7Ky9/rwf+LX7OG95Bae1W24= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785490518; c=relaxed/simple; bh=iaFexiMQp0OO0F2JarE6KCvSbqlU6IPkTJAJm4LjC60=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=GncXfogRcXZctVArCDpMMMRkABl9U9uMqw25z91WzSOOtnYwRjWhL4zts2w80iRyvoDGLQTxgqB9cqouckTY63Wybi4e9PyQL9rY8Lt1I6+j0f9XIVXLuUaKZP8m8ChwQNt90PDD92j2df/nV2zV271PRKExVGQoK9ncP6nbDJk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Tiq+ZIxA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wu4khMTj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nlhm6+1v; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=GVzt8O7F DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D4C64BA5435 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ABD733F37 for ; Fri, 31 Jul 2026 09:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785490512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Pc8Q0H4V9OdQZ2X29FIFU7cvcjKbPqN+hymuvwFptss=; b=Tiq+ZIxAhAsZoCEMhrZB2aoh9DBNiVX2ugIq6LzswIwEPEKLL5iLi0jmddcxCaplMzZxja pDsTa67sq5YWIEbOE+rVp7ORt1vSoOs8iPYRVR0+tuA+Qc6v+WbWYwC5qt53hhZU7MudVB 4btApIvlnyLC1Szpnm6E6Hk3dke599U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785490512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Pc8Q0H4V9OdQZ2X29FIFU7cvcjKbPqN+hymuvwFptss=; b=wu4khMTjmrqWcxGnQiJ1fce9jKRpuZqo/4+3kZ1AJWqA+Nd+pdGhkqzWFx4S1JxOFNFEaU fwpN1+KHqLVNnvAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785490508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Pc8Q0H4V9OdQZ2X29FIFU7cvcjKbPqN+hymuvwFptss=; b=nlhm6+1vmpQXOt9H9bf8QxsmRqxE2U4qs4jYVTqIiSomOQ+GR2vgprEsfQH7ygcrUqA6lP mt/IFA6H6Cf+GEC1krd78dAKwlri9VCuzb2OlL/YWyKSqTNNGXk6+r81ezKjiYrxE68+Kh Br6+dgMuccpQfUdtn90Mnh3aZ2lRNO4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785490508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Pc8Q0H4V9OdQZ2X29FIFU7cvcjKbPqN+hymuvwFptss=; b=GVzt8O7F21YxepYvJUIXLNmnYuiQ0ab7wVKvxOn/IceLobfDsJEwWWgcRxc0xXEi/Sznw1 sD5j0US5UkZ9eQAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 97F44779B0 for ; Fri, 31 Jul 2026 09:35:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mRnZI0xsbGpWWwAAD6G6ig (envelope-from ) for ; Fri, 31 Jul 2026 09:35:08 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Fix gdb.python/py-finish-breakpoint-tailcall.exp with gcc 16 Date: Fri, 31 Jul 2026 11:35:08 +0200 Message-ID: <20260731093508.3717972-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,sourceware.org:url]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On openSUSE Leap 16.0, with gcc 15.3.0, for test-case gdb.python/py-finish-breakpoint-tailcall.exp I get: ... (gdb) python MyFinishBreakpoint(frame) Temporary breakpoint 2 at 0x40102a: file py-finish-breakpoint-tailcall.c, \ line 43. (gdb) PASS: $exp: parent_frame=true: create finish breakpoint ... And on openSUSE Tumbleweed, with gcc 16.1.1 I get instead: ... (gdb) python MyFinishBreakpoint(frame) Temporary breakpoint 2 at 0x40102a: file py-finish-breakpoint-tailcall.c, \ line 44. (gdb) FAIL: $exp: parent_frame=true: create finish breakpoint ... The only difference is in the line numbers, 43 and 44, both in main: ... 39 int 40 main (void) 41 { 42 int result = tailcall_function (42); 43 result -= global_var; /* Temporary breakpoint here. */ 44 return result; 45 } ... The executable is compiled with O2, and the code for main is different. With gcc 15, we have: ... 0000000000401020
: 401020: bf 2a 00 00 00 mov $0x2a,%edi 401025: e8 26 01 00 00 call 401150 40102a: 8b 15 e0 2f 00 00 mov 0x2fe0(%rip),%edx 401030: 29 d0 sub %edx,%eax 401032: c3 ret ... and the line number associated with 0x40102a, the first instruction after the call is 43: ... File name Line number Starting address View Stmt py-finish-breakpoint-tailcall.c 43 0x40102a x ... With gcc 16, the mov and sub have been merged: ... 0000000000401020
: 401020: bf 2a 00 00 00 mov $0x2a,%edi 401025: e8 26 01 00 00 call 401150 40102a: 2b 05 e0 2f 00 00 sub 0x2fe0(%rip),%eax 401030: c3 ret ... and the line number info is different: ... File name Line number Starting address View Stmt py-finish-breakpoint-tailcall.c 43 0x40102a x py-finish-breakpoint-tailcall.c 44 0x40102a 1 x py-finish-breakpoint-tailcall.c 43 0x40102a 2 ... and gdb picks 44 in this case. Fix this by merging lines 43 and 44 in the test-case: ... - result -= global_var; /* Temporary breakpoint here. */ - return result; + return result - global_var; /* Temporary breakpoint here. */ ... Tested on x86_64-linux. I've also verified that reverting the fix in commit e6bdfed6f5d ("gdb: fix frame_unwind_caller_WHAT functions for inline and tail calls"), the commit that introduced the test-case still makes the test-case fail. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33989 --- gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.c b/gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.c index d129d7e41b4..844ac1d2ea6 100644 --- a/gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.c +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.c @@ -40,6 +40,5 @@ int main (void) { int result = tailcall_function (42); - result -= global_var; /* Temporary breakpoint here. */ - return result; + return result - global_var; /* Temporary breakpoint here. */ } base-commit: 6d1be0b90e837e4c82eaaf6f9e8c7da7227902e1 -- 2.51.0