From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +RhgL7rIaGp24zEAWB0awg (envelope-from ) for ; Tue, 28 Jul 2026 11:20:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BXx8PeyA; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BXx8PeyA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BCDAF1E09E; Tue, 28 Jul 2026 11:20:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 44F6A1E099 for ; Tue, 28 Jul 2026 11:20:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB0724BB3BD7 for ; Tue, 28 Jul 2026 15:20:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB0724BB3BD7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BXx8PeyA; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BXx8PeyA Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010068.outbound.protection.outlook.com [52.101.69.68]) by sourceware.org (Postfix) with ESMTPS id 0E3BA4BB3BD0 for ; Tue, 28 Jul 2026 15:19:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E3BA4BB3BD0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E3BA4BB3BD0 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.69.68 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785251970; cv=pass; b=U6ra2QLD3rOm4P4yQ1uSr49Mrqfve2bvk8IeBrKJ58B2MsFhUcSozHQ4t57Qodi4zBXIG4s9t2JcqNvhuaInlU9tP500kgVCYx/b9lsQE++zjCfl0mj1wn+4gCjDsvQo2uby8pBYC2QMg9oLQf61Be+ZPHqpbBNmoaNY0YZ5MC0= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785251970; c=relaxed/simple; bh=TFiN/QAjz7qq1oAraSvb+H7Dkry73rSPkbX8k+4/Mdg=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=dgkNWh2pna5PsbRkIHSkx0h8EZ9+JNbompPlBA69QknvYeGhXZMObNtX7fXXI5CTZX+eM9jf7irH/cmohEGoiDU1XvWsPd1YpV1IXgnqHWqTg9say7xheKI2IIemEtGzQKOyV2vsHVy9x8Tn4ilbjKLwmwmNT+ucp7q9KTMnApY= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BXx8PeyA; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BXx8PeyA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E3BA4BB3BD0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=teXq/UbO/bw2pkAJ8iL2VQvgiC3sfe783Znyb+xerC57iuILPPrH4hNDw9MILBZfY3MeWFnbsP+qCD5mpFM7Ur9YNupnanXXSfNHUV3YbjjCtqFLGWPfSnRy3Sdl6LnbKGFyykMC9MLBplsWMNzPtqsBZl6JQlvtxdAVGRhvTV8FzG00Ng+b+UuhnOD+1PTcTLCZNnKXJZH64FRk0AcZVeDiamk3Pq2bSSVHSIpZsa3tnxJGly+gbUWDh9LriOK/4VhNCO+Q4N/QjI0Y0aTHpQpiYWJEbB6YS1bgu8x9gZKWNS4+qkrxDVE9ZBGTWJqHtYGbvezn9KJeGoYmMLQzaA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=caL19bQUtA769uO1p1HCfJ5Djj2+yKIkeznfThPrBls=; b=SZL9fRo7YzvMXc+ZckmChzwxh6FgMYP7iH/Qx8exwqLllbWVq5VZa9/Skn+nRXZiuboxB4tY5VuxE0BE2VxY89ioqvK9Qhn2NhBMg7uuZh9CQcw3xZxEjrQw7kA43+ju1UPgOLaPgihnjsRib4x7LpLLyQ2+PP3xEEVFaPp0GwhgWqzUFvVZmbNfg6TITh0T65Mxp4vlVeh2+h4kAipRfiZVyx/UsbldRZauAKhx/ox/sa36KMCags1ah1RoOY1bQU/kE1kOFyOOTFQ9tCWMpmSy6M9nb+I1qWrk79qdjmPmP+aeR0iL5bDzXfvxz6fLFB0ecrqRWr17PlfotkAMvg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=caL19bQUtA769uO1p1HCfJ5Djj2+yKIkeznfThPrBls=; b=BXx8PeyAPVGSlicVzeMSJIOkUkdXFvIS8DJd1hwfnhAw4zz1dCRejAlEwgQAWlS7umbFn0f+bMJgB1JOOIux/CrrpUN+F0NKTpkuRdxOFH4vAzMruYchnv4ihlYORG8Og3eEopZkSxqeuDXa053DA79qHMBQIe+hVoCakEt9k7s= Received: from AS4P190CA0051.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::25) by DB4PR08MB9359.eurprd08.prod.outlook.com (2603:10a6:10:3f1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Tue, 28 Jul 2026 15:19:20 +0000 Received: from AM4PEPF00027A69.eurprd04.prod.outlook.com (2603:10a6:20b:656:cafe::12) by AS4P190CA0051.outlook.office365.com (2603:10a6:20b:656::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.12 via Frontend Transport; Tue, 28 Jul 2026 15:19:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM4PEPF00027A69.mail.protection.outlook.com (10.167.16.87) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Tue, 28 Jul 2026 15:19:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VtPMqZG0fjJZ5a3M9BhJGvc88rUC870fDljjrUUXIIth3/KuvuzclaHBrZXOgXrn2uP/AVh04IP9UPOddKptAeoqdbeh9qz8dRaWZcQmSYW6Q2DysyxM3ij8Apm/fvmlXIBFG8XCcUAA479gjlG55bUqTmdooEOO94oRHsp98/EYd+Y+TwI4PNkMpX0NrM/aMge7fo8F/U/hCOBG8JX9Wt1+FY906b/FbFrIELvUJ/4CUGs9xRsn91WDti76Ovv22YIqZjE28RFD+TzN2DJIfA0LY6T1eQ34BXLRT7YKe61TABMwYXPW6ijyMdo87snrRSsKOHPZ456saFocwqGgNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=caL19bQUtA769uO1p1HCfJ5Djj2+yKIkeznfThPrBls=; b=ClgMuLBZnu7LwSNB5KYa/8cMx3SAIbk5feegEuupyma8QCJ1RQtvzAHmBGvkpRos3ajEyCjOCd4m9A84vNiPmeELdlrpxqlAyxtv6SH2TT2GvUssm6rTkGfHjdinfLj4FXe4RQoLCe2gtEZB0nCEewtYgg+qYs+u4oyKGbffw0w3rlpiAYeij65S6FH8PA+5fjTPwSnJmsAf+GIXnHerli04b56E5bbpGCuapT9YmnsRU1Yfb8781rFcss/P5lKZZ7CxVseSzScJl0ija6RIG6ff0HEaucx5KUiPurN2cUuFFZJ288bpFYQHRTljr3PWmTdb4dFzeV4hB2eEP+QTMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 172.205.89.229) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=caL19bQUtA769uO1p1HCfJ5Djj2+yKIkeznfThPrBls=; b=BXx8PeyAPVGSlicVzeMSJIOkUkdXFvIS8DJd1hwfnhAw4zz1dCRejAlEwgQAWlS7umbFn0f+bMJgB1JOOIux/CrrpUN+F0NKTpkuRdxOFH4vAzMruYchnv4ihlYORG8Og3eEopZkSxqeuDXa053DA79qHMBQIe+hVoCakEt9k7s= Received: from DUZPR01CA0314.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::21) by PAVPR08MB9308.eurprd08.prod.outlook.com (2603:10a6:102:303::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.12; Tue, 28 Jul 2026 15:18:17 +0000 Received: from DU2PEPF00028D01.eurprd03.prod.outlook.com (2603:10a6:10:4ba:cafe::ab) by DUZPR01CA0314.outlook.office365.com (2603:10a6:10:4ba::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.13 via Frontend Transport; Tue, 28 Jul 2026 15:18:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 172.205.89.229) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 172.205.89.229 as permitted sender) receiver=protection.outlook.com; client-ip=172.205.89.229; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (172.205.89.229) by DU2PEPF00028D01.mail.protection.outlook.com (10.167.242.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Tue, 28 Jul 2026 15:18:17 +0000 Received: from AZ-NEU-EX03.Arm.com (10.240.25.137) by AZ-NEU-EX04.Arm.com (10.240.25.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Jul 2026 15:18:11 +0000 Received: from PF4S4363.arm.com (10.57.42.206) by mail.arm.com (10.240.25.137) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 28 Jul 2026 15:18:10 +0000 From: Matthieu Longo To: CC: Luis Machado , Luis Machado , Thiago Jung Bauermann , Simon Marchi , "Kevin Buettner" , Christina Schimpe , Christina Joos , Matthieu Longo Subject: [PATCH v1 6/6] gdb/linux-tdep: remove legacy parse_smaps_data overload Date: Tue, 28 Jul 2026 16:17:00 +0100 Message-ID: <20260728151700.253720-7-matthieu.longo@arm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260728151700.253720-1-matthieu.longo@arm.com> References: <20260728151700.253720-1-matthieu.longo@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DU2PEPF00028D01:EE_|PAVPR08MB9308:EE_|AM4PEPF00027A69:EE_|DB4PR08MB9359:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bc35d75-0b2f-41b1-061c-08deecbb992f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|36860700016|23010399003|82310400026|1800799024|56012099006|11063799006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: 39hH2wc72KQ3O2kbjTVneGtvT2pID8SRyLe7F1ZqZveTauKQwuAi6ZC82crmmOlvFnH9sAwrZrijqagqWsCCEBkkJa/io8Now9vdwVX/cAz33gQCjEBLNhyfpa1xiWtpfnzh4bK2/XnTVxvwV8IdK+UPctteUSfDrRC8UqbSZDa6bvAdjDmvNwbVC3pJGyW6cRRHlApVbZjQet1Y+F/Tfzz49MvuhN1EeP5qubdo6CdkMYX5hCf4PJ/bn/eeE+rZDwLP1CBnBE5T7O1sxDUgU/EQnDKymCAAefPeJ7pMXhU1IPi3mAurX/ijrvgCU+20b9LTT359xe/o14K8yi7zW0WvLo0Fm4dLWDH0S57nguLJjLjUoovVTP/qfkZdwFn+msVtcxP3rf/X2VmB4qqqD3lb+NEJbhvXdCnqe9NJZoK3nS19i1Bu6nNMySPFJF44zn8eyDTDzd5R6742ZNh97isLymaebI6op6387wfKdQPrQ9LaVI5VjHfZKDGHjo6mdqccH/MdTNMSQBYNXepJLVzLWnB/cA+DJ85VTZUs7VTaxhUTnOXiocZmwGoZNdBebgFnQDy+oY5jyCSvvRQQD9wnTsOrDXANPIx7GTSn07F6YyXd4ICJY5sEthipKCK/JpxsicBWhHDDn3nJYwZo3Qf4sd7TkYC78lf6WBzNhk+SGTb96gnTxZQrWKwmeYvoaBck7PMWMT+h2E8Qh2cZog== X-Forefront-Antispam-Report-Untrusted: CIP:172.205.89.229; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(36860700016)(23010399003)(82310400026)(1800799024)(56012099006)(11063799006)(10067099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: q5GxQNgHKMxANI3nlTGsUdcGZ6xkptQTWeNYatd73BJppxfEYxxCnBs+luP+AW0u27s4LFxwjWxM7WvyTfygtE8uT54uOVkL7poaSdw2lghTjaMwPd1ITYIifLi5ZlvkL9p7hqI8fF6u6Fbh6O9jxkovewj2Me3X8dlyUw1D5M8xyyABkPc8F79uNLFZ1nzewzssUQAIxFQ/ExwJilDyHMIJzaG6DeAfqUZwTf2Y8Ic3kF/UiEwE3sQkRnhlKpICp66YHqwSwXb1YKsMv4JjmjAL50Ai0DOIFK4XQxpvivMfLaVbB/Iwrd48tumMjz2CeohIJ2II3FBl+cEtL2NB+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9308 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A69.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dace2330-948a-4356-024f-08deecbb7379 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|14060799003|1800799024|23010399003|35042699022|36860700016|82310400026|18002099003|56012099006|22082099003|10067099003|11063799006; X-Microsoft-Antispam-Message-Info: SyrMSizX2vn1aJS90nxROkyQahpB7/Q2tF/MdlUn3UkbxW8HFQL4rIF7wLpxv7q/aBxnmReTelBIT8Uh4Tjf8V5aRhVb0WiNWBbJpL/X7pfRqbpCAB86nAbmF/wKKLc2dcJ/zdvI2EEuJkqYpfs5JYbztBuJgG8ZqCP5Y2Uy4qrc9naQNzIhPtuHitlDHdZmK4xwPmlhxbFzEnvJPQ+gX8cT9EbS+Twyns9mqfBL831UiRsyt9heaPoFmL1EwYACsLeyxcjoqgl2WEC7e6E/K2VrNlCivOqi5ujeRnHNgekUgb8STUqaWV9TBO1rjvDeBJGeXRz6sZiyXlM4k7pD5A+dtXUqsjbl7X3XSJ74RgkErpkbOXGcWZ9A/hl7FtFhDZCktTqnTNSnxuNvI8x8j3y+l2EVWFtV2Im/iUWtU5VM+66SDOlNafPvY9L72DTwnBWbT3ehUkuu65NS4yC3UM0RC9R8Jh+Ob692hdsxtPlGEzGiAIdGPrMh2xNGhTD++n6ZBKYnC9oQRrqD9KvlmnYNiZFDLC+3joYWk/rM7uld/bIilEzkUhkNasYo72x6N+MqYoIaqiO68fMT6HVjQVo9w5vLT8arB+rblxJthwjabisGSUT8mx+8kaVuHv82saPpUhKMi98jk/RZDsmNfmkOXz1cz7AqfwXUaazGawrcKlrxJq6OiRIU9ApqTTHWHeoKwAlYTdqLDJUv2Ok7vg== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(14060799003)(1800799024)(23010399003)(35042699022)(36860700016)(82310400026)(18002099003)(56012099006)(22082099003)(10067099003)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: T+zMZq0yD2LiqTOHSGQuiT3EKL2ciNeGXLXHCpip0QzUlpcoc6A97bZUIAhqhIJzE2m9zbWxhZYcXk1d8xu1Ea/CamaRsNLaanlhSIkn3tn1dnQQf1YLQ2oVdjNn7LUc7Qq3HhmDYVEpuCO5ZrpClZ3TtiFRG4jG1Vk5Aue2bJd/fjkjw/oN7+9W5tk9V9buc45g8k43RR8QWWgzDvyq13agVpxlPrhpFjp1SPkoIdVtW0soS7aIPAIK0RAdM1BtZDIGt+pAzUEMFJBMHdkQWJpo/tAk+/hunHRw51UkoCnoFE1Ip9e4M7QLMBIoMfouruH5Lv7N7Fuqh7wzUqoLtGNbpBCToIhwyQ5SCwq+9MvmQH4hjjfXujYIbXBeuH3165w14SzY8Ty+ZwBYV7smBz1XNORsSVz038eVJ6ZLduKOFwWDTgwHOLgEShFTSus8 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2026 15:19:20.5299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc35d75-0b2f-41b1-061c-08deecbb992f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A69.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9359 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Now that all callers use the file_reader_t overload of parse_smaps_data, the legacy interface taking a raw buffer and filename separately is no longer needed. Fold its implementation into the file_reader_t version and remove the obsolete wrapper. This also simplifies the implementation by using the file_reader_t accessors directly. Reviewed-By: Thiago Jung Bauermann Reviewed-By: Luis Machado --- gdb/linux-tdep.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index 628f73969d3..2e9cb14d5bf 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1582,18 +1582,17 @@ parse_smaps_key_value (const char *keyword, const char *line, /* Helper function to parse the contents of /proc//smaps into a data structure, for easy access. - DATA is the contents of the smaps file. The parsed contents are stored - into the SMAPS vector. */ + FREADER is a wrapper around the contents of the smaps file. + The parsed contents are stored into the SMAPS vector. */ static std::vector -parse_smaps_data (const char *data, - const std::string &maps_filename) +parse_smaps_data (const file_reader_t &freader) { char *line, *t; - gdb_assert (data != nullptr); + gdb_assert (freader); - line = strtok_r ((char *) data, "\n", &t); + line = strtok_r (freader.data (), "\n", &t); std::vector smaps; @@ -1649,8 +1648,8 @@ parse_smaps_data (const char *data, if (sscanf (line, "%64s", keyword) != 1) { - warning (_("Error parsing {s,}maps file '%s'"), - maps_filename.c_str ()); + warning (_("Error parsing keyword in {s,}maps file '%s'"), + freader.c_filepath ()); break; } @@ -1664,12 +1663,12 @@ parse_smaps_data (const char *data, decode_vmflags (line, &v); if (parse_smaps_key_value (keyword, line, "Rss:", - maps_filename, + freader.filepath (), &rss)) continue; if (parse_smaps_key_value (keyword, line, "Swap:", - maps_filename, + freader.filepath (), &swap)) continue; @@ -1680,8 +1679,9 @@ parse_smaps_data (const char *data, if (sscanf (line, "%*s%lu", &number) != 1) { - warning (_("Error parsing {s,}maps file '%s' number"), - maps_filename.c_str ()); + warning (_("Error parsing numeric value associated with " + "key '%s' in {s,}maps file '%s'"), + keyword, freader.c_filepath ()); break; } if (number > 0) @@ -1731,12 +1731,6 @@ parse_smaps_data (const char *data, return smaps; } -static std::vector -parse_smaps_data (const file_reader_t &freader) -{ - return parse_smaps_data (freader.data (), freader.filepath ()); -} - /* Helper that checks if an address is in a memory tag page for a live process. */ -- 2.55.0