From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6XpwLKDIaGor4zEAWB0awg (envelope-from ) for ; Tue, 28 Jul 2026 11:20:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=c3JcpUnL; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=c3JcpUnL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B17BE1E09E; Tue, 28 Jul 2026 11:20:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 412A21E099 for ; Tue, 28 Jul 2026 11:20:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7FB04BB3BCB for ; Tue, 28 Jul 2026 15:19:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7FB04BB3BCB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=c3JcpUnL; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=c3JcpUnL Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012064.outbound.protection.outlook.com [52.101.66.64]) by sourceware.org (Postfix) with ESMTPS id DAB4B4BB3BC2 for ; Tue, 28 Jul 2026 15:19:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAB4B4BB3BC2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DAB4B4BB3BC2 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.66.64 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785251966; cv=pass; b=HUK2MZlwWfse3Jt7jXX8n9dhSJM/Q+ow+XpCmI6mYQduP28v3c+3Rq93qM2iugm8Zw5HrUQfUn157HadavG7cVpStNeKq0zNg972pEemHTCXM6yjETOKo4dL0VxU5/AXaZVNHAPCJbRd4BjWo987qmAZ5VM+Y++1ocMaK8VUwig= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785251966; c=relaxed/simple; bh=rrUNjH/p92JbcwIyAeKFhQ2tmt4fxAQ2hAxfpAxs9kE=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=TL9l2iq2GCt9JDsEvdS7D0uOLxWeEJls9Ku8gqHu4UNOm/uDzYNAcQjbWXzI6wFMP+iYdZFTkJ1rHzJ8axv3h6EUaXHvO4KW4+fUkrHlfvcc8Uq1RC9beX+FRXe2hZpOG2PHoEXGo5sYJJJoekYzHAD9c8oUEUd+7m3j0F+PsEI= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=c3JcpUnL; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=c3JcpUnL DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAB4B4BB3BC2 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=M/tZMJZhJQ2IqfLHNXOIezJu6qCpHlrWucp2gmVA6Ifamf6/NsEixr1qyLeRGmctXTKemMsz1U/o1WRJ+8qVM/0oMnmddwDNN5xnxu37maIyMm3cLBnG2poy3JLHhVilDxXgbkH6yEscCbrG68cJS5hUi/bFZ8uSNsuoBw5KdyA9RZNVR4f8weBP/hE/0z9TIEis3yIGNTPb99AQKVLsCyBk08bjhLlXZH9pUspfxcOJ1bPDLtHY590r1kpShQ/8xmYKAqru36XNcaBNRpq1kKw/E8/64pf3MIRfTJTvwadT3jYewoxCS58FkRjwTb0i/eXeuuu5YLof+v/4miqK4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slmPtIgal0OcCq24X40AoQahgUdLTk8r9ggGEUh4hWs=; b=Mjruq8TQQdGlKTdcfWkvYSzrehFH78eJRHAljDywdNm9i1/2ZdXoUyXBX8yR2Anl9GbBryCK4giZijFQyHYV0ZzrB6+QzuIYTBUR8/mOcXo9TbsaRqf1qqIVrxZdNOkQG+mcAK+Yg+VvCis9ZQZbUlU8239sWVruVMMOtdFc1wsIpiEKjlAaU9qu6UKmmhWC7f/1TJOCqFVgRUNReYGzHHaMxa+A1L7Nij5D7dnQn0+jCoZXsl2mveTRBsC0/zn9YjGi5oMAEC4OLVXDEfNCsvEMmq1z71V0RhO/hlxFNQKet6CcrDK4uJH0r3+IbzYWFYjSgP600djyyHkXhCps3A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slmPtIgal0OcCq24X40AoQahgUdLTk8r9ggGEUh4hWs=; b=c3JcpUnLm9/kuosDFxw6LCEQQguSw6cBL8KSJULyS+1xEhKFGj15mPP3uyqGnUd5MJE+V0poGKPo5tXIB0MtcLNETuIgWL1ZunjgZg09yVCLOWgLx1S3ipAXi2/cxFNHVDj8Hwqk2jiKwRpIfMq71yceXypdiSGwKY84dG7/E+I= Received: from AS8P251CA0019.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::22) by GVXPR08MB10714.eurprd08.prod.outlook.com (2603:10a6:150:159::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Tue, 28 Jul 2026 15:19:18 +0000 Received: from AMS0EPF000001A6.eurprd05.prod.outlook.com (2603:10a6:20b:2f2:cafe::15) by AS8P251CA0019.outlook.office365.com (2603:10a6:20b:2f2::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.13 via Frontend Transport; Tue, 28 Jul 2026 15:19:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF000001A6.mail.protection.outlook.com (10.167.16.233) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Tue, 28 Jul 2026 15:19:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=glbFt16lrYwWQ7MZgHZxETkGzJ4M9+ae4xgYF7DI4N8gF6gWmcwpLnM8FcQ2bZ4bmnsOPE/O1zVopHIzrTW+u7+uoAk2QagDQKa8it/1aBea8FQz01zWVn23w8BYMn7IE1/n34BBddeHUYEEfCBmaZz6vOSIqVvUQEhjIBgZzQLpLra7sa7ovQkrvNoeTVNONEZkempB6CB1Mu+BiFrkJ86g/SX80BbQbNtIzkvm056ovfDBLhEzMQY21xyuW5M/ihP3kLsTQIfbWS9pEyZnXUnCjDsr8weT2roorV1wlJGbcGHQMzRcenczhKBWzE8yAnZiP8s/wFQ0g1kB/lV/oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slmPtIgal0OcCq24X40AoQahgUdLTk8r9ggGEUh4hWs=; b=wdF8MphAJs5yD7MoWbfttsuvvm8qcDTR94RT3Xwwe8WDSyRv3ZFkadzmko2NZNJkBP74rV8ror8UXxVdZkOMBw1gi4fF2o9FK65dWV5NeKyg/5I1M8cyGx1YznRl307Q6QNNYyHL7EU7jscKOhQyu+sfq9AdzxcXM/RvBsC8MQVxu0sXNbnYQUBZ/EM4M/thR5lrSpT4AYl2uU4yk6FU19PNuCIoC6rdJjW3Po5Jt9nE36zsp6z7649ZV3izYCgUImDAe9XAFBMamUvZJJ8h6W/mpf0XHrDigoVh5ZhjzXCJZlVToiA5VnlkXyNvGCF2eGRQiu/TDxnUa8/ZalBAfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 172.205.89.229) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slmPtIgal0OcCq24X40AoQahgUdLTk8r9ggGEUh4hWs=; b=c3JcpUnLm9/kuosDFxw6LCEQQguSw6cBL8KSJULyS+1xEhKFGj15mPP3uyqGnUd5MJE+V0poGKPo5tXIB0MtcLNETuIgWL1ZunjgZg09yVCLOWgLx1S3ipAXi2/cxFNHVDj8Hwqk2jiKwRpIfMq71yceXypdiSGwKY84dG7/E+I= Received: from DUZPR01CA0312.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::8) by AS4PR08MB8219.eurprd08.prod.outlook.com (2603:10a6:20b:51e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.12; Tue, 28 Jul 2026 15:18:11 +0000 Received: from DU2PEPF00028D01.eurprd03.prod.outlook.com (2603:10a6:10:4ba:cafe::ad) by DUZPR01CA0312.outlook.office365.com (2603:10a6:10:4ba::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.13 via Frontend Transport; Tue, 28 Jul 2026 15:18:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 172.205.89.229) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 172.205.89.229 as permitted sender) receiver=protection.outlook.com; client-ip=172.205.89.229; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (172.205.89.229) by DU2PEPF00028D01.mail.protection.outlook.com (10.167.242.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Tue, 28 Jul 2026 15:18:11 +0000 Received: from AZ-NEU-EX03.Arm.com (10.240.25.137) by AZ-NEU-EX04.Arm.com (10.240.25.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Jul 2026 15:18:00 +0000 Received: from PF4S4363.arm.com (10.57.42.206) by mail.arm.com (10.240.25.137) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 28 Jul 2026 15:17:59 +0000 From: Matthieu Longo To: CC: Luis Machado , Luis Machado , Thiago Jung Bauermann , Simon Marchi , "Kevin Buettner" , Christina Schimpe , Christina Joos , Matthieu Longo Subject: [PATCH v1 5/6] gdb/linux-tdep: migrate linux_find_memory_regions_full to file_reader_t Date: Tue, 28 Jul 2026 16:16:59 +0100 Message-ID: <20260728151700.253720-6-matthieu.longo@arm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260728151700.253720-1-matthieu.longo@arm.com> References: <20260728151700.253720-1-matthieu.longo@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DU2PEPF00028D01:EE_|AS4PR08MB8219:EE_|AMS0EPF000001A6:EE_|GVXPR08MB10714:EE_ X-MS-Office365-Filtering-Correlation-Id: 185725fa-7455-4ff3-de45-08deecbb97d8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|1800799024|82310400026|36860700016|30052699003|23010399003|376014|10067099003|6133799003|11063799006|5023799004|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info-Original: RmPfGAt6J7i1z/6pF+d7/LwRfVn5YsASQOcF5+MrDhbTffr6JuXGowsi9zwLpYz9+tuoDSVwm/3Am25CCOttWzhkf7iLbAsantv942wApGk/qoydA5WUyp+pqaZBnJ06+XOvPZY8G3MvIGeBT3Fwok1WjMBHJPg/0lXPE8kb/4gpEeHhBSJLjjNzB6jkO6SjKVAigeZTdhYrRX/idJSSQtz9B0GFixmboPdDllVRVrEAJvti5AEDkgtaru1O6DoSiWHepyvgWfCYLJez2pwzP3A011FqihQTDd2X+h96yKT3aEpLJ6c0GYDJvMqOcmqvTiRrK5WrgJy9rYVne8YQc20il8IVotcI+y5wpbuhxIgC9Prns/EveVSafS89MSNbamugecM2o9PoJ6WK0osUW0GsRAM4wvPEM+svhIls7caDXdzz1gIHlgEr5FqH4LMrYSaNMftMIz3T0Yf4hyoBL3gvjRECdlX7+RIfeGAQnE1W9sOagF/qPN0SiUcr3YMnW+6foPIe0hpRckmNUtpkQO6fL9veTwZwr/PHPDsbBbsgD6AFqyXiO/qtVZZgNFU3mmFTOGeUr+5ZJ3MJm/LEK0pNZOVm+rb87ofG0UWUBtzkNO58ZlCEjzMvc//1V2snO97LBv6DDiCg7CnjKXeUDfqLspzCygO9vD6fdgFvzvKoC0oHqbdL2MWP8FDnmfUBQFJRo9cM7O6j7Fxrxw6yZw== X-Forefront-Antispam-Report-Untrusted: CIP:172.205.89.229; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700016)(30052699003)(23010399003)(376014)(10067099003)(6133799003)(11063799006)(5023799004)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: BoEpGU6RsOGRW13M6FwgsFrCIigDrmSnu3RZ4sxc5n+PX4gehzhFTx3bNl/w279nLPIWxmUG3+QIT12BBTVKlM6AsOGcgHQp/2x7SE5f3aiQgmBVC4l11yObaGGGIh/0Q6Mj68NnUubkjHoNKQjlpf8ozoW0av2WmGc5HhWDxcoY0/A39B8THK8O7kY/wm/kW1j45lZnVjx0pCKAC4sGaCZBsWStHK0tyjcSEW1DRmSJ4N+EzzH0Yiq/J0rmY0CI9oyJgBUkBfVYeSuOB8rI9IopH5RxVZ9CB2AMNSrgUskmp/kZ/erYcg4Hgmg3L9c0TaUeqLgb0f8/7/jDOQRUVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8219 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A6.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1cd77eab-e919-43d2-92a8-08deecbb701d X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|23010399003|14060799003|376014|35042699022|1800799024|30052699003|82310400026|10067099003|5023799004|56012099006|11063799006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 1EzLtCqW3DGKC4FmoMHoObGqhUXoVIprjG6m6f6V7ISae3SZmJPwBsRj5jpwLjdiZ6R28YnEuQJ1ZlUYQTNAy+/OSuGDKMisMDLXyH+Q9f/oszHJY29eAf4C9A0KhIILBEF2cqlmx1XJx0ORm4OcyUVmTLgEh4zyFQG8u7cJXfry7cIt5sbJzsPCYExAmBomOL6sKCnwhVflayyjaUzIXzvqz+FPC3AS5wTiVVta0AMGYE/7S5mS8CB1OUJbzYtBoTEJ/7AxvVCStMjIHZ7/gbFyt+/iycrA4ljBRTCsU7z0pAQ74XRb9CXA9tWiB59cuivTtTPsHn2H74sVIedN3/56Ko8/XkQinnYQNzjrDsWL4HQYkP/aisRJ8xer4AdIX70n8GsK89Ss+nXT0BGXjRWHWkagnwsoBFTVDo33MjtA+aBVKu1Qck+X6PGFpj+riSt1e93W5aH4thKmV2dceWs+1NB754NghWXylB9AJ17Vo4Tc9I6KJoGUsBtYwyuAYNGNKiekxO1+8W612QUDr/ZNyrPtePuE5iApR0/ZStureZG6zIV3ZzYn8Y/M8UIM3wrmPfQKf0GkjRCHY2T0n6ij4zhw9e8xi7P+y5Vegh84B5KCc6J5JObRtrolykGu8BC9ONnK15rEhbNx+SuZJqbzfB8G5hlRsHRbRBy3zIqIce6Xo6iT2BYz/bPQwJ7F/P6GjBjf8qS0kK3xAXCl1A== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(23010399003)(14060799003)(376014)(35042699022)(1800799024)(30052699003)(82310400026)(10067099003)(5023799004)(56012099006)(11063799006)(6133799003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FP/He8V5jvVbxhJYrdtCqyo5exDspqbR2h6N6/DTG6zhVF+ZdL6Pyh4vUkmojMxeVzdqS6aBICAaFil+pnYoMRZp3PJZ1h1HvK4/+5bgJcveKereMRRMu0us1zbHG7e2csGOFRkSsgxsd0WpICtDoReNKSW9J16xTdFbBsSRCNj2nSrTo9uZCidwCBXrZdBfMI+Kgwc2o3dxQE9UA5LRFt/CqBdLPEu1Y20Q4iwjDiJZEyEgCkTG71LrG47cs5N+yXklWi17w12z54bA0YrHtgQwFjfs0ncPCDNJ2bageWCyEEzZgJgD+WmIV2CjCEsACJoFmb6mcQksw8Ka5OhBXJv79qbfviDcnz9AmFN5GDbCVOdeWbbkkZIzJJfFdzmTgWVyU3gEmjpVDxynrpyAVXYLkf9RnSVbm/Xi0bCFyop297c0EcXjMpFlNPGFG+ZV X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2026 15:19:18.2870 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 185725fa-7455-4ff3-de45-08deecbb97d8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A6.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10714 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The previous implementation of linux_find_memory_regions_full could still return success even when none of the /proc/PID/[s]maps files existed, or all reads returned 0 bytes (this last case can happen on Linux when the thread-group leader has exited). As a result, the function could incorrectly succeed, allowing core dump generation via the gcore command. This logical defect was allowing, by chance, the function to return success and hence, allowing fortuitously the coredump generation via gcore command (see gcore-stale-thread test for more details). A previous patch in this patch series fixed this issue by using the first LWP ID of the current inferior instead of relying on the PID. This patch adapts the code to use file_reader_t and makes the function return an error if reading any of the procfs files fails. --- gdb/linux-tdep.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index a8dab0d6d5e..628f73969d3 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1829,25 +1829,22 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch, } } - std::string maps_filename = string_printf ("/proc/%ld/smaps", ptid.lwp ()); - - gdb::unique_xmalloc_ptr data - = target_fileio_read_stralloc (NULL, maps_filename.c_str ()); + std::vector smaps; - if (data == NULL) + file_reader_t smaps_freader + (string_printf ("/proc/%ld/smaps", ptid.lwp ())); + if (smaps_freader) + smaps = parse_smaps_data (smaps_freader); + else { /* Older Linux kernels did not support /proc/PID/smaps. */ - maps_filename = string_printf ("/proc/%ld/maps", ptid.lwp ()); - data = target_fileio_read_stralloc (NULL, maps_filename.c_str ()); - - if (data == nullptr) + file_reader_t maps_freader + (string_printf ("/proc/%ld/maps", ptid.lwp ())); + if (!maps_freader) return false; + smaps = parse_smaps_data (maps_freader); } - /* Parse the contents of smaps into a vector. */ - std::vector smaps - = parse_smaps_data (data.get (), maps_filename); - for (const struct smaps_data &map : smaps) { /* Invoke the callback function to create the corefile segment. */ -- 2.55.0