From: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <keiths@redhat.com>, <tom@tromey.com>
Subject: [PATCH 1/2] gdb: simplify code in check_typedef
Date: Mon, 27 Jul 2026 09:20:00 +0000 [thread overview]
Message-ID: <20260727092001.1683349-1-tankutbaris.aktemur@amd.com> (raw)
Simplify a code portion in check_typedef where the conditions are
unnecessary. Also remove the comment that says "treat address spaces
and address classes separately", because since the commit 92fdad7
"gdb: convert type instance flags to bitfields", they are separate
fields; so, the comment does not look useful.
---
gdb/gdbtypes.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 9098727959e..ad401872941 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -3062,12 +3062,8 @@ check_typedef (struct type *type)
"it can't happen". */
{
type_instance_flags new_instance_flags = type->instance_flags ();
-
- /* Treat code vs data spaces and address classes separately. */
- if (instance_flags.harvard_aspace != HARVARD_ASPACE_NONE)
- new_instance_flags.harvard_aspace = HARVARD_ASPACE_NONE;
- if (instance_flags.address_class != 0)
- new_instance_flags.address_class = 0;
+ new_instance_flags.harvard_aspace = HARVARD_ASPACE_NONE;
+ new_instance_flags.address_class = 0;
instance_flags |= new_instance_flags;
}
--
2.53.0
next reply other threads:[~2026-07-27 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 9:20 Tankut Baris Aktemur [this message]
2026-07-27 9:20 ` [PATCH 2/2] gdb: preserve lhs type's address spaces/classes " Tankut Baris Aktemur
2026-07-29 17:27 ` [PATCH 1/2] gdb: simplify code " Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727092001.1683349-1-tankutbaris.aktemur@amd.com \
--to=tankutbaris.aktemur@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox