From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qZI7G+p7ZGrOnCwAWB0awg (envelope-from ) for ; Sat, 25 Jul 2026 05:03:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ajdSLDuQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L2d3pPGP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GB33vIr7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=suC9emNz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6B5021E09E; Sat, 25 Jul 2026 05:03:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 72CA31E099 for ; Sat, 25 Jul 2026 05:03:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A264D4BA2E30 for ; Sat, 25 Jul 2026 09:03:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A264D4BA2E30 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ajdSLDuQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L2d3pPGP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GB33vIr7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=suC9emNz Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 6D1934BA2E08 for ; Sat, 25 Jul 2026 09:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D1934BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D1934BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784970150; cv=none; b=rUoLmn4zhqUPgMbxdm6AWiOkITBzAnmcb4NID3fBJ8WseXsNMLuZIsJlyoELt8muKggaUoc8SbZpkC6Ctjb1CShJ5bVLSKaVZkbQm/22rg3kllYEsa/jIJwfU4ctvFeuSn9SyvR5TL4XPr63Vu4up177pAkgfj1E8A+DkqikZU8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784970150; c=relaxed/simple; bh=KnCpA9dXtBW15Te1TYWHbRSsn925l6lEkpMBIPn8GKU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=EsJGzxe6CgXiCOEleSsdfpmRlHGQSJ+efv7+ezIWMSDuOuIe2fiRb2LY1u4NZNJf2+i/OZRJmByZUDFAFqT9NqwZ1S+wmYiM0Wjs931gA9TA0S+LnW9rdOpfrCdNczVESguiIa0VSLLs2Dew/xjNZbzpcf3z0dFXTGe1vqhenLc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ajdSLDuQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L2d3pPGP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GB33vIr7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=suC9emNz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D1934BA2E08 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74CCF4AAF for ; Sat, 25 Jul 2026 09:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784970148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUHi7C7u9rxuevj87pgv/W2yO2YAvbxULj4ksoRBCHY=; b=ajdSLDuQSkwDS/TYvaf6byjDdnTlFa7XKjY9pi3mc6/Yig07gPL1dlK2CHqeuNR3Oe9k9a WjJwyYVZTGPd6aFPBNuAE+TQuCNL0GwMAuuwkjxDuyhIlROPRlIzNyhxV1qh0Erb9oBcL/ tbJPIBSHLrYKQK2TfcxaHlIdcvmTCm8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784970148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUHi7C7u9rxuevj87pgv/W2yO2YAvbxULj4ksoRBCHY=; b=L2d3pPGPL1N8LlEfEYJGgpTemL0y+p6qjrsrwTo9awzCsQslmXeWaqTNqpFGfEE/wYdA/3 ZrFx/ghhcdVeiQBQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784970147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUHi7C7u9rxuevj87pgv/W2yO2YAvbxULj4ksoRBCHY=; b=GB33vIr7mzqW89UM1/XgjVPhLpwWI25PNjnvnQWwwOJeFWDufB4nFwCnHJiisyHvGnkH3S hsCl7MDUyz08olj/Ytljkgp1NzUsixIfrOLsMDkT0KGf6cQJ3wCN6qGmnjVvh5nMdgcPkt eLvLYIVRxKKcmZ7aPlAhHQFno3lobhY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784970147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUHi7C7u9rxuevj87pgv/W2yO2YAvbxULj4ksoRBCHY=; b=suC9emNzHo7W6bWIwRc3PyM90mDS/lu6T5GTTnMToX4mMeE53n6UZHotfppCxva/jZBmHG 1/nFRN46uYpqTMAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5C776779C2 for ; Sat, 25 Jul 2026 09:02:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eN0/FaN7ZGomWAAAD6G6ig (envelope-from ) for ; Sat, 25 Jul 2026 09:02:27 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [RFC 2/2] [pre-commit] Require codespell-clean commit messages Date: Sat, 25 Jul 2026 11:02:26 +0200 Message-ID: <20260725090226.839799-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260725090226.839799-1-tdevries@suse.de> References: <20260725090226.839799-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[gnu.org:url, imap1.dmz-prg2.suse.org:helo, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Now that we have an easy method to ignore intentional typos in commit messages: ... Fix typo skippig [sic]. ... require commit messages to be codespell-clean. Still, this may mean that large blocks of verbatim text (for instance backtraces) might have to be ignored using codespell:ignore-begin/codespell:ignore-end. To restart editing after check failure, this command can be used: ... $ git commit --amend $ git commit --amend -F .git/COMMIT_EDITMSG -e ... Having your commit abort is somewhat annoying, and I thought of two ways to make this less annoying: - add an interactive loop that allows the user to re-edit or ignore the codespell failure - in case of codespell failure, add codespell:ignore-begin codespell:ignore-end around the entire message, and pass --- .pre-commit-config.yaml | 2 -- gdb/contrib/codespell-log.sh | 20 -------------------- 2 files changed, 22 deletions(-) delete mode 100755 gdb/contrib/codespell-log.sh diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 60164e446fc..76991b7d18a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -87,9 +87,7 @@ repos: files: &gdb_files '^(gdb|gdbserver|gdbsupport)/' - id: codespell name: codespell-log - entry: gdb/contrib/codespell-log.sh args: *codespell_args - verbose: true stages: [commit-msg] # Tclint hooks. diff --git a/gdb/contrib/codespell-log.sh b/gdb/contrib/codespell-log.sh deleted file mode 100755 index 3e1fc26159a..00000000000 --- a/gdb/contrib/codespell-log.sh +++ /dev/null @@ -1,20 +0,0 @@ -#!/bin/sh - -# Copyright (C) 2025-2026 Free Software Foundation, Inc. -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program. If not, see . - -# Script to be used as commit-msg hook to spell-check the commit log using -# codespell. - -codespell "$@" || true -- 2.51.0