Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Avoid command-line length limit combining test results
Date: Thu, 23 Jul 2026 18:51:27 +0100	[thread overview]
Message-ID: <20260723175131.266112-1-pedro@palves.net> (raw)

On Windows, "make check-parallel" dies when combining the per-test
gdb.sum / gdb.log files into the final combined pair:

 $ find outputs/ -name gdb.sum | wc -l
 2657
 .../dg-extract-results.sh: line 39: /ucrt64/bin/python3: Argument list too long
 make: *** [Makefile:274: check-parallel] Error 2

The testsuite Makefile passes the whole file list to
contrib/dg-extract-results.sh on the command line, expanded from a
find(1) backtick.  GDB's parallel harness writes one gdb.sum (and one
gdb.log) per test script, so on a full run that list holds thousands
of paths, which overflows the Windows command-line length limit
(~32 KB).

This series teaches dg-extract-results to read the file list from
stdin (or a file) instead, and has the Makefile pipe the find output
straight in, so the length limit no longer applies regardless of the
host.

The first patch touches contrib/dg-extract-results.{sh,py}, which are
shared with GCC, so I plan to submit that one to GCC as well.

The two middle patches (factoring out the combine recipe, and adding
the extract-results target) are pure GDB and can go in at any time.

Only the last patch depends on the new -f option added by the first
patch.

Pedro Alves (4):
  dg-extract-results.{sh,py}: Optionally read file list from stdin/file
  gdb/testsuite: Factor out dg-extract-results.sh calls
  gdb/testsuite: Add extract-results make target
  gdb/testsuite: Pipe the dg-extract-results file list via stdin

 contrib/dg-extract-results.py | 30 +++++++++++++++++++---
 contrib/dg-extract-results.sh | 17 +++++++++++--
 gdb/testsuite/Makefile.in     | 47 ++++++++++++++++++++++++-----------
 3 files changed, 74 insertions(+), 20 deletions(-)


base-commit: 39fc0cc4aa6f82a73b9eac6b8739895484ab269f
-- 
2.54.0


             reply	other threads:[~2026-07-23 17:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 17:51 Pedro Alves [this message]
2026-07-23 17:51 ` [PATCH 1/4] dg-extract-results.{sh, py}: Optionally read file list from stdin/file Pedro Alves
2026-07-23 17:51 ` [PATCH 2/4] gdb/testsuite: Factor out dg-extract-results.sh calls Pedro Alves
2026-07-23 17:51 ` [PATCH 3/4] gdb/testsuite: Add extract-results make target Pedro Alves
2026-07-23 17:51 ` [PATCH 4/4] gdb/testsuite: Pipe the dg-extract-results file list via stdin Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723175131.266112-1-pedro@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox