From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +TyEKC4SYmqmWykAWB0awg (envelope-from ) for ; Thu, 23 Jul 2026 09:07:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=e/ZIblPi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A20951E09E; Thu, 23 Jul 2026 09:07:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38F761E099 for ; Thu, 23 Jul 2026 09:07:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BDE094BA79B4 for ; Thu, 23 Jul 2026 13:07:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDE094BA79B4 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=e/ZIblPi Received: from flamingo.elm.relay.mailchannels.net (flamingo.elm.relay.mailchannels.net [23.83.212.60]) by sourceware.org (Postfix) with ESMTPS id C2B4F4BA79AC for ; Thu, 23 Jul 2026 13:06:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2B4F4BA79AC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2B4F4BA79AC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.212.60 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784811971; cv=none; b=JwMe9IxoNv1nq3VH/Kiqb5qmoZw5l4V6F+/dWokEIiOIuSkgjGpYIETzyy3/D1RAKK6jAF1huGV1x4/dIXgTzZVoPpVFICf9MJXoSeNKLAe36nJRcwd+As6ehp0DdyWpLHFjJOqfVeYgcqar3AN4bUwiEeEk/AuCjWQFVjQEuCQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784811971; c=relaxed/simple; bh=vbg7yeGD3HZWLoJOqguWaXQfgHLuR07h07YP8mAbiLM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XiHuqbjlu1Uo/DtTGTNsyEFHFxVUqDUEMRI0JB7i+C9NXiRty6NWqvTVw1+yGvDgbgDMPSxfMTf0KuvvRqp9eYlh1MnJ5n35eKRXiBAL60z14Fmx1/oQwZbf4ECJdEpx4KLStVTCyTj+4XDu4npUmKNYC12bheCx+3LE0qfcOCI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=e/ZIblPi DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2B4F4BA79AC X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9770D8C2BF8 for ; Thu, 23 Jul 2026 13:06:09 +0000 (UTC) Received: from pdx1-sub0-mail-a249.dreamhost.com (100-103-95-6.trex-nlb.outbound.svc.cluster.local [100.103.95.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 47F3D8C407C for ; Thu, 23 Jul 2026 13:06:09 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Descriptive-Keen: 0a16e5cb373448ff_1784811969525_1236953557 X-MC-Loop-Signature: 1784811969525:3816597730 X-MC-Ingress-Time: 1784811969525 Received: from pdx1-sub0-mail-a249.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.95.6 (trex/8.0.2); Thu, 23 Jul 2026 13:06:09 +0000 Received: from localhost (bl20-181-64.dsl.telepac.pt [2.81.181.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a249.dreamhost.com (Postfix) with ESMTPSA id 4h5Wb45Ynvz1049 for ; Thu, 23 Jul 2026 06:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=palves.net; s=dreamhost; t=1784811969; bh=IIKRHUugj1Nlap9zNF13ETbufnoMNQI+La6ooLtzIiM=; h=From:To:Subject:Date:Content-Transfer-Encoding; b=e/ZIblPiMVCclOY70L5i/vpyV2H5daFLBnY2t3iTAoFTp5wfmDcSOwLqYwO9RfePv jkyW6SZRUm2R7yND8pUpzBZSI/6IGMsDYpCs8VjqxjKdZEW2Avej6JR73F1Uyiml1r mgAscOQk8b79IuFvQHWULNAnbWVmN5bylGuMdk4nFxEnRUh2h6f1BMJ5sOv9+8XfHU M7cRfakXEDSka9JbAkNAvREVJqqLvT54oP6NRndlMgIf/UVoSvCAHL1xPEvDncEWh/ H1jbXTVfkTae8JFiR2jYgAOysr3+e9nCD17wsLgA/HaT7++TVyaDIKvKEZLt3VFu8U B/zZwyAVV4lvQ== From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 23/27] gdb.base/maint-info-sections.exp: Remove stale Windows DATA xfail Date: Thu, 23 Jul 2026 14:01:14 +0100 Message-ID: <20260723130118.206735-24-pedro@palves.net> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260723130118.206735-1-pedro@palves.net> References: <20260723130118.206735-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The "maint info sections DATA" test of gdb.base/maint-info-sections.exp was marked XFAIL on cygwin and mingw, on the grounds that Windows text sections were tagged DATA, so the DATA filter would wrongly list the text section. The Cygwin xfail dates back to commit dbdfa66c308 in 2005, the MinGW one to commit 58e8570aabf ("gdb.base/maint.exp: XFAIL "maint info sections DATA" on MinGW as well as Cygwin.") in 2011, and both moved to this file unchanged in commit f4be677293a ("gdb/testsuite: split 'maint info sections' tests to a new file"). On current cygwin and mingw the text section is not reported as DATA, the test passes, and the xfail turns into an XPASS: XPASS: gdb.base/maint-info-sections.exp: maint info sections DATA I have not tracked down exactly which change fixed this -- given the xfail is roughly fifteen to twenty years old, it could be a change in GDB, in BFD's PE section-flag handling, or in the toolchains that produce the section flags in the first place. It does not really matter for this test IMHO: what it checks is GDB's report of the current binary's section flags, and on the toolchains anyone is realistically testing with today that report is correct, as the XPASS shows. A stale xfail that always XPASSes is just noise, so I'd rather remove it and let the test report a plain PASS. If it turns out this still fails on a modern toolchain, we can add the xfail back with some more targeted check, based on toolchain version or some such. Tested on: x86_64-pc-linux-gnu x86_64-pc-cygwin x86_64-w64-mingw32 x86_64-pc-windows-msvc Change-Id: Ia64c4297fb219058353fb9d88913f89cca2cd68b --- gdb/testsuite/gdb.base/maint-info-sections.exp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/gdb/testsuite/gdb.base/maint-info-sections.exp b/gdb/testsuite/gdb.base/maint-info-sections.exp index 3cc128c0ad3..0bb15246d52 100644 --- a/gdb/testsuite/gdb.base/maint-info-sections.exp +++ b/gdb/testsuite/gdb.base/maint-info-sections.exp @@ -173,12 +173,6 @@ gdb_test_multiple "maint info sections CODE" "" { # Test for new option: DATA section flag # If your text section is tagged DATA, xfail this test. -# -# The "maint info sections DATA" test is marked for XFAIL on Windows, -# because Windows has text sections marked DATA. -setup_xfail "*-*-*cygwin*" -setup_xfail "*-*-*mingw*" - gdb_test_multiple "maint info sections DATA" "" { -re -wrap " $text_section .*" { fail $gdb_test_name -- 2.54.0