From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kYYmGBf+YWoAEykAWB0awg (envelope-from ) for ; Thu, 23 Jul 2026 07:42:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HdSjnmTa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iRoREr+9; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VPRCzyr8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=S80T5p8I; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5DD5B1E09E; Thu, 23 Jul 2026 07:42:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B3A011E099 for ; Thu, 23 Jul 2026 07:42:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE4FD4BA7996 for ; Thu, 23 Jul 2026 11:42:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE4FD4BA7996 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HdSjnmTa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iRoREr+9; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VPRCzyr8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=S80T5p8I Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D6B454BA7983 for ; Thu, 23 Jul 2026 11:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6B454BA7983 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6B454BA7983 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784806854; cv=none; b=UtzXjwKwu73u/Ssc73d+ey0Xxdp7Z94WjhfKz/EAsm773xlqtunnaWtzyuwE1IR1lOKxGDQFskBM6ddAKqHEGmH17NCjEEuoJKY2h5/YKmwIXUEM5B5lBvT7hRoZ7Qixqk4GTkj3GEj9GVTFB3ZLQD0AznHcgW76iQw1OAQXk4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784806854; c=relaxed/simple; bh=iZssTEvApAvPu8HuEUgNb0N8uRZhGoLcGxc1FPqH09Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=dW9trMa7uJnPAHCpeeMTLOGmMTUmYPk/q6aaOFPXxwbnxjf01zRhYK/CsZXU0F9DM5emHg2q/lO1dndjjQNTGZlwX6Y0IxG4+DtWwEcoda8ri5XpMYmFCc3NNG/S9RNFIk6oqiqpMaPskNX1ZcgBDoL5tX1IenPLis+mv8Xx5Jc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HdSjnmTa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iRoREr+9; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VPRCzyr8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=S80T5p8I DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6B454BA7983 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F3DB47B0F5 for ; Thu, 23 Jul 2026 11:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784806844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHFgeuFn0WsiXzqhrw1tCnlE3a5kEfyqjd3pM/yeG/g=; b=HdSjnmTaauF9VKJXL1OfKJZ6erRgW5aOrzR/4rGySqrB3KGpBtn0W+dB7zgxwJZg28kD5r Q8uyLRV+IzzspWuEpwozJXFrwPnJh87GitWKunXkLoU/jXiB4CEKR/CQ2JRQYkvTNBFgRZ gEQbZYo3kqm8z/3chSqUsnqkB8Wl4uA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784806844; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHFgeuFn0WsiXzqhrw1tCnlE3a5kEfyqjd3pM/yeG/g=; b=iRoREr+9xM9bWAxrg8DBev5v4Y8SeQgAyyUU72L2aR+d3KfF9l9p1ih/Qj1fbjOuUBsaBd RkyklIqTNdY9eOBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VPRCzyr8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=S80T5p8I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784806843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHFgeuFn0WsiXzqhrw1tCnlE3a5kEfyqjd3pM/yeG/g=; b=VPRCzyr8/AWRgjY9CuD/gRaXCglWYLzfGVxdqgmB/Vk8EpCVgQqyxHUjA/yE6M9c/x9m4f lmQUh80jZ+GgkLX/Cz8vdEyoMenkjkZJkiAjd6ZF0oq1N8x6y8kY/2esDdSgjv7evJ5/zq q+Yh11HhBo6uW6FVz1kuH9jD/s7a0fQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784806843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHFgeuFn0WsiXzqhrw1tCnlE3a5kEfyqjd3pM/yeG/g=; b=S80T5p8IY4ROU1HHVUG2pGuPPBLGaLweYxZCjET7SRqCtUpDYHfQ8vbXVTYkgDDQzsVlr2 j1fVyIDzLlh5YBCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DB5A9779C5 for ; Thu, 23 Jul 2026 11:40:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wGUUNLr9YWprQwAAD6G6ig (envelope-from ) for ; Thu, 23 Jul 2026 11:40:42 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/2] [gdb/testsuite] Fix race in gdb.threads/leader-exit.exp Date: Thu, 23 Jul 2026 13:40:41 +0200 Message-ID: <20260723114042.703464-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260723114042.703464-1-tdevries@suse.de> References: <20260723114042.703464-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: F3DB47B0F5 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On aarch64-linux, when running test-case gdb.threads/leader-exit.exp with "taskset -c 0", 3 out of 10 times I run into: ... (gdb) continue Continuing. [New Thread 0xfffff7d1f160 (LWP 62010) (id 2)] [Switching to thread 2 (Thread 0xfffff7d1f160 (LWP 62010))] Thread 2 "leader-exit" hit Breakpoint 2, start (arg=0x0) at leader-exit.c:32 32 sleep (10); /* break-here */ (gdb) PASS: gdb.threads/leader-exit.exp: continue to breakpoint: break-here info threads Id Target Id Frame 1 Thread 0xfffff7fe8020 (LWP 62008) "leader-exit" (Exiting) \ 0x0000fffff7d46fa0 in __libc_start_call_main () from /lib64/libc.so.6 * 2 Thread 0xfffff7d1f160 (LWP 62010) "leader-exit" \ start (arg=0x0) at leader-exit.c:32 (gdb) FAIL: gdb.threads/leader-exit.exp: single thread has been left ... In a passing version, the continue produces a "Thread exited" message, but that's missing here. The problem is that after the pthread_join is executed: ... i = pthread_join (main_thread, NULL); ... sleep (10); /* break-here */ ... there's a race between: - the breakpoint at break-here triggering, and - the "Thread exited" message for the main thread being reported. Fix this by: - adding a loop before the break location - waiting in the loop until the "Thread exited" message is seen - sending ^C to get a prompt - setting a variable to exit the loop Likewise in gdb.threads/non-ldr-exc-2.exp. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34425 --- gdb/testsuite/gdb.threads/leader-exit.c | 4 ++++ gdb/testsuite/gdb.threads/leader-exit.exp | 22 +++++++++++++++++++++ gdb/testsuite/gdb.threads/non-ldr-exc-2.c | 5 +++++ gdb/testsuite/gdb.threads/non-ldr-exc-2.exp | 22 +++++++++++++++++++++ 4 files changed, 53 insertions(+) diff --git a/gdb/testsuite/gdb.threads/leader-exit.c b/gdb/testsuite/gdb.threads/leader-exit.c index bd546d009cd..b24817e8a14 100644 --- a/gdb/testsuite/gdb.threads/leader-exit.c +++ b/gdb/testsuite/gdb.threads/leader-exit.c @@ -21,6 +21,8 @@ static volatile pthread_t main_thread; +static volatile int wait_for_exit = 1; + static void * start (void *arg) { @@ -28,6 +30,8 @@ start (void *arg) i = pthread_join (main_thread, NULL); assert (i == 0); + while (wait_for_exit) + usleep (100 * 1000); sleep (10); /* break-here */ return arg; diff --git a/gdb/testsuite/gdb.threads/leader-exit.exp b/gdb/testsuite/gdb.threads/leader-exit.exp index b5e6f558ac7..22f27d2d6e8 100644 --- a/gdb/testsuite/gdb.threads/leader-exit.exp +++ b/gdb/testsuite/gdb.threads/leader-exit.exp @@ -30,6 +30,28 @@ if {![runto_main]} { return } +# Wait for the "Thread exited" message. +set re_thread_exited {\[Thread [^\r\n]+ exited\]} +set saw_thread_exited 0 +gdb_test_multiple "continue" "continue to thread exited" { + -re $re_thread_exited { + set saw_thread_exited 1 + # Get a prompt. + send_gdb "\003" + exp_continue + } + -re -wrap "" { + pass $gdb_test_name + } +} +gdb_assert {$saw_thread_exited} "thread exited" +if {!$saw_thread_exited} { + return +} + +# Let the inferior to exit the wait_for_exit loop. +gdb_test_no_output "set var wait_for_exit = 0" + gdb_breakpoint [gdb_get_line_number "break-here"] gdb_continue_to_breakpoint "break-here" ".* break-here .*" diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-2.c b/gdb/testsuite/gdb.threads/non-ldr-exc-2.c index b05479be01f..a9e81dfa495 100644 --- a/gdb/testsuite/gdb.threads/non-ldr-exc-2.c +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-2.c @@ -26,6 +26,8 @@ static const char *image; static volatile pthread_t main_thread; static char *argv1 = "go away"; +static volatile int wait_for_exit = 1; + static void * thread_execler (void *arg) { @@ -34,6 +36,9 @@ thread_execler (void *arg) i = pthread_join (main_thread, NULL); assert (i == 0); + while (wait_for_exit) + usleep (100 * 1000); + /* Exec ourselves again. */ if (execl (image, image, argv1, NULL) == -1) /* break-here */ { diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp b/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp index ead262cc2b5..dfc34f42afe 100644 --- a/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-2.exp @@ -37,6 +37,28 @@ proc do_test { lock_sched nonstop } { return -1 } + # Wait for the "Thread exited" message. + set re_thread_exited {\[Thread [^\r\n]+ exited\]} + set saw_thread_exited 0 + gdb_test_multiple "continue" "continue to thread exited" { + -re $re_thread_exited { + set saw_thread_exited 1 + # Get a prompt. + send_gdb "\003" + exp_continue + } + -re -wrap "" { + pass $gdb_test_name + } + } + gdb_assert {$saw_thread_exited} "thread exited" + if {!$saw_thread_exited} { + return + } + + # Let the inferior to exit the wait_for_exit loop. + gdb_test_no_output "set var wait_for_exit = 0" + gdb_breakpoint [gdb_get_line_number "break-here"] gdb_continue_to_breakpoint "break-here" ".* break-here .*" -- 2.51.0