From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qTpVJ27BYWr7HSgAWB0awg (envelope-from ) for ; Thu, 23 Jul 2026 03:23:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=JImeXL2g; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 99A921E09E; Thu, 23 Jul 2026 03:23:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ACC781E099 for ; Thu, 23 Jul 2026 03:23:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB6A54BA23D3 for ; Thu, 23 Jul 2026 07:23:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB6A54BA23D3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=JImeXL2g Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 396CB4BA2E0D for ; Thu, 23 Jul 2026 07:22:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 396CB4BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 396CB4BA2E0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784791376; cv=none; b=oaRlbZfa8Lc9eydssDCnTh2yWQMHzhcnAtEYF4ccMNA8bjGoJNFjgJA+fPnLjpXmromjvR/fhPX7b9U66ttKifJr3HuwFs+96Kwa4uL/14oRNfYc7jXG1x4tNEM6kyWDndkBtaZd7EZLIPisfUVerGRjz1d+NO2hd0eHfX63ouQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784791376; c=relaxed/simple; bh=oSB9SSGjznxWPcLyK1G+iPtt23Nq5SToxRO36AsQD8E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EMmROlbR9T+xUjOaNLL/P4VlZBANCTjclS7SroSRTzIripBtGHwFni0cYpA78nstSOzTkDxX7HAJqoZu8ACo0K94062fMkKjkTYhDHDTi+/urgvmYZYsxmSLzPzSf1//GmmXI5b79FyVhHt0ezt1c+VeFSTiKg5v7+HdGRSeIzk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=JImeXL2g DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 396CB4BA2E0D Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-38dd55ad76cso134913a91.1 for ; Thu, 23 Jul 2026 00:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784791375; x=1785396175; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lRWWtjMUze80BoPPOESD/6zSlvYyLjxR/N4tM3Uoxg4=; b=JImeXL2gvY6ScY7azxRXaSM1cq5dUwt7IRhIZesWv/9TTnHhFQKvsxz5WDM9vkYFui 67ZHpAZp+zoA6Ju6mqh9Ch1m1ycCtw1oQDUXzmq2y9ulf18ol1YdJaEUb2IG2TrOAYd2 p2oTqlZ48lz8FoyOSSPfGoo/klOQe5N3phG6zUB/6l4rPVFY4iDt9bKqmvm2xRIah9qT EA7qO1pr0XcWsGWox+AOc8DfAmteavii82wdV08BTniPLZjmF3m5yyyhngf2jv3B+T6U OrWoQIpKDDLWMh/9wlTaLsrx6j3Ia7F89T6twpPjfdGS8Djo8He4VMdlYHGy0kIAyVwA hUVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784791375; x=1785396175; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lRWWtjMUze80BoPPOESD/6zSlvYyLjxR/N4tM3Uoxg4=; b=Ux+9XCQXPsIkS43lpokJ4m0yjDwnOKsbuNpwj+zLie9Xk0x3IG6TWoHrBTI9gTPpvI uGtgWP/Z/jphDNGIEPr2Vl6D0Yrt3OQrQmBkbryMTIx3jBvNES3J1MWXXVNdivg5njpQ KPypcIK7puze3ZGqOnpINf7GEEA5yaFDcqM4CRPSr/DdAD0/31wNp3RSq2Eo0bNXiaWZ bvDn7w57VeRIT6g3aClmnIUq2rVonY/NrNYTtg0XcXEMmaZF8qUsffAVZw4Etc658pwL Kd+aPzmR+KIf25J3tWXOgDkP0gu9BYYAL0V3ZraGrpSrYJTHUodbym0UX1d9aJgffAsk c4GA== X-Gm-Message-State: AOJu0Yy8CLCRcUR7sm+EloauRk9a4hzVkwlmYJcKQr3e6iQc/I6Rmmdj F5TDEh0/5luphxeEz6FY2GUIifBYV1NkMzwJSf6Hhf1kfqnSI8uo8fGD X-Gm-Gg: AR+sD11ysGk0cLUNF54IsahWny5AMqDWa1IGHpNAovnT9ps2Q786UNlDuDirdEKFBAs srWUX4B59A3YeSczzDS0PvezJ+Q1mTVDDThbcwdwzDvWKbAclAxb19+9NvaCOy2rjmKNtkbtV3t eWnBEMY4ACVn3rxZPEU3BmxC2pwB/5IcqwC3h0N0dCPpXgCoIHqSx0hKlQow3jYZuj562ytxcAo MHOauOHQWu8xsX3PrnVYG6sRdoF7szpUOGazkJEP9+iXrhoPgXDyP2OQ2pNbmdxtoV0PpZVOHXB lY4gDJdvX3eX4IALEJRUHpj3TPViB7knPe9fQUEuGeba3Lfot3bK5kO8lO20U+WWLRV2xy8imYu rJXPI4pMvI04sufSSjISKrQIcMIlkmXOgqru5wISQBPESOj+rJ84bQP6+aurXGBKaCR4dyyX/dI GEuF78PamMbcA67V7ZJnHO3BV4YnpXrqA= X-Received: by 2002:a17:90b:5103:b0:380:8bb9:aba9 with SMTP id 98e67ed59e1d1-38ec839714emr1806129a91.3.1784791374908; Thu, 23 Jul 2026 00:22:54 -0700 (PDT) Received: from localhost.localdomain ([122.171.19.140]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d130f55c6sm21638647c88.15.2026.07.23.00.22.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Jul 2026 00:22:54 -0700 (PDT) From: Aditya Vidyadhar Kamath To: ulrich.weigand@de.ibm.com, simon.marchi@polymtl.ca, tom@tromey.com Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com, PRAJWAL.B.MEHENDARKAR@ibm.com Subject: [PATCH v5] Fix crash in AIX when current working directory is NULL Date: Thu, 23 Jul 2026 12:51:32 +0530 Message-ID: <20260723072131.35657-2-akamath996@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Aditya Kamath This issue is seen in other targets as well. In AIX if we do not have read permission in a current directory we get, gdb ~/gdb_tests/simple_test gdb: warning: error finding working directory: A parameter must be a directory. GNU gdb (GDB) 18.0.50.20260619-git Copyright (C) 2026 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "powerpc64-ibm-aix7.2.0.0". Type "show configuration" for configuration details. For bug reporting instructions, please see: . +------------------------------------------------------------------------------+ | Find the GDB manual online at: | | http://www.gnu.org/software/gdb/documentation/. | | For help, type "help". | | Type "apropos word" to search for commands related to "word". | +------------------------------------------------------------------------------+ Reading symbols from //gdb_tests/simple_test... terminate called after throwing an instance of 'std::logic_error' what(): basic_string: construction from null is not valid Fatal signal: IOT/Abort trap ----- Backtrace ----- 0x100943f1b gdb_internal_backtrace_1 //home/binutils-gdb/gdb/bt-utils.c:122 0x100944027 _Z22gdb_internal_backtracev //home/binutils-gdb/gdb/bt-utils.c:173 0x10060faa7 handle_fatal_signal //home/binutils-gdb/gdb/event-top.c:1008 0x4fdf ??? --------------------- A fatal error internal to GDB has been detected, further debugging is not possible. GDB will now terminate. This is a bug, please report it. For instructions, see: . ============================= The reason for the same above is that in AIX, the variable current_directory in dwarf2/read.c can be NULL if getcwd () fails during GDB initialisation. When this happens the dwarf2_per_bfd construction initialisation list captured_cwd to NULL resulting in this segmentation fault shown above. There are two reasons this happened: 1: The current working directory got deleted in another terminal. 2: Insufficient permission to read the current directory or its parent/predicissor directory. This patch is a fix to the same. Afer this fix we get GDB loaded correctly. gdb ~/gdb_tests/simple_test gdb: warning: error finding working directory: A parameter must be a directory. GNU gdb (GDB) 18.0.50.20260619-git Copyright (C) 2026 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "powerpc64-ibm-aix7.2.0.0". Type "show configuration" for configuration details. For bug reporting instructions, please see: . +------------------------------------------------------------------------------+ | Find the GDB manual online at: | | http://www.gnu.org/software/gdb/documentation/. | | For help, type "help". | | Type "apropos word" to search for commands related to "word". | +------------------------------------------------------------------------------+ Reading symbols from //gdb_tests/simple_test... (gdb) q Also adding a test case for the same. The reason I could not do it in a simple exp file is AIX is protecting the currrent working directory when I try to delete. It says The requested resource is busy. So I had to write a C code the fork () and child will delete the current working directory. Then from here exec gdb with a binary having dwarf symbols to reproduce the crash. --- gdb/dwarf2/read.c | 9 ++- gdb/dwarf2/read.h | 7 +- gdb/testsuite/gdb.base/getcwd-fail-helper.c | 84 +++++++++++++++++++++ gdb/testsuite/gdb.base/getcwd-fail.c | 20 +++++ gdb/testsuite/gdb.base/getcwd-fail.exp | 70 +++++++++++++++++ 5 files changed, 186 insertions(+), 4 deletions(-) create mode 100644 gdb/testsuite/gdb.base/getcwd-fail-helper.c create mode 100644 gdb/testsuite/gdb.base/getcwd-fail.c create mode 100644 gdb/testsuite/gdb.base/getcwd-fail.exp diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 114c608fde3..5b163041e02 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -859,7 +859,9 @@ dwarf2_per_bfd::dwarf2_per_bfd (bfd *obfd, const dwarf2_debug_sections *names, bool can_copy_) : obfd (obfd), can_copy (can_copy_), - captured_cwd (current_directory), + captured_cwd (current_directory != nullptr + ? std::optional (current_directory) + : std::nullopt), captured_debug_dir (debug_file_directory) { if (names == NULL) @@ -6735,7 +6737,10 @@ try_open_dwop_file (dwarf2_per_bfd *per_bfd, const char *file_name, int is_dwp, gdb::unique_xmalloc_ptr absolute_name; desc = openp (search_path, flags, file_name, O_RDONLY | O_BINARY, - &absolute_name, per_bfd->captured_cwd.c_str ()); + &absolute_name, + (per_bfd->captured_cwd.has_value () + ? per_bfd->captured_cwd->c_str () + : nullptr)); if (desc < 0) return NULL; diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h index 15dd2abf3a1..a7c1861a64d 100644 --- a/gdb/dwarf2/read.h +++ b/gdb/dwarf2/read.h @@ -757,8 +757,11 @@ struct dwarf2_per_bfd abstract_to_concrete; /* Current directory, captured at the moment that object this was - created. */ - std::string captured_cwd; + created. If nullopt, the working directory was unavailable + which means getcwd failed either due to directory deletion or + permission issues. So paths should be treated as absolute. */ + std::optional captured_cwd; + /* Captured copy of debug_file_directory. */ std::string captured_debug_dir; }; diff --git a/gdb/testsuite/gdb.base/getcwd-fail-helper.c b/gdb/testsuite/gdb.base/getcwd-fail-helper.c new file mode 100644 index 00000000000..1cedc7090e8 --- /dev/null +++ b/gdb/testsuite/gdb.base/getcwd-fail-helper.c @@ -0,0 +1,84 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2026 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* Helper to reproduce getcwd failure by deleting cwd via child process. */ +#include +#include +#include +#include +#include + +int +main (int argc, char *argv[]) +{ + const char *temp_dir = argv[1]; + const char *gdb_path = argv[2]; + + /* Create and change to temp directory. */ + if (mkdir (temp_dir, 0755) != 0) + { + perror ("mkdir failed"); + return 1; + } + + if (chdir (temp_dir) != 0) + { + perror ("chdir failed"); + return 1; + } + + /* child deletes directory, parent execs GDB. */ + pid_t pid = fork (); + if (pid < 0) + { + perror ("fork failed"); + return 1; + } + + if (pid == 0) + { + /* cd to / and delete the temp directory. */ + if (chdir ("/") != 0) + exit (1); + + if (rmdir (temp_dir) != 0) + exit (1); + + exit (0); + } + + /* wait for child to delete directory. */ + int status; + waitpid (pid, &status, 0); + + if (!WIFEXITED (status) || WEXITSTATUS (status) != 0) + { + fprintf (stderr, "Failed to delete directory\n"); + return 1; + } + + /* Exec GDB. */ + char **gdb_args = malloc ((argc - 1) * sizeof (char *)); + gdb_args[0] = (char *) gdb_path; + for (int i = 3; i < argc; i++) + gdb_args[i - 2] = argv[i]; + gdb_args[argc - 2] = NULL; + + execv (gdb_path, gdb_args); + perror ("execv failed"); + return 1; +} diff --git a/gdb/testsuite/gdb.base/getcwd-fail.c b/gdb/testsuite/gdb.base/getcwd-fail.c new file mode 100644 index 00000000000..e2d20ce9349 --- /dev/null +++ b/gdb/testsuite/gdb.base/getcwd-fail.c @@ -0,0 +1,20 @@ +# Copyright 2026 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +int +main (void) +{ + return 0; +} diff --git a/gdb/testsuite/gdb.base/getcwd-fail.exp b/gdb/testsuite/gdb.base/getcwd-fail.exp new file mode 100644 index 00000000000..e0283753932 --- /dev/null +++ b/gdb/testsuite/gdb.base/getcwd-fail.exp @@ -0,0 +1,70 @@ +# Copyright 2026 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test GDB when current working directory has been deleted. +# Reproduces crash: getcwd() returns NULL. + +standard_testfile .c + +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}]} { + return -1 +} + +# Compile helper program +set helper_src "${srcdir}/${subdir}/getcwd-fail-helper.c" +set helper_bin [standard_output_file "getcwd-fail-helper"] + +# Debug needs to be there so we can trigger getcwd the dwarf2/read.c code. +if {[gdb_compile $helper_src $helper_bin executable {debug}] != ""} { + untested "failed to compile helper" + return -1 +} + +set temp_dir [standard_output_file "temp_getcwd_test"] +set gdb_path [transform $GDB] + +# The test code creates temp dir, child deletes it, parent execs GDB +set test "gdb in deleted cwd" +set spawn_id [remote_spawn host "$helper_bin $temp_dir $gdb_path -nw -nx -q $binfile"] + +set crashed 0 + +remote_expect host 30 { + -re "terminate called.*logic_error.*basic_string.*construction from null" { + set crashed 1 + exp_continue + } + -re "Fatal signal.*IOT/Abort" { + set crashed 1 + exp_continue + } + -re "$gdb_prompt $" { + if {$crashed} { + fail "$test - crashed" + } else { + pass "$test" + } + } + eof { + if {$crashed} { + fail "$test - crashed with std::logic_error" + } else { + pass "$test" + } + } + timeout { + fail "$test - timeout" + } +} -- 2.51.2