From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Export SHELL before invoking lineno.sh
Date: Wed, 22 Jul 2026 08:20:36 -0600 [thread overview]
Message-ID: <20260722142036.3276670-1-tromey@adacore.com> (raw)
A user reported that building the sim failed, because their shell was
not sh-compatible. In particular, lineno.sh uses $SHELL to invoke
another script.
This patch arranges for SHELL to be exported when invoking lineno.sh,
ensuring that the correct shell is used.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34407
---
sim/Makefile.in | 2 +-
sim/common/local.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sim/Makefile.in b/sim/Makefile.in
index 5438d778a3f..1f9bbfec03f 100644
--- a/sim/Makefile.in
+++ b/sim/Makefile.in
@@ -1994,7 +1994,7 @@ CGEN_GEN_CPU_DESC = \
$(CGEN_ARCHFILE) ignored $$opcfile
CGEN_GEN_MLOOP = \
- $(SHELL) $(srccom)/lineno.sh \
+ SHELL=$(SHELL) $(SHELL) $(srccom)/lineno.sh \
$(srccom)/genmloop.sh \
$@.lineno.sh \
-shell $(SHELL) -awk $(AWK) -lineno $(srccom)/lineno.sh \
diff --git a/sim/common/local.mk b/sim/common/local.mk
index 01712aee98d..f765cf57fea 100644
--- a/sim/common/local.mk
+++ b/sim/common/local.mk
@@ -234,7 +234,7 @@ CGEN_GEN_CPU_DESC = \
$(CGEN_ARCHFILE) ignored $$opcfile
CGEN_GEN_MLOOP = \
- $(SHELL) $(srccom)/lineno.sh \
+ SHELL=$(SHELL) $(SHELL) $(srccom)/lineno.sh \
$(srccom)/genmloop.sh \
$@.lineno.sh \
-shell $(SHELL) -awk $(AWK) -lineno $(srccom)/lineno.sh \
base-commit: 293f50b84a9664213fde309e2dc51a49d719029c
--
2.55.0
next reply other threads:[~2026-07-22 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 14:20 Tom Tromey [this message]
2026-07-22 18:38 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722142036.3276670-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox