From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QfY8MsebYGpCwCQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:30:31 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bSd2Umqr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C9ACD1E09E; Wed, 22 Jul 2026 06:30:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F03181E099 for ; Wed, 22 Jul 2026 06:30:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6EAB34BA2E2B for ; Wed, 22 Jul 2026 10:30:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6EAB34BA2E2B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bSd2Umqr Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by sourceware.org (Postfix) with ESMTPS id 1F99E4BA23D8 for ; Wed, 22 Jul 2026 10:28:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F99E4BA23D8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F99E4BA23D8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784716108; cv=none; b=WlTkfBXruftqXE+31a4WOUhUOC1djXlH8GXBmfaHikXucIyhSpu0uyPQlEFpcII+ry2mqlgWS4JpGwVCDo4eungJD5+fHLx7M+6ql2uBCY4Agfx7xWMDDPEQ83iQoKjh9ERNSSLCef9cHF7tbKLn5ZjGzatyj4lQGpLYMHvD1RQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784716108; c=relaxed/simple; bh=ajj1uxy6Tjad++1Z01WE533pj0bwwUY0f4YVaC7WGNk=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=FGKMlbvx8FODUBgqsbAewuBCJWNcSYaSbNGJ3Pv2d6XSSopuNXbGwQuf+ShmLcIfTAAm0Iqrcw85X06ZHxVhQjBhGoQ98QemTD9HoLZQ1BTWOaMoKZqKaGKddJIHh0ynvqKLRtgSsqwQ2RqKCfObqCpPgMcGhw4GqRGIT+DI64w= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bSd2Umqr DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F99E4BA23D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784716108; x=1816252108; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ajj1uxy6Tjad++1Z01WE533pj0bwwUY0f4YVaC7WGNk=; b=bSd2UmqrTYPPzCFbV6JHqojkWVDO3lp5iHXV6SQJdPOPflWjXxbgB2w8 3XEpp2SOAKFFI4+FN9lU3kh4nxKML6iQD8pl4NLA5P5BisIz4lpCLViwo E6LhiUwvDCDyjNzlRkVZdeE0unL9/sIrv6twMk0iVwXxyJ57MusDzQiaF 2A37GoCtAe7XySqpJFWfwE8Ul9ppAVu8pmMtu+aGjKjCMmDVrgOffVaaf Euk5VD8QdIMuDYwsj6HRFwDC42w8INrfaiFI2hoIi2LSNQXbYZzFep9fh yrXhAMtxlH+v4ee/0VtVjtc50MNL6omOPr3bTnSt0epEosgSn2Dvf7nj/ w==; X-CSE-ConnectionGUID: pGC1C5v6S4W5pFx/qBC3xw== X-CSE-MsgGUID: lZlHH7PFRju4ci43FgiEKw== X-IronPort-AV: E=McAfee;i="6800,10657,11853"; a="85293908" X-IronPort-AV: E=Sophos;i="6.25,178,1779174000"; d="scan'208";a="85293908" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2026 03:28:27 -0700 X-CSE-ConnectionGUID: /rd+ADgTQ0GYMNJVgtHevw== X-CSE-MsgGUID: 7d1/FjtnRoW30GYNFlWO5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,178,1779174000"; d="scan'208";a="257517926" Received: from dut1629dg2frd.igk.intel.com (HELO localhost) ([10.211.178.246]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2026 03:28:25 -0700 From: Klaus Gerlicher To: gdb-patches@sourceware.org Cc: tom@tromey.com, guinevere@redhat.com, eliz@gnu.org Subject: [PATCH v8 2/6] gdb, cli: remove left-over code from "set_logging_on". Date: Wed, 22 Jul 2026 10:27:42 +0000 Message-Id: <20260722102746.131536-3-klaus.gerlicher@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722102746.131536-1-klaus.gerlicher@intel.com> References: <20260722102746.131536-1-klaus.gerlicher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Natalia Saiapova This is a refactoring. Remove the left-over code, which rewrites the logging filename in "set logging on" command. The code became unused after the deprecation of "set logging (on|off)" command. Before the deprecation, the command could also take a file name and rewrite the logging file, e.g.: (gdb) set logging on lalala Copying output to lalala. Copying debug output to lalala. After the command was deprecated and reimplemented as an alias to "set logging enable on", additional input after "on" became invalid: (gdb) set logging on lalala Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated. Use 'set logging enabled on'. "on" or "off" expected. (gdb) set logging on lalala "on" or "off" expected. (gdb) set logging enable on lalala "on" or "off" expected. (gdb) set logging enable on Copying output to gdb.txt. Copying debug output to gdb.txt. --- gdb/cli/cli-logging.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index c9482d59199..33bb42bb444 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -270,11 +270,6 @@ handle_redirections (int from_tty) static void set_logging_on (const char *args, int from_tty) { - const char *rest = args; - - if (rest && *rest) - logging_filename = rest; - handle_redirections (from_tty); } -- 2.34.1 Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928