From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0eGZGC6fYGo3ziQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:45:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=B1hcf8Ws; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4819D1E09E; Wed, 22 Jul 2026 06:45:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EA611E099 for ; Wed, 22 Jul 2026 06:45:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B9FC64BA23E5 for ; Wed, 22 Jul 2026 10:44:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B9FC64BA23E5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=B1hcf8Ws Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azlp170100005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c005::5]) by sourceware.org (Postfix) with ESMTPS id 2CDB34BA2E05 for ; Wed, 22 Jul 2026 10:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CDB34BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CDB34BA2E05 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c005::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716976; cv=pass; b=iOqI9NUgu2nAUJuCRefsCZ4DXA3CztJOE65WeNOL8T9Vq4LpYOywq/6pR73aeT6od1kZY6xRunv4tUqCFVzfHgr095P9sYbkCrbtwjOGwxM2BuIAomlwcqlvAHY63kpKtARlu+924yk1TN09dSUebV7vT2fVWre14u913r8mu/I= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716976; c=relaxed/simple; bh=yUAHToxeZwzGHP7zDb8xDIOWZAm449c8ncwtgV3VY+Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Pc8/TnMNIPyzEC6laeI7ScYdxIdyWQKsLscYp2asmglNQNJC9oX1NBUJd17cav6pFf/ajbjyAvmHA83cWMD+6FhScb66bCjimuTdhutso6AjEOvRxmeQAfulH2uD/t7KggEQCEOUT+MxUhZMNPLOiuaSALybbNN1RM4sk05hMCQ= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=B1hcf8Ws DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CDB34BA2E05 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ic/sj/tZOf6N1afB+PHufpsvkuHvT3MgoK9wk0tEaWeodepq1pwJouGfAr5G3L3q7F2b7izkwPJ5umUPX4kPhwki+FEW/6AAtBeAdwGFo0JlYVFzueQAz6zbY36HCh6D1WPB1QNlmhyiHnis5nA2kIlXL6jqLLMq7kPUTFRs6vDxRx8X20D0r+x8adYON2W56ekCEhRr8DeYdJXpwmVYCVRxl7C9ETSKGxGIMSMpO/KQxpiMdaG4LpPIBjBMBZfN6g+ayQaLeEt8foAmCSX5bUSkPSptGL/WJmzQq4N6kTQ1lQ6lJ3SMPTQoV8Z6aqibfHj9Tvp+BgK5uZksYAAQNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+mJl5MFl4GuLLz6nrwsXiX77fj7dtr4fj4mmtoVNFLU=; b=RnT1znNadBL0IIL++01PMm39Q7oRr8/+YqOPJuXMg9k5RYHsmiaka8TUWC/FdiXcXh6P+vvhoKDfK21WZ/fJpqzcWm6k2wDS8z+zhAjTs7umCpm1zfnsbWqMSm39p/IhQkKyZeYml6iWnLGebTwpw+lpx0VxwpW+/20h9BefVwrRQC/VOm9mCV7Hifojc71EdZxLHX6S1p9VSBUw8sl+G2aT+83NtWFNdnZReW7xPr2v4CqMzoB7ZJxmNQlqFyOY6a1VIvGgu+ohjhnmwn7OuigArONl4UCA4dJPym5H5Mci6m1mbc/NihA6q8NJx5GDJkMzMIW9LPVjB3ie+zBeQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mJl5MFl4GuLLz6nrwsXiX77fj7dtr4fj4mmtoVNFLU=; b=B1hcf8WsR5U3Xch92bs4YJ3KsCvZNjLPXtMORw2akd4xneZ69vsUlLQkJodRJJkmzlFWmMKAtBxHArGfv8VePeSUFjIex9AvbzJj3bKVcKrp8vi3KyYhg2oHdIXlyaZfnO5qOL+vbpC0Eg2hC5fpnWe+8Xkx4x1zAZ77bmvD3BA= Received: from CH0PR03CA0114.namprd03.prod.outlook.com (2603:10b6:610:cd::29) by MW4PR12MB5642.namprd12.prod.outlook.com (2603:10b6:303:187::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Wed, 22 Jul 2026 10:42:51 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:610:cd:cafe::1b) by CH0PR03CA0114.outlook.office365.com (2603:10b6:610:cd::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:42:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Wed, 22 Jul 2026 10:42:51 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 22 Jul 2026 05:42:46 -0500 From: Tankut Baris Aktemur To: CC: Subject: [PATCH v2 17/17] gdb: remove unnecessary braces in recursive_dump_type Date: Wed, 22 Jul 2026 05:42:06 -0500 Message-ID: <20260722-users-aktemur-type-instance-flags-v2-17-d60dcbc2a76f@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> References: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|MW4PR12MB5642:EE_ X-MS-Office365-Filtering-Correlation-Id: 46cee57b-fd34-4b3f-0431-08dee7ddfab1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|82310400026|36860700016|1800799024|6133799003|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: x4X5Q9KakdF3YumgYTOc+y2STkAfaJEcm2Mb7Wtj9bEkHRAg5tIt/4vt+TzCVX7IA2j2MoaztA5Bv4CYGW6v8nffTo9BU0gauCDl1xjZP5nliQqEFqlr/dwA82TSkMG9AwJyEXzl4AIIXxNVtTXGQpLfTayvvbxNZqUonrZdmM9nyFQs1o7VzmTg0MWnn6sdRZSKmNWxIAUXBV1krjMzK+9o+gmTeDaFCyIDWNlPkKtt0tQqWYLnEOdYNpJ8aTsV3kFMSXDJB38nMGojM56Mx0etyMcpGiyDWWn9JrMgtGqIgdui40rq524D5vtz04VW4cQp3Rm3o3M3UYrtriwFVlSUdd7GCFHdtJ4AQXhj3LeROzWmpyizfrn2SjVhSAdVx30MNwBiLWArAdtFaaDWttY0Iod41LGPsmDXv7XBruwW3OmEgOBWLk1HLWyiufxPoIoZcsm5m3v/ONjOOxQr3hEk4qb/R56hUviXYpr2qdYG7gBc6oGTOJYjGG/h0tjCWM+Zlbr5U3V3+K41mdxFB14yqRMNQ0sHkG4GHVuTgn0TyIH6IkhA0eXFoEbcBbCjjgNNgInlQ/W7JdyHuaRcdP1fyagq0QIat2l2EqHMvt02g1+D8cj3bgTog0QzCzJwoFcR9iYAx9QHhhkTRByqEkIIxJ76qBmLuFNdbsqe8HGJecUdTNI/Ij09HbC5WxbVrKcx0lhuTsyyVZGJSM6GLA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(23010399003)(376014)(82310400026)(36860700016)(1800799024)(6133799003)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JpSxZDGiapoL4Wgk+IJfBSQthWEwdMAxrqXjSOALWn26vN1PdyDLDF6j1BjvKb0NqvuDkw3HsN28lZNwm35DG9nn2VPjbH25lQ1IndnuSJVnu9hHOdVf/aWj4CRZdq3x8/HBUPiZ95iGn3YTSojnZTB0moiH4kZbiaUqjw3SVuiAcPn40nDjmkb9bB05mwgVKTZG8rmpZzF1yuszx2/0N9JGgLgfE/AX5gD/W8DQJWNdxs46FhpgH0VfK0xDkH3uEelMdYgT1rKmTONgT9fkQT1Fd915PPrfKrgW39RDxsCNf6WSxNOswtCxfnQsCZLplZXsV5OMsPGT+iQC4TISVoZRqldW8YnsZXnCAMGhA9jX5+cJFETMcsOADZHEr0lvRZFWNGn9EcVI1m/gb7xVf7gjrnIayr4HZif0h//SkwtirzbxVmHR5JMV8WhzFYBl X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:42:51.2343 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46cee57b-fd34-4b3f-0431-08dee7ddfab1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5642 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Following the refactoring patches, remove unnecessary branches in recursive_dump_type to comply with the GNU code style. Approved-By: Tom Tromey --- gdb/gdbtypes.c | 46 +++++++++++++--------------------------------- 1 file changed, 13 insertions(+), 33 deletions(-) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index f9764fb1da3..9098727959e 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -5011,9 +5011,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_printf ("%*starget_type %s\n", spaces, "", host_address_to_string (type->target_type ())); if (type->target_type () != NULL) - { - recursive_dump_type (type->target_type (), spaces + 2); - } + recursive_dump_type (type->target_type (), spaces + 2); + gdb_printf ("%*spointer_type %s\n", spaces, "", host_address_to_string (type->pointer_type)); gdb_printf ("%*sreference_type %s\n", spaces, "", @@ -5039,44 +5038,27 @@ recursive_dump_type (struct type *type, int spaces) gdb_printf ("%*sflags", spaces, ""); if (type->is_unsigned ()) - { - gdb_puts (" TYPE_UNSIGNED"); - } + gdb_puts (" TYPE_UNSIGNED"); if (type->has_no_signedness ()) - { - gdb_puts (" TYPE_NOSIGN"); - } + gdb_puts (" TYPE_NOSIGN"); if (type->endianity_is_not_default ()) - { - gdb_puts (" TYPE_ENDIANITY_NOT_DEFAULT"); - } + gdb_puts (" TYPE_ENDIANITY_NOT_DEFAULT"); if (type->is_stub ()) - { - gdb_puts (" TYPE_STUB"); - } + gdb_puts (" TYPE_STUB"); if (type->target_is_stub ()) - { - gdb_puts (" TYPE_TARGET_STUB"); - } + gdb_puts (" TYPE_TARGET_STUB"); if (type->is_prototyped ()) - { - gdb_puts (" TYPE_PROTOTYPED"); - } + gdb_puts (" TYPE_PROTOTYPED"); if (type->has_varargs ()) - { - gdb_puts (" TYPE_VARARGS"); - } + gdb_puts (" TYPE_VARARGS"); + /* This is used for things like AltiVec registers on ppc. Gcc emits an attribute for the array type, which tells whether or not we have a vector, instead of a regular array. */ if (type->is_vector ()) - { - gdb_puts (" TYPE_VECTOR"); - } + gdb_puts (" TYPE_VECTOR"); if (type->is_fixed_instance ()) - { - gdb_puts (" TYPE_FIXED_INSTANCE"); - } + gdb_puts (" TYPE_FIXED_INSTANCE"); if (type->is_nottext ()) gdb_puts (" TYPE_NOTTEXT"); gdb_puts ("\n"); @@ -5128,9 +5110,7 @@ recursive_dump_type (struct type *type, int spaces) gdb_printf ("\n"); if (fld.type () != NULL) - { - recursive_dump_type (fld.type (), spaces + 4); - } + recursive_dump_type (fld.type (), spaces + 4); } if (type->code () == TYPE_CODE_RANGE) { -- 2.34.1