From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qfuLKqSfYGo3ziQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:47:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X/C++1zh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A44711E09B; Wed, 22 Jul 2026 06:47:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1DE171E09B for ; Wed, 22 Jul 2026 06:46:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 986EA4BA2E16 for ; Wed, 22 Jul 2026 10:46:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 986EA4BA2E16 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X/C++1zh Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazlp17011000f.outbound.protection.outlook.com [IPv6:2a01:111:f403:c100::f]) by sourceware.org (Postfix) with ESMTPS id 9219C4BA2E2E for ; Wed, 22 Jul 2026 10:43:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9219C4BA2E2E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9219C4BA2E2E Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c100::f ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716981; cv=pass; b=d4LII7owRSowSYgQewpiQPVZFYsrRJHN1YmeEd74YvQsydjLVRp7uxq2S/lR04tmpIKkrX+Ga/T7PdPn3K2IvtLqyZC26frk9+OcEMI2PDUdHGUc2lONrMiTEmtdkVnbH5SSDrbmhD12Ki7hbESozROLYY+S0dwe1BhZlDLzU2o= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716981; c=relaxed/simple; bh=Einb7siN66hl6YVujKsBrDR0iYLRZb/CUAtddPzxRdE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FbQFVduQJ+mEWk3ABbQxy+iTnD4TS5giPI/eiL7hOfl3sPCPA7AdAqsu7Nc7TLLktbPFf4NpbfBy/cKWyZdC6r1KxTI0R2B9t4O/nspi5WzYCGLNKCcsSmNS67eaQlAM/HeojeNyDpmZhvwwT8+q9CKo+YHIcXoZcA4/M3JdYec= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X/C++1zh DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9219C4BA2E2E ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jV6yd3o3hORS+WWHOm0Crr2uyGkdrbJt3rfLoYqLN7efxR3lJuMFIMEgYsVH9gKke/lBZpN6mizwRmq2g1j/LQzRSDqQGs5AXE1AmsHhLXTP9FeDJAthe57bT+CeGO7ItvipEwmoIgcCV4wpOawtq9GsZuW9l7nWjDuoiHIJMGdgIfR4UPGq3qJUfwy2fp4GxTm0iBvpWpw4+fctwneQcV7yLqp0B0FYSMGH6D1azD5xxT/aOZrsWDWj1DFSkb4ukIyoqHWuTNhMRLukfYvfEHN2h0s6jd3YXpwN9oIY9dpTrfhySukMYuqvRw21ggKXn9FsPPspdTZ7fY1LxHPXeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gepI2J70+8YVxLHvuj4zSix6Y9LeFTV5sX40bg5j974=; b=OYK6iww+5WWbqQ8/bubZvMkd8Zc5/Ncxzkl5wWO+zjOgGAvv3YVPdYiggFB2NtYVanEMX/2TTsfFdOUCTQ3TIFzKbQTMf6Expb0rjOzW4S9a7dhhFgIg0JTVZkVigxoCy9HFxrf86K2I6fYsNba8SRGfaZaTiLGW7senf3joL18wX6IwUuN9BgG2fDAIJWP/9KSCnAOepfA5oIVpbiSbcIzH0fwyaycKPjmsz/y7UuuxQsRIdILBFNkDZqj7qdogWjLoyvkwPnLkgzLJjrcc9Y4xcKIui6dKAfnwjbViuCD9cTl6fL0xpzMugNJZItRYQWtYwFiDSsdoguZCmYwoLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gepI2J70+8YVxLHvuj4zSix6Y9LeFTV5sX40bg5j974=; b=X/C++1zhX3nBz67cxQC14AGyNnOuf++S8pKTRgEZQYeO7fji6nLzoQlNmVJ7xDV7utOTIF7R6H7vTj74faEXaeEI9MLAbjRMwVriwGQPxCxbW8BKzNycHkq+XA+iYCRNqk095gbtq1xd+XS157L4LK9ssaOhyCToTCBm6c5M45c= Received: from CH0PR03CA0112.namprd03.prod.outlook.com (2603:10b6:610:cd::27) by DS4PR12MB9795.namprd12.prod.outlook.com (2603:10b6:8:29e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:42:51 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:610:cd:cafe::1f) by CH0PR03CA0112.outlook.office365.com (2603:10b6:610:cd::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:42:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Wed, 22 Jul 2026 10:42:50 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 22 Jul 2026 05:42:46 -0500 From: Tankut Baris Aktemur To: CC: Subject: [PATCH v2 16/17] gdb: convert TYPE_ADDRESS_CLASS macro to type::address_class Date: Wed, 22 Jul 2026 05:42:05 -0500 Message-ID: <20260722-users-aktemur-type-instance-flags-v2-16-d60dcbc2a76f@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> References: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|DS4PR12MB9795:EE_ X-MS-Office365-Filtering-Correlation-Id: 633d6f17-3576-42c8-a66e-08dee7ddfa72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700016|1800799024|23010399003|376014|22082099003|18002099003|11063799006|10067099003|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: G0FHuFvmCCHPc/Tf31TE7bz73A6KH2bJVR83ExxUrJHaQE2yvS9wkzsAPeOsU5ouYBQ/UjqDsf2N3vI/l4P2jMa+d9QjTHQCLxlllgJ4lxwnrInkUE2Zvo5asF1mfcwWcqAEOpFCsY623ElMlK1pldsfK/VQ/JNpaeHoIpsKS72pEE2CpGj5hL4jqZvoCyeOYB8X09sYDj0zl0rrF6AfTJBkm0bRVDbVj6jKbAIcPrOBMV4SAMYHnSB6DqFtm2ORtixA4tVaQBzNx9qtdKmeK2Dtiqb9RSc2WlWgLOaYt9LdobDLa/mWqrZEJ3l2MkSIdKE/ejnx/wnNw/zP1IrqbcRkcy3JWMdNRjhJBzg/wGojtM1L5tzNBVOVIQfMz/dlSOZyqdDNacPxpei5QCz7K8fxBm4c0J2b/lyikp24w8ti0Ducrxe4qdk7LFLT67KXegR96e0YDVtZD9+X1FvWWBykNeaW/U9GYOh1DP8eovB7uPBw4/6JkoFiZRYShHH5WGptucI1+8iuOtNTxwHwPDxswqKP7VauRmJtOv/T4g4jIAiWGcnQKMHsvY+XsE6oJrYhw4/gS79sfQ0D25p5U2+T7x78jtzqw9axD794KTXLxo+Oc7ccmHTrugIWEksDYINaDbFo/ZL/lDtgnP9gcnszOhjoow18ULptCC/WTK7aJKPwxIJxwEJ5z3F6rRbjy1eydwRPBMQlTudrkq3Y7g== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(36860700016)(1800799024)(23010399003)(376014)(22082099003)(18002099003)(11063799006)(10067099003)(56012099006)(6133799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ahSAgdC7NewUMXFx/Y44OFCM/heLK+jOyGc8en+yG86Sb7bMPhLR8eiGB9lLew8z3HcY9+BAZKg2MlnBIWWJi7yNRQSx8eYBRjzw7vkParXLsagWEgWsckc5MirBE0bA3n6GGGiQOg0zpHdqFMBiV1UjHw/EPaL2GWCkN2WuJlcUlhDkseGYYSe2mlbqYPF8a4/J5qQPlHjzpflyKnS5zUjllJZzPXVq+A2FD3S9b3P1NuS6QcQg0PCo/g+2DTsniyXIZAFDuV7JY/LvWhaYSGnoK+TO6WEVaxPWEXESTPWCiCTksJLgE5W50hj1DmfOEhYAX6e4blLH3Ume5LbFWA5QsCLRnWkoLj5Y/Pg1ZqQxF7yoKVibfHdO8nwBdc9Zwn3x0FZu7JyaCydAUQ6gcpsCpTwFPw/KzBgEt/12ez6Cl/Tb2LitNAVQqi9jIZXC X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:42:50.8249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 633d6f17-3576-42c8-a66e-08dee7ddfa72 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9795 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_ADDRESS_CLASS macro to a method of the type class. This is a refactoring. --- gdb/avr-tdep.c | 4 ++-- gdb/c-typeprint.c | 2 +- gdb/ft32-tdep.c | 2 +- gdb/gdbtypes.c | 8 +++----- gdb/gdbtypes.h | 9 ++++++--- 5 files changed, 13 insertions(+), 12 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 682b7e8586d..012022f2b73 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -305,7 +305,7 @@ avr_address_to_pointer (struct gdbarch *gdbarch, enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); /* Is it a data address in flash? */ - if (TYPE_ADDRESS_CLASS (type) == AVR_ADDRESS_CLASS_FLASH) + if (type->address_class () == AVR_ADDRESS_CLASS_FLASH) { /* A data pointer in flash is byte addressed. */ store_unsigned_integer (buf, type->length (), byte_order, @@ -337,7 +337,7 @@ avr_pointer_to_address (struct gdbarch *gdbarch, = extract_unsigned_integer (buf, type->length (), byte_order); /* Is it a data address in flash? */ - if (TYPE_ADDRESS_CLASS (type) == AVR_ADDRESS_CLASS_FLASH) + if (type->address_class () == AVR_ADDRESS_CLASS_FLASH) { /* A data pointer in flash is already byte addressed. */ return avr_make_iaddr (addr); diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index 92938270647..07f01c92b15 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -492,7 +492,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream, else if (gdbarch_address_class_id_to_name_p (type->arch ())) address_space_id = gdbarch_address_class_id_to_name (type->arch (), - TYPE_ADDRESS_CLASS (type)); + type->address_class ()); if (address_space_id != nullptr) { diff --git a/gdb/ft32-tdep.c b/gdb/ft32-tdep.c index f951a6f25e3..38b4784ed35 100644 --- a/gdb/ft32-tdep.c +++ b/gdb/ft32-tdep.c @@ -332,7 +332,7 @@ ft32_pointer_to_address (struct gdbarch *gdbarch, CORE_ADDR addr = extract_unsigned_integer (buf, type->length (), byte_order); - if (TYPE_ADDRESS_CLASS (type) == 1) + if (type->address_class () == 1) return addr; else return addr | RAM_BIAS; diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 34eaac42e20..f9764fb1da3 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -710,7 +710,7 @@ replace_type (struct type *ntype, struct type *type) variants. This assertion shouldn't ever be triggered because symbol readers which do construct address-class variants don't call replace_type(). */ - gdb_assert (TYPE_ADDRESS_CLASS (chain) == 0); + gdb_assert (chain->address_class () == 0); chain->set_length (type->length ()); chain = chain->chain; @@ -5029,10 +5029,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_puts (" TYPE_CODE_SPACE"); if (type->is_data_space ()) gdb_puts (" TYPE_DATA_SPACE"); - if (TYPE_ADDRESS_CLASS (type) != 0) - { - gdb_printf (" TYPE_ADDRESS_CLASS(%u)", TYPE_ADDRESS_CLASS (type)); - } + if (type->address_class () != 0) + gdb_printf (" TYPE_ADDRESS_CLASS(%u)", type->address_class ()); if (type->is_restrict ()) gdb_puts (" TYPE_RESTRICT"); if (type->is_atomic ()) diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 624d468e4f2..ecd71f96497 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -186,9 +186,6 @@ struct type_instance_flags (((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \ || ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr)) -#define TYPE_ADDRESS_CLASS(t) \ - (((t)->instance_flags ()).address_class) - /* Information about a single discriminant. */ struct discriminant_range @@ -1231,6 +1228,12 @@ struct type return this->m_instance_flags.is_atomic; } + /* Return the address class of this type. */ + unsigned int address_class () const + { + return this->m_instance_flags.address_class; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { -- 2.34.1