From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2UHaBiqfYGphziQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:44:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=u1CDQ3M4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 117461E099; Wed, 22 Jul 2026 06:44:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E953B1E099 for ; Wed, 22 Jul 2026 06:44:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 725EA4BA23E2 for ; Wed, 22 Jul 2026 10:44:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 725EA4BA23E2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=u1CDQ3M4 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012041.outbound.protection.outlook.com [52.101.43.41]) by sourceware.org (Postfix) with ESMTPS id AE1B24BA2E07 for ; Wed, 22 Jul 2026 10:42:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE1B24BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE1B24BA2E07 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.43.41 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716973; cv=pass; b=lKq3D0ZaS/Ii583iT7rPphPS3lhhpB33sZc0/+AHzrck/r6gISPuMhFmrG+EEh7W8Rw8EGcwZjGWmBWOBslYjgwh0q1yRPdS9vzzHFZm4gKHEyrIvat8t5CT444y1f3ivNfWDZORYcacIZL0JXaOhChe0cNxUw+YuJfGUS+hLTo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716973; c=relaxed/simple; bh=rerT39rAaa+ABaIegO3LKYFWxBEsHuLkDjuJpoxtOxU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QF8z4LdAg3/IaGzVQzGyW11FMvkSsTd5XJMcIJYsTMt/3fra2UfRNlfRNANa1AKP9zk5iU+WSaFKfhBKWpv2atbfRRcJblDguX0c5mSlfDzc02BrIimwG5M9bujdgxNQVep87AKWuRmvfQV0uDmb84t76f3eLxFsBaK8lyFKuC4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=u1CDQ3M4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE1B24BA2E07 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NGSnqxmuPuFyLb994Rid937wcTqdbZh97BAefLXIX7MWcbmCboaPtTRuXiOf5MZr6H/D5Ta5yzCu3nbxq0p/8RqSTkw7U54bPFzQW/eI547xg/WR9iHTbUkY64HTM1lUGPDF/KFWaii2p/5tJnLHCBYDXPD7yKKj9CDYvqxBCnZWd5c0wLDOf1Es4sPM03qckNdvQ8nNKSYK5aTUDY9q2W/vxF9lGwoK1wFVc9lt1zXDBbMWspZtvazaPT2Ueh5Ewbt+yRW+A4bfYEsChP8Itx+ZkRbv99+KkKoThACu8X2ecaqmZLdEVgSGjARz/cQ1D691oYBGdtwF2WjUbfQBuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJq0Z4erp22tCCNV6dx/FE8k6KFuas5MZQ6+zs/mVgc=; b=QqXI7T6Oy5gCKaK+U5vVSNG9pss6mQejL8xHGXclGCN7dFWImMsPb/KAmPhWqKF8vKxaNJW/19CLlv/jRcGdsZbfwnHMVPEhijgWxed2ZIeol3SwY508qs9uuhVSBgm3pDn7axIiN384LTkuYKawqiE2hyZxpIV9UIJPoxtNVCAJBTlcKHBrAoUxvxwxmWK4RW263eWfXcyXFhtD+LLmY3EV2jWfMxxv1wGipcYUUGfo7j1M9ARmECJQWl4pdCI/lc1tNLh6971iME7X5grcHtSay5TVBcDRlYkVLpBsKUtJIs4Vy0M9HNhHGw4tG2S4FD/nfV+UvuJrHp43CluIXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJq0Z4erp22tCCNV6dx/FE8k6KFuas5MZQ6+zs/mVgc=; b=u1CDQ3M48zArfRP7XSKlCo6VkamSKU5oyVBdg0uqF4khevrsikV5n4gl+Oi5vB+0bNtg1Vhv8JV4vv9wekjqP/kop+pMcQNYuvFNRECk8oKyQfhN3ET9oVL/B+bT/skbskiieB8Wv9+HPTWikFKVO/Jq7sZswB7ecRKqy1AaQ8k= Received: from CH0PR03CA0095.namprd03.prod.outlook.com (2603:10b6:610:cd::10) by DS5PPFA33D606F8.namprd12.prod.outlook.com (2603:10b6:f:fc00::65b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:42:49 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:610:cd:cafe::1d) by CH0PR03CA0095.outlook.office365.com (2603:10b6:610:cd::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:42:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Wed, 22 Jul 2026 10:42:48 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 22 Jul 2026 05:42:45 -0500 From: Tankut Baris Aktemur To: CC: Subject: [PATCH v2 12/17] gdb: convert TYPE_CODE_SPACE macro to type::is_code_space Date: Wed, 22 Jul 2026 05:42:01 -0500 Message-ID: <20260722-users-aktemur-type-instance-flags-v2-12-d60dcbc2a76f@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> References: <20260722-users-aktemur-type-instance-flags-v2-0-d60dcbc2a76f@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|DS5PPFA33D606F8:EE_ X-MS-Office365-Filtering-Correlation-Id: 59744388-7cc5-402b-a81f-08dee7ddf950 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700016|376014|23010399003|82310400026|22082099003|18002099003|3023799007|10067099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: 2Pu7+/WtjHeQBSoEXFIyj2Ja1wECEkY7qHeAWtZHxFYHoGDqeLdDhmqAjqXUNMdTfDgoENP3dlv6vz9d0zvlyz4qOUcfJum8uFX4ttn+K+CFFwD+NN9FR4IoJI2d1ctgcp/eOwBXrpEnSXyifdxKLb+nf93f+AE56I/Tks9zakY6r84a4ZJ/3cm31IXsHjpd3O+dstkUMm7Ofrh+JR0mhqjojwukQTYgK7vn6HhRrhWLAGdf45qNVbs7zC4jZVvY1x/0tPz25cBhzkERPxkx9XCMmNTfAsSDmy6L9VHVjvYJhnxu5/xMlEZ/P3qDLT8olub+RylnOXW9b/55OGIdBLfQWwlQ1mFXsQgqpSzISCPIsGYw/ciinZUnVvF/3O5q/Gq+g+G9mfDnpCwGuOAsHL77qtgxvBzzmxJxz+Lo/Y0tb7X8MbQexXvyMgKa0gKzzjIP/HCIyTbQQ+UYXog9eyyIyH7B+F2nTHtrOhUaAcEhaMDQNsSI2LwIdNYg9BDWcqCPeeGhVk9wL4knP+k/qRm3QVwLtQu5NbDoblHDWOuunt0n1SVRWSxbCVJJrNGZrMJ8GZYb0YmYc+rBs5znEYbE1TbbKxv937FAiETYOaL1dS8bg/Ngbu2VwLcrerlN5rR4D9WRflQqidtnk5nHZjLYH0/HmeB0XwmvQmd0GRM1c5PQ3ttiyEKlNr1wV5DKowqBfU6rtH8eR2nENnoLrw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700016)(376014)(23010399003)(82310400026)(22082099003)(18002099003)(3023799007)(10067099003)(56012099006)(11063799006)(6133799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uhEFXWE8pXGajrUCnbMCWCuyLVFHjZkZ87ICIwY2J+DxiwtRKQppmjcWSJN1LhwA853Tlc4B8rCwOZSGDs0jfLq2N8jpzTuFPHqsKwsI1D34KvK6i1/vzALxP/NG3OXUw7o/r0ENVsnfpvfYBRgNu7XWoqPCphpZrFfthlWiUs5Pfv1OmeSAMgIWCAp1WUakIe7B2dsYK7OUiszS3ob2XGZRf68/blZUErkXwCPFMd2QCYOeS+KnEa3bNPPReonczKYXZ4/H5YE35f68syKm/b+LST0WCJDqB5oC6U7h/x0Cd7iHnzVzQMeBqLg8DeF4zeCUHwc5WI+h0wp3BA467HMY0CWnqvRd8fLV+G1x4gyKdcsp/PvZa4nuUL4xjuzcEGUhdW/Zo6IWKlFaHLxqQxyNQTyHv/yx0e0mg8i3D0KLnnb6qonRsNCfLSQ2Ya2f X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:42:48.9261 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59744388-7cc5-402b-a81f-08dee7ddf950 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPFA33D606F8 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_CODE_SPACE macro to a method of the type class. This is a refactoring. --- gdb/avr-tdep.c | 2 +- gdb/c-typeprint.c | 2 +- gdb/gdbtypes.c | 6 ++---- gdb/gdbtypes.h | 9 ++++++--- gdb/iq2000-tdep.c | 2 +- gdb/rl78-tdep.c | 2 +- 6 files changed, 12 insertions(+), 11 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 2191ada4c2e..26b786c68b7 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -345,7 +345,7 @@ avr_pointer_to_address (struct gdbarch *gdbarch, /* Is it a code address? */ else if (type->target_type ()->code () == TYPE_CODE_FUNC || type->target_type ()->code () == TYPE_CODE_METHOD - || TYPE_CODE_SPACE (type->target_type ())) + || type->target_type ()->is_code_space ()) { /* A code pointer is word (16 bits) addressed so we shift it up by 1 bit to convert it to an address. */ diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index fb8b228ea38..a8927e0ac43 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -485,7 +485,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream, address_space_id = nullptr; - if (TYPE_CODE_SPACE (type)) + if (type->is_code_space ()) address_space_id = "code"; else if (TYPE_DATA_SPACE (type)) address_space_id = "data"; diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 1019f02e2e1..465af4790fd 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -5025,10 +5025,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_puts (" TYPE_CONST"); if (type->is_volatile ()) gdb_puts (" TYPE_VOLATILE"); - if (TYPE_CODE_SPACE (type)) - { - gdb_puts (" TYPE_CODE_SPACE"); - } + if (type->is_code_space ()) + gdb_puts (" TYPE_CODE_SPACE"); if (TYPE_DATA_SPACE (type)) { gdb_puts (" TYPE_DATA_SPACE"); diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 6a8bc425d45..d9988312e1b 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -189,9 +189,6 @@ struct type_instance_flags (((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \ || ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr)) -#define TYPE_CODE_SPACE(t) \ - (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_CODE) - #define TYPE_DATA_SPACE(t) \ (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_DATA) @@ -1216,6 +1213,12 @@ struct type return this->m_instance_flags.is_volatile; } + /* Return if this type is in the code space. */ + bool is_code_space () const + { + return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_CODE; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { diff --git a/gdb/iq2000-tdep.c b/gdb/iq2000-tdep.c index 32e3750aca4..783e1720a02 100644 --- a/gdb/iq2000-tdep.c +++ b/gdb/iq2000-tdep.c @@ -95,7 +95,7 @@ iq2000_pointer_to_address (struct gdbarch *gdbarch, if (target == TYPE_CODE_FUNC || target == TYPE_CODE_METHOD - || TYPE_CODE_SPACE (type->target_type ())) + || type->target_type ()->is_code_space ()) addr = insn_addr_from_ptr (addr); return addr; diff --git a/gdb/rl78-tdep.c b/gdb/rl78-tdep.c index 0de2fceb795..4204ce5c8cb 100644 --- a/gdb/rl78-tdep.c +++ b/gdb/rl78-tdep.c @@ -1052,7 +1052,7 @@ rl78_pointer_to_address (struct gdbarch *gdbarch, /* Is it a code address? */ if (type->target_type ()->code () == TYPE_CODE_FUNC || type->target_type ()->code () == TYPE_CODE_METHOD - || TYPE_CODE_SPACE (type->target_type ()) + || type->target_type ()->is_code_space () || type->length () == 4) return rl78_make_instruction_address (addr); else -- 2.34.1