From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UdnPN+U2W2rFQhAAWB0awg (envelope-from ) for ; Sat, 18 Jul 2026 04:18:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cw46h3+T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=f2tg7Si2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2SVtUSo+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ow2v3QHw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CFBD41E09E; Sat, 18 Jul 2026 04:18:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5AEEF1E099 for ; Sat, 18 Jul 2026 04:18:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10AE94BA23F8 for ; Sat, 18 Jul 2026 08:18:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10AE94BA23F8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cw46h3+T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=f2tg7Si2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2SVtUSo+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ow2v3QHw Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 291404BA2E11 for ; Sat, 18 Jul 2026 08:18:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 291404BA2E11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 291404BA2E11 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784362699; cv=none; b=dkb4YfHP5HoSl4WXNY5MLGnyMqaDsFsx1oIKQ39zHkp3/1H4pUrqURAO/GjAg7p6nn+D3o7BUmfJ/nfBw40Sfivwi2w+V/n2fjkJprZnA32GDw4C3XwhAGLwwoGk5hjADVjC9YpHPjJCAI2LXJml6tUKwNurj71ujt8+BsRPYQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784362699; c=relaxed/simple; bh=BXPWTAKRKb86pdnha7STs7ywSia6lUwriU1jvNdp5r8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=VjkmYPoiziqKDBaWffQVt91tje44K+CJ25KZfYe4tQ7b/HAKe13rY92i1AoknrTwYwlbBrft3U0clyTq5/j5G4pf3WUiUL/qMn9AaD+iM4Xoh0r3xyo70CNuQRia09435oFKQHvGg7my91GufKw5ZKhJSnyKfSj2JUcY9O3mXnA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cw46h3+T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=f2tg7Si2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2SVtUSo+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ow2v3QHw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 291404BA2E11 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E55EF79342 for ; Sat, 18 Jul 2026 08:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784362698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8gtFKxkPh5W7ZuGc4i5qzgFnBgMi3G+NbhcB6yF7rQk=; b=Cw46h3+TFkK2XfIdQFq31LOM5XmVGgGtL3Yq1EpmSKdc6kCsCC88IzkrWhXl9O2x9cx16b XDpn4HCjaD6PxY/UWxVVZ3uYBG+KVr7bh6PRRZ7y0vtBpoBV1vULLsBi0LOg21gpVIZ9rJ xvBtEOF+rOVxSr/nMSbqHAJb9rIkRwc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784362698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8gtFKxkPh5W7ZuGc4i5qzgFnBgMi3G+NbhcB6yF7rQk=; b=f2tg7Si2TbrIIv1+yJWYQUzFur448+QfNZ6MRiCW4JdgsxoC3Ne1O4+gXKyFOgY/hpz9Ca wEPnZG7ZHKX+npDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784362696; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8gtFKxkPh5W7ZuGc4i5qzgFnBgMi3G+NbhcB6yF7rQk=; b=2SVtUSo+XapfhTq3+5pFVf81cEie6j80kKprH2T2XGRRFgpj36XmXAM3KeYoRWZs8sf1Tm kTTAKtTplGnscoPhFgp8anT2mv0cF1pnpNxmeNxlmxMtycmfcWAGC0Wej3LMUnUoU82zX5 Uy0eTEa5b87X94bwcRCY21DDBy5/JOQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784362696; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8gtFKxkPh5W7ZuGc4i5qzgFnBgMi3G+NbhcB6yF7rQk=; b=Ow2v3QHwSN08BeaCfwwoH2fL2Ssjt5ybczPPS/U/EemUR4612LGjIiIEdUs8qY12FHwHEH oFUvPITuReQnssCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C59CE779AA for ; Sat, 18 Jul 2026 08:18:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Hfg4Lsg2W2o0BwAAD6G6ig (envelope-from ) for ; Sat, 18 Jul 2026 08:18:16 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [pre-commit] Set stages for isort Date: Sat, 18 Jul 2026 10:18:16 +0200 Message-ID: <20260718081816.3681295-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.69 / 50.00]; BAYES_HAM(-2.89)[99.53%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that isort runs for the manual stage: ... $ pre-commit run --hook-stage manual isort...............................................(no files to check)Skipped ... That happens because unlike any other repo we're currently using, isort's .pre-commit-hooks.yaml sets stages: ... stages: [pre-commit, pre-merge-commit, pre-push, manual] ... overriding the default setting in our .pre-commit-config.yaml: ... default_stages: [pre-commit] ... Fix this by adding a stages setting to the isort hook. --- .pre-commit-config.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 141f14ba72c..60164e446fc 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -74,6 +74,9 @@ repos: - id: isort types_or: *gdb_python_types files: *gdb_python_files + # Isort's .pre-commit-hooks.yaml sets stages, overriding default_stages, + # so this hook needs an explicit setting. + stages: [pre-commit] # Codespell hooks. - repo: https://github.com/codespell-project/codespell base-commit: 705b16039e6f1e499b96d8ecd08d5154f62d7d38 -- 2.51.0