From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0WcdN7NhWmoxEg8AWB0awg (envelope-from ) for ; Fri, 17 Jul 2026 13:09:07 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=KaARYJtw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D5E121E09E; Fri, 17 Jul 2026 13:09:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1BE7A1E033 for ; Fri, 17 Jul 2026 13:09:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E1D4E4BA23C3 for ; Fri, 17 Jul 2026 17:09:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1D4E4BA23C3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=KaARYJtw Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 703F04BA2E11 for ; Fri, 17 Jul 2026 17:07:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 703F04BA2E11 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 703F04BA2E11 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784308077; cv=none; b=Nb9XBU5Z4i8YiiPAuImWuEU9926FCQFWmeG01jwYDOSRD6LoFYIymZ3/YClw2G2qRR7QtXaXE1LiSsAz0WynlTjPuKh1Hm9dRAbhPX5EBQmQgrlKHG7xkKncHvbj7t8+AHtQs64N4cO48rmgDB4XWFCa0T7ARmBkfFIhr0FMua0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784308077; c=relaxed/simple; bh=G5HmGbGTa/2oHNBTxqZJVYI16VScVt2lXittyTGGq9s=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=T7FV2AlVFaXmK7wyuq+1X5bgohChXcfhjU0XOs8h02mPtF+7aHMGmKTsVQRlvf1Mq64Fmj4wTRN9XGCZtINOxDFLtUlMp0+xfPYCb4tRibZwpiKIOQC7IkoYIVs9CF43A9i2ZmFjwWPZg2qd77p1pubKJFDgIhD2rfL3Xq1RDG0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=KaARYJtw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 703F04BA2E11 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-448479e0eb6so3093451fac.2 for ; Fri, 17 Jul 2026 10:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1784308076; x=1784912876; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j16pQDkSi28IpRd/UjqEXGj75pswK3ZMamgIlbPT800=; b=KaARYJtwp4fTMbaK1NEcZYURf3CM75EEZDLnvlcCxogju06hzOVcNelGi1hQ/E3UhJ wRiWQFNuwNlWmZrwSgOO2XQ9rVwNjksj/tD1AjOVEB3zuuInwmqRY787sX7QULSOr/Us TI1H7Qa9Gb/dpxD6tikUOn5yF4G/0Tm5B4lmPJUArmtqSB74rNKyOMWAFmeyTAcgfH+2 DLwVT3m9CnnvV7SOPPnHaBeRv298j0xaM8kGHmafQGrvcVY1AfL2HKiMz0ppyZ/i0dvh N2PF7qoavP8p6unZju7tIUL6JJu/0AvqP1YpYPG7vZFQ7Ybs0JO6o8dxloOaEKYG0IAo rY+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784308076; x=1784912876; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=j16pQDkSi28IpRd/UjqEXGj75pswK3ZMamgIlbPT800=; b=f4/JDwJv1321lTO48BQQL4qEPqqnHj58yrMv0fqtk3LYkfHEhagqbYwc92Th97OkKA ddfwg0qcxWrgh61pPcNDVuGMnAr3ekE2upVLmYO5GSvX1kC44xF2+F/1sOqPuJxEIv// P3wR34SoJGxyCghJyru2jH7aUih1LQpa9OxiGM/SRaN86BL15IxBVVbKplOMKX3Zrcxw MeJU201OcVihOsXL3FTcu+eTjfFkeH//GC9gTETXWjlsUbTUK7lvN8X1ZvEnco8yX7oZ NkFDxzAKzxqfa5dPNWv6DGwcUGAAhfyW0dc2CfNaqUiaBlfDeqaRQIUVfXO2s/Bmc8sH 5kfQ== X-Gm-Message-State: AOJu0YwNie+pedR54mC2e/CK+UZEPNL90GJL50SZTBxc4WfSVqDVSKd2 hx1u8/NjPrUvC30Eo8ftmpjAIgnBxig94UHIInhmhTsZr2/Kt3PY7j3Gd54PulW3qwBFS6ds17G E6zI= X-Gm-Gg: AfdE7ckPJDzhD3vvolg1vNjVsG4BDfL4ke1aQu+la5w+UEuyPt9ZFc83BIWYEEBQEBD 47mYYlefkjsSFh57tOvBb9/+D1TRO9AV5JgDuhgjOdylQIe91nFfOxY9TGgBvuMGkRFaBWHoFlM tSrH+j0F2TC0iLhzlnzsWZDZhZZPfz2H0jlTLk3L/vcTguFjAQQmGjz7n6hecrn4pBtT+lmDGqZ M3FFwcqChrt8GFPJScuH/23HwOpgLmXvSc2131SADvlubEL47Q+b1nn4NcBqTzIS1qYCO5Dy7xz U+KW9DBrcXKYhHh1/bvVPKVghCW8VqrlM0QZgjITthQdVe81DjaVBYCY03FvgQyBQzA+5XHsrAK O7FgeRMiGOIlmOtW5I3uv77CbKWbygSRjkzDRjlyau5Rr61fIpbAX5ceORkSE7llcZ9OAh83m8V /tpkeCtrClfiAakbqZRQQypwuOGtxpVzisyWVWCY5MwsU= X-Received: by 2002:a05:6870:9688:b0:456:37ad:24f9 with SMTP id 586e51a60fabf-45690652bd2mr1541423fac.42.1784308076466; Fri, 17 Jul 2026 10:07:56 -0700 (PDT) Received: from [192.168.0.26] (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4568e625105sm1796839fac.11.2026.07.17.10.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 10:07:56 -0700 (PDT) From: Tom Tromey Date: Fri, 17 Jul 2026 11:07:54 -0600 Subject: [PATCH 2/2] Use F_SETFL after F_SETOWN MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260717-f-setfl-v1-2-0d1eec47cf25@adacore.com> References: <20260717-f-setfl-v1-0-0d1eec47cf25@adacore.com> In-Reply-To: <20260717-f-setfl-v1-0-0d1eec47cf25@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.15.2 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes enable_async_notification to use F_SETFL after F_SETOWN. This order more correct because it ensures that the owning process is set before the request to enable SIGIO. --- gdbserver/remote-utils.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc index ffde4956776..e92adf903ce 100644 --- a/gdbserver/remote-utils.cc +++ b/gdbserver/remote-utils.cc @@ -128,13 +128,11 @@ static void enable_async_notification (int fd) { #if defined(F_SETFL) && defined (FASYNC) - int save_fcntl_flags; - - save_fcntl_flags = fcntl (fd, F_GETFL, 0); - fcntl (fd, F_SETFL, save_fcntl_flags | FASYNC); #if defined (F_SETOWN) fcntl (fd, F_SETOWN, getpid ()); #endif + int save_fcntl_flags = fcntl (fd, F_GETFL, 0); + fcntl (fd, F_SETFL, save_fcntl_flags | FASYNC); #endif } -- 2.55.0