From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GGFsFv0MWWpU/gwAWB0awg (envelope-from ) for ; Thu, 16 Jul 2026 12:55:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M4Xh6lPi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=icxjQ443; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M4Xh6lPi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=icxjQ443; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 48ABB1E09E; Thu, 16 Jul 2026 12:55:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 449361E033 for ; Thu, 16 Jul 2026 12:55:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07CB14BA23C8 for ; Thu, 16 Jul 2026 16:55:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07CB14BA23C8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M4Xh6lPi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=icxjQ443; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M4Xh6lPi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=icxjQ443 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id BC2784BA23C3 for ; Thu, 16 Jul 2026 16:54:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC2784BA23C3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC2784BA23C3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784220877; cv=none; b=ZVcONyesGEsCFti4g8vyWWzf1Q7OihZK1791+N8aZVBi+sM6l42wBjLvIYAS4oWTF7UoGwyh3yqB8Vr8ixvIB9vI1tNbK5iZ4E+0PbTrmr3c2yea9dNy/yBUsNDSYDoe1Vnk+rjt4EfOmFXvOFjDXEwx/gXNtD5C7dzY0sAd6oc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784220877; c=relaxed/simple; bh=JnWxar0/ZdpUeIPWPsi3Mbh6OB/1B8J9ly3imZTC6L8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=qF4AmkJDwWPucQhXq//c/JIp1wXSSi+Y6dfI+UO7lcowsxwEhrDDoM5BRmgxVNo1V9tTpvwV8mogX6lIRzohnLl8QJL+0feUEMbCxDhK9n6e+ZYTnwJCdqlwaSqeOJ1o48YoHztfes8nwec1zgE5Qw4uL5X9oT0FdzMtq2l3BeE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M4Xh6lPi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=icxjQ443; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M4Xh6lPi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=icxjQ443 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC2784BA23C3 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BDB1E78A3C for ; Thu, 16 Jul 2026 16:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784220876; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=z+/+JF1lLgEWJ8pGlKXoq2H0Jh/wGywSKHg1ncP8uxI=; b=M4Xh6lPiuIbRK7iEsjwQHCYyZo8fghrQY/S6jxCEA/bcxNkmeXDmxD9Edswc92pNEGobpN +AJIfi3O8NA1+s/UjwRxkgX2orAndvJAA37yINHD8uVk0BDT1gldlNeg/MXPRV9G+xhSDB jd/l8ge58AKLg61dbDSGHOxMlAozoYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784220876; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=z+/+JF1lLgEWJ8pGlKXoq2H0Jh/wGywSKHg1ncP8uxI=; b=icxjQ4433+GYVxaZI4Lb6r/noWbt+WU7USDreGrSk+uRvbGIcRtQfvqTsQdeme6pK6KhUQ O+PGjERZ+mkDO4Ag== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784220876; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=z+/+JF1lLgEWJ8pGlKXoq2H0Jh/wGywSKHg1ncP8uxI=; b=M4Xh6lPiuIbRK7iEsjwQHCYyZo8fghrQY/S6jxCEA/bcxNkmeXDmxD9Edswc92pNEGobpN +AJIfi3O8NA1+s/UjwRxkgX2orAndvJAA37yINHD8uVk0BDT1gldlNeg/MXPRV9G+xhSDB jd/l8ge58AKLg61dbDSGHOxMlAozoYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784220876; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=z+/+JF1lLgEWJ8pGlKXoq2H0Jh/wGywSKHg1ncP8uxI=; b=icxjQ4433+GYVxaZI4Lb6r/noWbt+WU7USDreGrSk+uRvbGIcRtQfvqTsQdeme6pK6KhUQ O+PGjERZ+mkDO4Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A8B7C779AD for ; Thu, 16 Jul 2026 16:54:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KL/TJ8wMWWq6UgAAD6G6ig (envelope-from ) for ; Thu, 16 Jul 2026 16:54:36 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [pre-commit] Fix codespell-log hook Date: Thu, 16 Jul 2026 18:54:36 +0200 Message-ID: <20260716165436.1416427-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org A recent commit added this top-level setting to .pre-commit-config.yaml: ... files: '^(gdb|gdbserver|gdbsupport)/' ... This broke the codespell-log hook, which is a commit-msg hook, which is called with the commit message as first argument. However, the top-level files setting filters out .git/COMMIT_EDITMSG, with the consequence that the commit-msg hook is no longer called. It seems obvious to me that this is a pre-commit bug: the files field is there to filter files in the repository, which .git/COMMIT_EDITMSG is not one of. But upstream disagrees [1]. Use the workaround suggested as fix upstream: include .git/COMMIT_EDITMSG in the default files set. [ FWIW, that still doesn't fix something like this: ... $ tmp=$(mktemp) $ echo 'msg' > $tmp $ pre-commit run --hook-stage commit-msg --commit-msg-filename $tmp ... I wanted to mention that upstream, but I couldn't because I was already locked out of commenting on the issue I filed. ] Alternatively, we can drop the top-level files setting, and revert to per-hook settings. [1] https://github.com/pre-commit/pre-commit/issues/3720 --- .pre-commit-config.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 2f86a333ab5..fda10e30b1d 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -40,7 +40,9 @@ minimum_pre_commit_version: 4.5.1 default_install_hook_types: [pre-commit, commit-msg] default_stages: [pre-commit] -files: '^(gdb|gdbserver|gdbsupport)/' +# The ^\.git/COMMIT_EDITMSG$ is there to make sure commit-msg hooks work. +# See this issue ( https://github.com/pre-commit/pre-commit/issues/3720 ). +files: '^(gdb|gdbserver|gdbsupport)/|^\.git/COMMIT_EDITMSG$' repos: # Python hooks. Run these for (in glob notation): base-commit: a4481c8ff808e7237b99815d84b0d4c06ded6124 -- 2.51.0