From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gcpqIgoAVmoHiQcAWB0awg (envelope-from ) for ; Tue, 14 Jul 2026 05:23:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=J02t8/ES; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 866591E09E; Tue, 14 Jul 2026 05:23:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ACCB11E099 for ; Tue, 14 Jul 2026 05:23:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9DBA64BA23CC for ; Tue, 14 Jul 2026 09:23:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DBA64BA23CC Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=J02t8/ES Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by sourceware.org (Postfix) with ESMTPS id 538464BA2E27 for ; Tue, 14 Jul 2026 09:22:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 538464BA2E27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 538464BA2E27 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=192.198.163.9 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784020924; cv=none; b=whRLkHcpca8Lt3rzHp/bYGAx2jEdEuKShOMN99k3wK4vlSar9xiJzit/Vr1LmxqqDj6fv1qPDhf9dsNnA+uXLlPPV7xQ3jin85hltDMplJDak19KpdDpsDccSACKGh17Bt6z1GRCgyzdBtEL+5jfbYLE8JI5aeuHECRyW1UB4oI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784020924; c=relaxed/simple; bh=girmTInhrYqLzul2g2wSvCyB6wkvYkgLpYVbx2iybxY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=atKALqPWp+I978nXDsud3LEp1EwMD2Rj8NgUzeGGZd6O95gFmAFJD76ajfSAgSIpxADX7S6c5H1DgFErXFrqcK5RpJN3gBUveTXxbNpVkTP8YN3dn2UVvbLwYHurRbR+2DA/Ai6sun+ag0EhfpEJAXVcsmnrEVVrf08RSL+ERpY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=J02t8/ES DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 538464BA2E27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784020924; x=1815556924; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=girmTInhrYqLzul2g2wSvCyB6wkvYkgLpYVbx2iybxY=; b=J02t8/ESQA/2sYQqY0F4PJANiJnyLp5maLei4WZSXDjLKPJIHD6q00SA 62xSoQmF9IJvM71+MQ/lVWZtZUNN/1PWMES47ZslfBH26apASWl9V9V/w WNMk5x/6WeILI60KwJOXK09jcyG+0RkBAwtV5t0zarhAL0ezdmsLIQPKW DUdmUBmg/S2Hz67IPEY6yG5FSck4oXR0hIB+B5rgCJFS4ShjA0WXbg5fe NJHtUxDU+LjUtrm/SoUKdB+c7xF16PTQYOyCxWTnIvN9uhN7D1rt38X6v 2JJJacGmRLULuYt+S40PAgRDuJUJkHJriLN4q8ODLdUoeCkKS1rxQ/aAI w==; X-CSE-ConnectionGUID: PPUK5RhmTkuxASgeHTs7NQ== X-CSE-MsgGUID: azJqVhGrTiivZndw4Sjspg== X-IronPort-AV: E=McAfee;i="6800,10657,11846"; a="95284600" X-IronPort-AV: E=Sophos;i="6.25,163,1779174000"; d="scan'208";a="95284600" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 02:22:03 -0700 X-CSE-ConnectionGUID: yP7ADDuSQzeWQ18OB7uLtg== X-CSE-MsgGUID: MUrATRfpQsKZS82dDFjIIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,163,1779174000"; d="scan'208";a="254679403" Received: from sguenant-mobl2.ger.corp.intel.com (HELO localhost) ([10.246.18.94]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 02:22:02 -0700 From: Mohamed Bouhaouel To: gdb-patches@sourceware.org Cc: markus.t.metzger@intel.com, stephan.rohr@intel.com, eliz@gnu.org, aburgess@redhat.com, pedro@palves.net Subject: [PATCH v4 03/11] gdb, remote: fix async handler assertion on reconnect to non-stop target Date: Tue, 14 Jul 2026 11:21:20 +0200 Message-ID: <20260714092128.12941-4-mohamed.bouhaouel@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260714092128.12941-1-mohamed.bouhaouel@intel.com> References: <20260714092128.12941-1-mohamed.bouhaouel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: "Bouhaouel, Mohamed" When reconnecting to a non-stop remote target during process_initial_stop_replies (), the code attempts to mark an async event handler before async mode is enabled. This causes an assertion failure in remote_state::mark_async_event_handler (), which requires the serial connection to be in async mode (is_async_p () == true). Fix by changing the condition in queued_stop_reply () from target_can_async_p () to target_is_async_p (), matching the pattern used in push_stop_reply (). When async mode is later enabled, the event handler will be marked then. Scenario: - Connect to non-stop remote target. - Thread receives signal (e.g., SIGUSR1) and stops. - Disconnect and reconnect. - Assertion fails because mark_async_event_handler () requires is_async_p (). Reproducible when running gdb.threads/reconnect-signal.exp, on native-gdbserver or native-extended-gdbserver with target-non-stop enabled. export GDBFLAGS="-iex \"maint set target-non-stop on\"" make check TESTS="gdb.threads/reconnect-signal.exp" \ RUNTESTFLAGS="--target_board=native-gdbserver GDBFLAGS='$GDBFLAGS'" --- gdb/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/remote.c b/gdb/remote.c index 7022e58abab..c5c2814aa55 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -8325,7 +8325,7 @@ remote_target::queued_stop_reply (ptid_t ptid) remote_state *rs = get_remote_state (); stop_reply_up r = remote_notif_remove_queued_reply (ptid); - if (!rs->stop_reply_queue.empty () && target_can_async_p ()) + if (!rs->stop_reply_queue.empty () && target_is_async_p ()) { /* There's still at least an event left. */ rs->mark_async_event_handler (); -- 2.43.0 Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928