From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GU2KBoDwVGohPQYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 10:04:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=zm5lnJUI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1663A1E09B; Mon, 13 Jul 2026 10:04:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 92C511E033 for ; Mon, 13 Jul 2026 10:04:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37CDF4BA2E07 for ; Mon, 13 Jul 2026 14:04:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37CDF4BA2E07 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=zm5lnJUI Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azlp170120001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c107::1]) by sourceware.org (Postfix) with ESMTPS id 08D324BA2E2C for ; Mon, 13 Jul 2026 14:00:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08D324BA2E2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08D324BA2E2C Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c107::1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951257; cv=pass; b=hya04NJ8OnPvUNH75KBQ9mcvppGptHqwuhWlkASuIg6lsBgSIFzyvj4rPCm33JrwbUY9pyWkYo9mljpBpptTMDbmsoqvm1+m7IiaLzMATsOrZSSeTyazaRTFEUZaWrnNBAaxLNI9QhvDtwdwDlrqtoe41LLHxQR3Htceu2xEza0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951257; c=relaxed/simple; bh=CVr11OhUWzmGAQ5soBkt5FcLUfJgr5oqfJAMVQ8RUg4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=m/IMTQRIWZmIohS7Kp1iloXIMgjBieffJD1Vh/ilRu/SUKZcQMlYERcq3ChTs36b+x5Duo4eZFij7VpdV/TF7olt52LS+mL1aoQLUBjvDxJkaEtHjlVZgJOJ9fECaAyuwapCM4cP1zWOJpPvM2IlB7SjdDnPoSkTEjGc93wCJig= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=zm5lnJUI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08D324BA2E2C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mi2bQW43xOC21UkBE+q1E6tQoPMvIG5zx6Wzeodyhdj4uwdIrSBUALOUsFRohWqe3cYirWKCYjAftpFGlcqn53ponVZo9Nexk99LF6bjmBFGOm2TdGjkdFhSTnwPKlws68VeXDNDHZgWBA1ZpB77vsWzi0YzlKvKCxE88AhqOSP/M/Zk9IUnwm/FLlpgLASYJSqQLFyFulyrRtIFzczIRydZ8mfKeHwFVsbyZXlTO1xZbfmuIsCIb16YyGyJvqepAJwAstyECZoLGQuKTo/yZk9PVT+ksefncFOfRZQ1qUlk6z9YEzyWiZi4Q5KPr/nCU+ZTTyZEVHlqYr9xx9Tu6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FZsJETkWvsV1dS760zvVDfSTilLOAR/+doE1vnvvKxg=; b=KGYWruI+zwDUBmAfrU4waxLPe8FTUGBYQ4m5g0yMEcxK4kvV2ypnbOirPKTqyBZVg05+/iZx5G0x/AsP1sWxjP+OmEOcSGjfjHPRZXViSxz0OErnSfjxksT9ZrIbAFaWg187a8mqR3gKJOKUx5Tkr/S9CZoiSXmcNsVM7cTb24NcwAOQ4YpLjXHvRXafa2AvPRni4ZMbNmD4PymCypKdSY28YgwNcfdrY5fPtryvF/c5NV3v6XT5syFPGFcoTDZA0LNO+XmgwFCmM52bsXMx0mxkBYIv8M+xLq8KjAzmZpQdYibJ3FtGhNJi/3Jt1bMrjVNVpG2Q0DOma8gmWRy/Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZsJETkWvsV1dS760zvVDfSTilLOAR/+doE1vnvvKxg=; b=zm5lnJUIwOPKvBmxQsE9DckrktN2XAyzB0KPBzz59M5nxLeImxLqF4rrvxQQcZE+qatknhcx1XNTaT+ir9zzMdC/kaRYnlRnbUHeO0oASTaM9V0dI+ANephuc2ph4/4HOXJ1SZGIW6/t3zDsUMi4BHZosnbfket9Z0twfMv8Jkk= Received: from CH0P221CA0020.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:11c::21) by IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.23; Mon, 13 Jul 2026 14:00:49 +0000 Received: from CH1PEPF0000AD7C.namprd04.prod.outlook.com (2603:10b6:610:11c:cafe::12) by CH0P221CA0020.outlook.office365.com (2603:10b6:610:11c::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 14:00:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000AD7C.mail.protection.outlook.com (10.167.244.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 14:00:49 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 13 Jul 2026 09:00:41 -0500 From: Tankut Baris Aktemur To: Subject: [PATCH 08/16] gdb: convert TYPE_NOTTEXT macro to type::is_nottext Date: Mon, 13 Jul 2026 09:00:07 -0500 Message-ID: <20260713-users-aktemur-type-instance-flags-v1-8-779cad0c85ec@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7C:EE_|IA0PR12MB8374:EE_ X-MS-Office365-Filtering-Correlation-Id: af14b8d0-0970-4129-ca0e-08dee0e72503 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700016|23010399003|18002099003|22082099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: Xc/I/9ByGzrlxcz7L4fZS2PwcgppvL5h8REeGr8ZxCso2vNzqeoMQdME9lHQ/w1U6GLnEVG/QR3JU1PbSh1475WU+3MZXFbbPUVhYOy5VtQv/K/NXl6UOdYblEiDm9CtodiUM5Ni3X6sBK2PUzAyhLKu+tsrqTujoSMzeSEYBaMdx+DMTYtbLykXM2va3xT5i3quf/w9utT9siB4p9AXgJtUfhbWN1kUf0wKb2jd371yTGVvzhtwLCvT97Ls/mwbBmiq2TKuAQmKnxb/GCWtC1EBMaSIhK8dELGhKPTqYXWZT2zZLbWxfJ3nQ1CQk8yN6VpaziOLQeRuxmxgH6h0DwKks/W+zYf+FjaAGMIkf5lhceID3hx2Z5qAGPUDp/utwn3TKxovdvolG6GNsAzXIygfqmJ61rd8eii8xIjwDdkjG3mYwAlFvfwt8CNfXdAYOD5SKx8XNmMCWXVPEbK6OhezWJ5IT/6FXXwkI6mU2ZdHRLt6G1m4CeTqqrPk78uDqAP5cdPdMm2r8FDDR20Ozf1G0dOsr0lp/LsbJ45Er5TIm2y2Ahw456/6dXyfcSh9pr/rwQNhxEEDD/JXNnKjQZwVEuHuPWk8UJRDBRNKXqbdTbwd+LGO1+IluxRxa23airD63scJOwzuNztnZ8gIXnjtvjvslMegXr51f3Vv8BrbHWrT8fY9lyYJ/bwFUKerzJo134fk2PNCovALgc4BXw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700016)(23010399003)(18002099003)(22082099003)(56012099006)(11063799006)(6133799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4RcSoOyppznG0a9sDvJZjAcePHxTKcVNNNMoTl+J21Dxjui4/nkG4s3Ec+G4aSUKUeNfXBIwhXnz+K96Adx/nN/TzzVykEbLrhut4jjkjVHP5MjuzZx8ah91+dM/iLKQqcy/WKF05FXUfoys4PqptYWvpZYlsITP8AFZgRrjIYR3nNB2Rr9f4gokQE2NHPhLaEYdoDuA3cm5Q6dLAWnDXbSGPR1ll2x1mO4HoUPH/YvbzcsOpnSjq26Nngh7AcZkfIerF0CE3larC7lUt9HeOX/A2KJvuhs8h52iJtj0je02jXC1cM0TG1J66tLRuJVwW0q1rO1oGlMrKpdn1N7EW3zlWGO2/9EKmThLl2ZA1/ghnPxSEjFTR9SGJSGXxrLjdhm+pR+7D3xaAYcpjqdfchzcJ6NYic8AZi3FmbhYgAbZtTC+3D1zFBQ3CgLgewBJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 14:00:49.5710 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af14b8d0-0970-4129-ca0e-08dee0e72503 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8374 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_NOTTEXT macro to a method of the type class. This is a refactoring. --- gdb/c-valprint.c | 2 +- gdb/gdbtypes.c | 8 +++----- gdb/gdbtypes.h | 7 ++++++- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c index 9f9f61ea2e0..2ee65c41061 100644 --- a/gdb/c-valprint.c +++ b/gdb/c-valprint.c @@ -109,7 +109,7 @@ c_textual_element_type (struct type *type, char format) being used as data. */ if (true_type->code () == TYPE_CODE_INT && true_type->length () == 1 - && !TYPE_NOTTEXT (true_type)) + && !true_type->is_nottext ()) return 1; } diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 958a2ff9f29..0ece07cee9b 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -4126,7 +4126,7 @@ check_types_equal (struct type *type1, struct type *type2, || type1->endianity_is_not_default () != type2->endianity_is_not_default () || type1->has_varargs () != type2->has_varargs () || type1->is_vector () != type2->is_vector () - || TYPE_NOTTEXT (type1) != TYPE_NOTTEXT (type2) + || type1->is_nottext () != type2->is_nottext () || type1->instance_flags () != type2->instance_flags () || type1->num_fields () != type2->num_fields ()) return false; @@ -5091,10 +5091,8 @@ recursive_dump_type (struct type *type, int spaces) { gdb_puts (" TYPE_FIXED_INSTANCE"); } - if (TYPE_NOTTEXT (type)) - { - gdb_puts (" TYPE_NOTTEXT"); - } + if (type->is_nottext ()) + gdb_puts (" TYPE_NOTTEXT"); gdb_puts ("\n"); gdb_printf ("%*snfields %d ", spaces, "", type->num_fields ()); if (type->dyn_prop (DYN_PROP_ASSOCIATED) != nullptr diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 19b6e6640ec..605e1eb958a 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -165,7 +165,6 @@ struct type_instance_flags bool is_atomic : 1; }; -#define TYPE_NOTTEXT(t) (((t)->instance_flags ()).is_nottext) #define TYPE_CONST(t) (((t)->instance_flags ()).is_const) #define TYPE_VOLATILE(t) (((t)->instance_flags ()).is_volatile) #define TYPE_RESTRICT(t) (((t)->instance_flags ()).is_restrict) @@ -1198,6 +1197,12 @@ struct type this->m_instance_flags.is_nottext = flag; } + /* Return if this type is nottext. */ + bool is_nottext () + { + return this->m_instance_flags.is_nottext; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { -- 2.34.1