From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eSzFDjzwVGohPQYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 10:03:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=keFMLuCO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3819D1E09B; Mon, 13 Jul 2026 10:03:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9489C1E033 for ; Mon, 13 Jul 2026 10:03:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39A874BA23CA for ; Mon, 13 Jul 2026 14:03:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39A874BA23CA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=keFMLuCO Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012038.outbound.protection.outlook.com [52.101.53.38]) by sourceware.org (Postfix) with ESMTPS id A47A24BA23C2 for ; Mon, 13 Jul 2026 14:01:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A47A24BA23C2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A47A24BA23C2 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.53.38 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951269; cv=pass; b=b9Dz1XXrA+rnqahwhQ58aYC7B6aeSUaQFa8vww6rxF2jGxlNMbY5dY6m3Kf2j4Sb0vV6qU6cBH00xhHkCWlN0LP1+kjoTgIeD98wbZH0GTZa5CwBeP2YESOtptemFLbbzcLFXaDIW4J92f/I8PC5oAzVyoQfrlzkSF4cPq/eRks= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951269; c=relaxed/simple; bh=Eidf71LysjEIUA30duUntsOJTgIrhtI4uaUNOw9kyzk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XVlBjndvSiqoOpudtETUAgsJkRrT8W/azzzW+Pu2CY26/5IlGZC33Dfl+x5mxquyXfj/+lhqbg3CyaHxuw4/vi+Y69TFa6RFrphUebDzMy7RN1bcTGTCyYItV7sdgEh1gUPkbXSdtr5AHouadxS5T0OWVa2umZY2GWY6Ck9xl2A= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=keFMLuCO DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A47A24BA23C2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gDFs92hyZtz4JnzdjSKGQrDHPld/m5WC98FF62Qc+sHTZ9UDk809xWztfnMl60r7fqAGRG0PEQb4h6mWCHLOcQ5ashj6wu/zhTp7bIF4pel8QSC5+mXml539sWlQWa91T/FkIAYrasKd63ucR17I2d4PNyEWOjv+w0JBWmjH2Zw+Pz+5zf4wYEeciRNyaPDhiYWrRBqubycGWZJDXAR+W/cQKsf54lXlfznr9ROLL0/34pGtzQRrKSDw/fbVZhx9ngRHXxiDN5SoauF3IldQPAmt+Y09qtHyTwBffxASchqFFBJ6lZXZS2pWpw/u157MM/vRx/LRopHhlAPjJRJYBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=brCgSmOWWC/aqs8ivmcIWRbH6+DZewKFvHaf5JV1MTk=; b=PMc7t/N2EkDPZl8I5A29RWYAqdRb62EBdTf/d9KGZS2wtn2qPLhs/586pr+3RJzTRzQjQsbSKNVunzTgnusuw5zzN7M14Cafcbeifq262h+KDO3sXCYwvNLg7XJxIRMdmWGIpGmmAH66rmRnQJBT7/gJQfqJ0mlOg7dditjEGFFKVpQjTg0FpwFUWYSzXEN00ixI3xagr0qpjjosKL7XkHGpwwaLEmhkYHzg9l8wDXXk4zj65dVNcByUcs+9xxxDe1/U1LKG8TPXlnytC+K9SpUUVqhckULtuW5En4i1zgesRNWbdGS+de3HMdrhsY6s1KYJ7afoYovpNElfeizCWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brCgSmOWWC/aqs8ivmcIWRbH6+DZewKFvHaf5JV1MTk=; b=keFMLuCO5RE0QWWffTU3BIwy8pcOjn49UzmWt2KQKHBTk5wiyGPCWJvutNqL1v5EZQSFc6pFUbEjDVKC7zUI/zdCDpRsEwH4do5diARU0OLn6AnXfXXIiBTlVsn5d+Pw9/f7SNE79eTrhPqmr7ual3q/yhyNob4TbEra1NdoECI= Received: from CH5PR04CA0007.namprd04.prod.outlook.com (2603:10b6:610:1f4::7) by MN2PR12MB4373.namprd12.prod.outlook.com (2603:10b6:208:261::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 14:01:00 +0000 Received: from CH1PEPF0000AD7E.namprd04.prod.outlook.com (2603:10b6:610:1f4:cafe::62) by CH5PR04CA0007.outlook.office365.com (2603:10b6:610:1f4::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 14:00:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000AD7E.mail.protection.outlook.com (10.167.244.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 14:00:58 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 13 Jul 2026 09:00:44 -0500 From: Tankut Baris Aktemur To: Subject: [PATCH 15/16] gdb: convert TYPE_ADDRESS_CLASS macro to type::address_class Date: Mon, 13 Jul 2026 09:00:14 -0500 Message-ID: <20260713-users-aktemur-type-instance-flags-v1-15-779cad0c85ec@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7E:EE_|MN2PR12MB4373:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f8f0610-aceb-47cf-6104-08dee0e72a88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700016|82310400026|23010399003|376014|6133799003|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: Xp58ZdG0h4GeLl3rCGueEbt9Uen+W0tDvheZRdl6wxOdEbgo7dfwYpID0T0hTZtgX+yb0R5Ldpi/2R3yk+/9eQh+MPJDePz3AXlw54zGqxeCcFIJzZRL2fKw6EBQReXE3xPdi4bJLwkaGAm+ZtIwKmOdmjVTlXdXZG/I4Am/kqnYSt7mzvqGDGC8JBow0EaNGXgxpEAG1kUAMKX82A1ZI3fx9h2ZxfevOsNWjMI4+odg6e0j340ypZC/oYuZ9a3aMiYaHTyGz4ubCKb/9Ft88FxvCMOewIG/FMYwicpSr6YqgXvonpIFlBEVnkzSkYvos7H0OmI20kmnmlJ6DEu5RfkWOOJAQSFT4gxW8QEF5ndPHNCYDMLueisJDW4RW2fh/Dbt46EvOBgodOP51yWoXYRgITchGjrxzK2NIocm++CZE0yFyTaelxHWJ+rTFJFhE/uCQJcJK9hE/4qlfVerPdil1UvyRuMIqRgJnx1xg3t87KpwHSHIgIGlt+f52oq/OKQjPZ7NVoKnVSOwoP5XckihzG+KXzMfmUCCie1JfCqTGJQaIgULJ7TpRsJ1cQeEDLUSbHuX8B1VM/AF7cLioXePeFbiOc07WP0+Iy7jFYGqQ8D0xYCgCp1TjVA+gNY+njdE2RPIZRuAL5R9j2QMhB9MiNq/yWKiSw9/aguHPmbXm7WSwjVKUXmj8d2C752cyz+t0jf1rLeuk9ZXdA7mBg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700016)(82310400026)(23010399003)(376014)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Lkgqbr+T8PD4gKGNtfnW4pA3a3nRU58d1nyHIIYpfj+hbkeJgVMvqv3afj2wiTSFeZM7InzQqR6sHTxLUYXvDaF6ZNFZBZspgo2tzSSducTmH9KIwSAD/1sDpuWQF5T6G3uzv2dnOPJMIya8PNM3QYv/gvRJxmDEyffygoTH3Z13PA0+/Ih1RJy+l7u17zraXypNy1g9nlbe3o6NoTM2AXT45Lc547RTKKCc2fUIrtAp5MOhYtLOKGTDlLBcLHgM26iL7QKNnpeP1u3kJ8wF4RnZkrqj6YKvOKuuJ+wfZcgzhDSjRCXBUORSEjoTDP+i7XP2P3TdrLhuQYxnY9Dyu4V4EBKv6MizeWgXgvxd97WLOYx98TntrpIVP0ha1/y1sYsv7m3Rp5pSlZVHARNXVJnPBKDZIAL4saYWQnbLS35Is5g87M7rxQsyChLy+mlE X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 14:00:58.8288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8f0610-aceb-47cf-6104-08dee0e72a88 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4373 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_ADDRESS_CLASS macro to a method of the type class. This is a refactoring. --- gdb/avr-tdep.c | 4 ++-- gdb/c-typeprint.c | 2 +- gdb/ft32-tdep.c | 2 +- gdb/gdbtypes.c | 8 +++----- gdb/gdbtypes.h | 9 ++++++--- 5 files changed, 13 insertions(+), 12 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 682b7e8586d..012022f2b73 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -305,7 +305,7 @@ avr_address_to_pointer (struct gdbarch *gdbarch, enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); /* Is it a data address in flash? */ - if (TYPE_ADDRESS_CLASS (type) == AVR_ADDRESS_CLASS_FLASH) + if (type->address_class () == AVR_ADDRESS_CLASS_FLASH) { /* A data pointer in flash is byte addressed. */ store_unsigned_integer (buf, type->length (), byte_order, @@ -337,7 +337,7 @@ avr_pointer_to_address (struct gdbarch *gdbarch, = extract_unsigned_integer (buf, type->length (), byte_order); /* Is it a data address in flash? */ - if (TYPE_ADDRESS_CLASS (type) == AVR_ADDRESS_CLASS_FLASH) + if (type->address_class () == AVR_ADDRESS_CLASS_FLASH) { /* A data pointer in flash is already byte addressed. */ return avr_make_iaddr (addr); diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index f02e3f653ea..12dcd486fc1 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -491,7 +491,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream, address_space_id = "data"; else { - unsigned int aclass = TYPE_ADDRESS_CLASS (type); + unsigned int aclass = type->address_class (); if (aclass != 0 && gdbarch_address_class_id_to_name_p (type->arch ())) address_space_id = gdbarch_address_class_id_to_name (type->arch (), diff --git a/gdb/ft32-tdep.c b/gdb/ft32-tdep.c index f951a6f25e3..38b4784ed35 100644 --- a/gdb/ft32-tdep.c +++ b/gdb/ft32-tdep.c @@ -332,7 +332,7 @@ ft32_pointer_to_address (struct gdbarch *gdbarch, CORE_ADDR addr = extract_unsigned_integer (buf, type->length (), byte_order); - if (TYPE_ADDRESS_CLASS (type) == 1) + if (type->address_class () == 1) return addr; else return addr | RAM_BIAS; diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index c34e881ef3c..347237e0094 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -710,7 +710,7 @@ replace_type (struct type *ntype, struct type *type) variants. This assertion shouldn't ever be triggered because symbol readers which do construct address-class variants don't call replace_type(). */ - gdb_assert (TYPE_ADDRESS_CLASS (chain) == 0); + gdb_assert (chain->address_class () == 0); chain->set_length (type->length ()); chain = chain->chain; @@ -5029,10 +5029,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_puts (" TYPE_CODE_SPACE"); if (type->is_data_space ()) gdb_puts (" TYPE_DATA_SPACE"); - if (TYPE_ADDRESS_CLASS (type) != 0) - { - gdb_printf (" TYPE_ADDRESS_CLASS(%u)", TYPE_ADDRESS_CLASS (type)); - } + if (type->address_class () != 0) + gdb_printf (" TYPE_ADDRESS_CLASS(%u)", type->address_class ()); if (type->is_restrict ()) gdb_puts (" TYPE_RESTRICT"); if (type->is_atomic ()) diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 54199dc0786..17b88a3127b 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -183,9 +183,6 @@ struct type_instance_flags (((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \ || ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr)) -#define TYPE_ADDRESS_CLASS(t) \ - (((t)->instance_flags ()).address_class) - /* Information about a single discriminant. */ struct discriminant_range @@ -1228,6 +1225,12 @@ struct type return this->m_instance_flags.is_atomic; } + /* Return the address class of this type. */ + unsigned int address_class () + { + return this->m_instance_flags.address_class; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { -- 2.34.1