From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kUloJ67wVGohPQYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 10:05:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=fdC+ePVP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9E2F61E033; Mon, 13 Jul 2026 10:05:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2EECF1E033 for ; Mon, 13 Jul 2026 10:05:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C36C54BA2E14 for ; Mon, 13 Jul 2026 14:05:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C36C54BA2E14 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=fdC+ePVP Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012038.outbound.protection.outlook.com [40.93.195.38]) by sourceware.org (Postfix) with ESMTPS id DCE424BA23D5 for ; Mon, 13 Jul 2026 14:01:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCE424BA23D5 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCE424BA23D5 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.93.195.38 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951261; cv=pass; b=JwN/pKuQY2KcwgU4zkfQ21UOO2GWCQoz0XDku/c6PIZ2fUF2zCPDnLXmMmdSi3Y51ERrhsuEulRgOJ/Kgg4wFbXvHl0GOUx8Y/b8vmTQfNtI0MHMAyCqGKrNZFzx+mYwCPxQeH3i6+ILz7pGMi1rT3h2roU879xS/m0tJ8Vw/HY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951261; c=relaxed/simple; bh=wLxgsxEjNrvh79hHm9YPIlLOXZEGRZj9wXEX1ybWmTM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AgciC++L52F69uMjbUeZC44i7JMn0WOI5MPG7BF76TNe+yyfQrknIxUHeqL0kcHqIEb9Jh3uCiyvoRfHHW7W/uvG+X3F+R6c1zdC+jsk3WPgM4te+/Qrt5K7o5HS83eDHZB/UnnDg+SrVP5gd1jwH2CAvXyBaaQKtrVFQY4VFvQ= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=fdC+ePVP DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCE424BA23D5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lfGvZE0roTT15J27xMwtD2iKSZKHgLNXl0bY2YmXiiFyJoP9PXb/zD6PmXlYbD6gFPIa4t7sqAbc7FMCjjR9af98uvbLKEvM9J357otA7lyliYzR1PvDoqlCJjgWbe7Cmq2d5BmsrihW+NPPL9dZBIQzeVph7TiBMc5HnUWrK8okQRcMfXujXTZzQCCQ7b50s2tZHwgxEXsjVR62hQFNkNyQWAuk8je0qPAb1ttxPej9SUjyCXIxUj4eirO1iZ7mjBIYMuDnA+lQIiSqy2p2LAT2EgWoQociqWunds5Cek/ObhgNL0dR0ezoqd9GkRqry4q6+qxZLZmLUMopK34nAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=okWYlu0Q7WRuDQHwGsa+Asxbg4t1OYjp1D3BLG6QJic=; b=Ec8xTYrEVJEUUJ7zrz9olZlgc3vmblizyagDDApXg9Uvcro4nLUAUHx4QvmpTBYn9wOjs2y2IsG2AawjDqvhdLcdTXgz8CyDvoTyW5z7I/NJT69abLH2M1s4oeGjbhx2hJyOV+WUbcS5du8EkCMQDLawLYv2Uiv1wr+mVPVvZoBwAVteLmIFESplQ1IOdpZaZP5EzJ8dGsakC5Qnq7MDlQpIo4UvLGDUKnMr40rfKTGpFdYV8bEpQVrM+ajXm+ajBWcumfLrVB2r57dEQrMcuHyYzAAlKs3aU6ZcK/7jBfCy++66XU24GSEuEqPEO+bdBOgbuyOBbLlbI8SpXA1Vjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=okWYlu0Q7WRuDQHwGsa+Asxbg4t1OYjp1D3BLG6QJic=; b=fdC+ePVPVb4dYy3VtGSflP0lNzd0hIOWBOfRMN8JaI2GTSKgj7SXUh3nyxZzmYJtdOv+XqNFZmXM03VKb3RSQjRxv94Ywh4+OcUGhgq2dhEpxp4I2g+xgZFv+ZNvXTOdO2QedjVkTHbF6hxPHQeE4sQC4TMNUBrX936OfKP33/o= Received: from CH5PR04CA0003.namprd04.prod.outlook.com (2603:10b6:610:1f4::12) by SJ2PR12MB7868.namprd12.prod.outlook.com (2603:10b6:a03:4cd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Mon, 13 Jul 2026 14:00:54 +0000 Received: from CH1PEPF0000AD7E.namprd04.prod.outlook.com (2603:10b6:610:1f4:cafe::6) by CH5PR04CA0003.outlook.office365.com (2603:10b6:610:1f4::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 14:00:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000AD7E.mail.protection.outlook.com (10.167.244.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 14:00:53 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 13 Jul 2026 09:00:42 -0500 From: Tankut Baris Aktemur To: Subject: [PATCH 12/16] gdb: convert TYPE_DATA_SPACE macro to type::is_data_space Date: Mon, 13 Jul 2026 09:00:11 -0500 Message-ID: <20260713-users-aktemur-type-instance-flags-v1-12-779cad0c85ec@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7E:EE_|SJ2PR12MB7868:EE_ X-MS-Office365-Filtering-Correlation-Id: d0da0e0e-31e4-4a30-16f3-08dee0e72779 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|18002099003|22082099003|6133799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: iLu/eAjg9XlK/OvJy+ucVV41g4fUZ0xxIWnuBCxiCJDnhgOfTEP1RPeOQp2cnPrY7y3d3jGjCMBa5h8N6OoeZz1dyen9iKH7M63O/ieq3vG2iuXgtL4OPvt5TcBOv1P+zMR9kbL2YoDOhjVyXobyKDl90LTxCzYx6BaWGGvImLH2fV+enIodnNLzJNSGuYkMjVtnHea1jKqaYyINu8291J4aEhqpn7jW0xoDN5J/O28jHLGQk0u584KbEBDH2BDLz2VmbrN+ihNIBLBo+Ia0+iFZRghJ3iqDHnuQXMA3cfeaL7ml1duvMyd5vG1rTwU67pXOwHrAHTg4iw5bNw4AgphiWR2jqxPf0ZnE72tAyXVVeHMBaUCawhgCz9mmLy6cVK0sFUzANQhuigS6Ab5284p1Ug/8SjEhW3SNAQt7P8jM4TmBdUsEY03aUDxzm5ojM9/exhpiYAyzlWaxXS9cti3rAlEHCM5TbTJ/b2ou5HwyZw7CxRqgYET/EqSOEphzdXBmuG86mSGBK1LwWt94zSgJyG40igASGRVd2EkrXTz4vOYClN5M17gzmTJJ3UPLUxW2lSKLYj2MO3pi1vZRn/nv3IoeplxyZHsltS45g2t3+dW5ROooIPXyx30boL3f7tHY9C4LzFPAm+iCkrW683+IeHFEKBQR8r8oROHAzrl+yT7W82w7RwNQWryVh1SyfU6ADkETwIx7/eoS/p6yxA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(18002099003)(22082099003)(6133799003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ig/waVh7ybPij04Kh32D7C9Q0iLmmPwwQE0dPnje70k9tKXW1E3rTXs6PvzyEXU2o9iT3n83CvaWoedNgm39P0sm6XCRWOM7IxZICgQLJetoFLPT2dm5Yhukkt0sUB56RpjsT+p7VXw83kiwfa5sYvW2GwURXCiwnGHsB/nxKJ9F9DBfSt1L82+GYB2peg8j7gcDMkYrd6ZBTPI5ou+D0qHD0cSSx80LoOQue0Z6tO3iAMmUi/80LRVUvOkxqGFiByl8/gi3hx82wIVXw6JTrCZW4EuKx0f0dndyAUkF/TTNKGW8FKcbEweWSur5YL9VS5jua+UqLZHFxQRvR9tV3s5eZMW/KYrKXfy7OHaOw4cxrX+nS+oqeMOTwrt6+w28Y3Ygy4bjuAhIlHs05f8kqg+Gyn0e+2e2r9QByDYsfjJ+x30kzgvPtaY9RP5YGkYP X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 14:00:53.6924 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0da0e0e-31e4-4a30-16f3-08dee0e72779 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7868 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_DATA_SPACE macro to a method of the type class. This is a refactoring. --- gdb/avr-tdep.c | 2 +- gdb/c-typeprint.c | 2 +- gdb/gdbtypes.c | 6 ++---- gdb/gdbtypes.h | 9 ++++++--- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 26b786c68b7..682b7e8586d 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -361,7 +361,7 @@ avr_integer_to_address (struct gdbarch *gdbarch, { ULONGEST addr = unpack_long (type, buf); - if (TYPE_DATA_SPACE (type)) + if (type->is_data_space ()) return avr_make_saddr (addr); else return avr_make_iaddr (addr); diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index 8bfb65ea13f..d45f5f6ab6d 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -487,7 +487,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream, if (type->is_code_space ()) address_space_id = "code"; - else if (TYPE_DATA_SPACE (type)) + else if (type->is_data_space ()) address_space_id = "data"; else { diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index db643bf89ea..bdac30204d0 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -5027,10 +5027,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_puts (" TYPE_VOLATILE"); if (type->is_code_space ()) gdb_puts (" TYPE_CODE_SPACE"); - if (TYPE_DATA_SPACE (type)) - { - gdb_puts (" TYPE_DATA_SPACE"); - } + if (type->is_data_space ()) + gdb_puts (" TYPE_DATA_SPACE"); if (TYPE_ADDRESS_CLASS (type) != 0) { gdb_printf (" TYPE_ADDRESS_CLASS(%u)", TYPE_ADDRESS_CLASS (type)); diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index a4bda900ae6..a12acb72967 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -186,9 +186,6 @@ struct type_instance_flags (((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \ || ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr)) -#define TYPE_DATA_SPACE(t) \ - (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_DATA) - #define TYPE_ADDRESS_CLASS(t) \ (((t)->instance_flags ()).address_class) @@ -1216,6 +1213,12 @@ struct type return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_CODE; } + /* Return if this type is in the data space. */ + bool is_data_space () + { + return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_DATA; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { -- 2.34.1