From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ect2Nh3wVGoyPAYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 10:03:09 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=aQFcCyeD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DB0BF1E033; Mon, 13 Jul 2026 10:03:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 652AB1E033 for ; Mon, 13 Jul 2026 10:03:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F1CE4BA23CC for ; Mon, 13 Jul 2026 14:03:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F1CE4BA23CC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=aQFcCyeD Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazlp170110009.outbound.protection.outlook.com [IPv6:2a01:111:f403:c111::9]) by sourceware.org (Postfix) with ESMTPS id DCAE34BA2E27 for ; Mon, 13 Jul 2026 14:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCAE34BA2E27 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCAE34BA2E27 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c111::9 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951260; cv=pass; b=QOJk+/z/YbSFMrYPv7hDmw0wsZ3YamqVN/HLgFKPzSiHdWCxs6n03i5dnkvRZlKgbgXftO36j9DcHMHopZoNGNDPIb9ylA7E6x0iEjhdQhRkw1ALC6b/VpQ51a1fti/cM+/25aFmUq3WafscVNYlzfJUojAsTtErBJVvfXks3g8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951260; c=relaxed/simple; bh=VGWUYieFfJ27blx1VeLT/RVa+b/OvqTclzlJPWGNUuk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Tg0rRixmxe/VO9C4cBQeOlEOdXIOlVkkp4VPCnFpZnrkQVTua0iEKWUUVHOB2a66frfFz0yUFLgLCpxCXuzuXYQ957IF42ma6Ya7iclX4SkrDt+VHocmAR43Vk+jUsXs0kaPx2tYvkCaujxQMkn4Ajmaq3iAJ1T2mM5jvk0j+KY= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=aQFcCyeD DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCAE34BA2E27 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g+48jyCHLERAV6HQgGfkmqT5vxKPo6fxLm/+FrPp0oTprW10DKCy8aX2GfV2iLofe49LHOAi8tTepS2umwueusrj/QJwwwToeNSXgoA2b9A2/Rhlnzvm49vQk5WA4lnCHPjBqHCzMnUuG+yH73wBWNWOBCyFfwJADyFplfAwclgyDFFrs+RjYzm2jCW/uZixQQOF5WET7Q10PTH1KzjpdsVfSnRQPZ7yutpRD/6mg9FbqmbvOQvx2JQHdEIFWjivEBesNRnJohZB+cYqgr21+vZ6Re4cNm1dg7i9m4nnF+F+0nqBIT/gOb6d6x1FWJDigJbGptLihVckW0l7jnNMAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SxLYvvqMl1yA9dvjve+19oPcv/4ddf7gBPZkAHtrjDw=; b=ohLpNuY9/KTyHvRoYHL4oyJNYE9n+cntqNjRtjrBhHSorMIGhe+sGR8zgtUSGo86WGsmtTrl9oO3+IhauFAddKxZg/QK7I4Y5nqex51A0TiBPcVaGFATohi91i88qXPC/qMjOYd+xpiwlNlQX+hh89pDaHv59SVCyZimiM/j3ixVIXhdIDlPcblANXVq3xYwbHKTzsMCii4jhCzbQgmu3vTA2xgggsWZlNzRGFSndMifwP93cbJ8UJIW+HiGOjfS1TzD0ls1HfHcZM+js5v7b2BpEC6QU4lIcoENzDW6i/s0oB4Kw1OWrJAndwdaRLQ2ilpYTxRuZljZY1RiO8mobQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SxLYvvqMl1yA9dvjve+19oPcv/4ddf7gBPZkAHtrjDw=; b=aQFcCyeDTNByrQmP9M4dLtIqsSKtwlvx7w40cNOe3ID/OKh+W+qNdmQ9UqHHsiPs+/lD143epo2nTGEmf40TzHiNKi2gVYscwO5kjvbjBrhoRwOjW/BwNlJxsTiqEjZ3eC3psHx18WhwO7xT5oaf1RJ9r+pxFpcs7xKXtFVdpyY= Received: from CH0P221CA0022.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:11c::22) by DS0PR12MB6631.namprd12.prod.outlook.com (2603:10b6:8:d1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.23; Mon, 13 Jul 2026 14:00:53 +0000 Received: from CH1PEPF0000AD7C.namprd04.prod.outlook.com (2603:10b6:610:11c:cafe::88) by CH0P221CA0022.outlook.office365.com (2603:10b6:610:11c::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 14:00:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000AD7C.mail.protection.outlook.com (10.167.244.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 14:00:53 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 13 Jul 2026 09:00:42 -0500 From: Tankut Baris Aktemur To: Subject: [PATCH 11/16] gdb: convert TYPE_CODE_SPACE macro to type::is_code_space Date: Mon, 13 Jul 2026 09:00:10 -0500 Message-ID: <20260713-users-aktemur-type-instance-flags-v1-11-779cad0c85ec@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7C:EE_|DS0PR12MB6631:EE_ X-MS-Office365-Filtering-Correlation-Id: 05a82a6c-e574-4db8-f103-08dee0e7275c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|23010399003|1800799024|36860700016|56012099006|11063799006|6133799003|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Pzks9LtiBKq5A8UHsJh3YvdQmqITVBziGSp1JqaFOXDAw+Ga1Ebv25uKTKqjHWq2ElDs+oxVyrKI7DZnR+j3CoCNfr8H/iu8skfxahb8/9JFemaBvih5EOBokHkOeRahmWd80HGR/H3J3crpCPobDKUj2QIScA2YdIQKDbffZG4HjMXIUPv8a0XWZSpFyF9sjfC6NyDVkg35L1p2d3Lmwax+7OmUVWBY9zl5+NIc+tFc6CAfVEQr9M+hY0j0TnLBn0aFLGlyACU6lQT4ZE29t032suWC+p+jBsfZzf4+tmRNwPdcZmPqc4vqIV0CSHG2cj8XDdlYfbc2hDa+etgo/d+79bM/hjclV5XD6oYvZtE7jIaS8YeSeYBFmh/rum3vfsDGmM8NS5Cfi4JKTL7vxEjLkQ/Ha4Bn4SksDZrITUp25pmlLSg01x2HLz3z2XpPOg1EnFMezj9A0eHt75yaRAj0gkgc8tcFV+eNld0qKXZ4im8jzvbZFr/OcIY538bJ7c3LA1qjyzMuLnUctu+S0qO3wJOHolA+reUrneS9D4m7GzbeOSbdxKMvYib8c2mXvjgfOT3f4Ktyi29J1RFwtC0H8vVZI7IkvYE8v8XEvAhgmNzEXV31WZs5KVB6OYiA+xcd9u6GNx3oArwXTYa3/k2C5/7fOXV0yQuimfvm7+h308gnWovmbiQmMioPTNVma1NVgWoIpyOQhxhVpP613Q== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(23010399003)(1800799024)(36860700016)(56012099006)(11063799006)(6133799003)(3023799007)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wKZYB/GLNNUQZQY1Hov+njLxdDrZBeTvq7/Ad36IDRNHrMQllzQyQnLJPfHaKlU6AB9rl+0c9rTVN1KKyyipsVk2aklkXk/u7kfVvCw5AQgKWpVFzJ/GXQplibi70cbMGCT34vfMejYIQCSisvrjRMQ1OiBvBvy2N6eXbqnaiXa6S2EV9XYr5IcGWFSPdUuFUFOPFgKCjSSjylHYoNG/FuN1v4F5qq9yQbzeNZ3Xs971rnRwLwY1PxKxTDgUKVxXMt+Qh45qrC9ZhL++1/eio/vA58q+Ma4KUppOgRIeVP70aLWytXrCpJZz9sQAIYZX22R6LDWoM9FftDnDpjRjJXq7iatcJ6vKvlJMLhGFDW5Sm5iXJfymCr9pSHsPEy5w2Lnowgnlg8ChHicAVjqdGq7Zzsl/xPxqp+50DHRafij9JJd9Kd2HKka5KMSa3qA/ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 14:00:53.5122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05a82a6c-e574-4db8-f103-08dee0e7275c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6631 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Convert the TYPE_CODE_SPACE macro to a method of the type class. This is a refactoring. --- gdb/avr-tdep.c | 2 +- gdb/c-typeprint.c | 2 +- gdb/gdbtypes.c | 6 ++---- gdb/gdbtypes.h | 9 ++++++--- gdb/iq2000-tdep.c | 2 +- gdb/rl78-tdep.c | 2 +- 6 files changed, 12 insertions(+), 11 deletions(-) diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c index 2191ada4c2e..26b786c68b7 100644 --- a/gdb/avr-tdep.c +++ b/gdb/avr-tdep.c @@ -345,7 +345,7 @@ avr_pointer_to_address (struct gdbarch *gdbarch, /* Is it a code address? */ else if (type->target_type ()->code () == TYPE_CODE_FUNC || type->target_type ()->code () == TYPE_CODE_METHOD - || TYPE_CODE_SPACE (type->target_type ())) + || type->target_type ()->is_code_space ()) { /* A code pointer is word (16 bits) addressed so we shift it up by 1 bit to convert it to an address. */ diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c index 8464dfdb240..8bfb65ea13f 100644 --- a/gdb/c-typeprint.c +++ b/gdb/c-typeprint.c @@ -485,7 +485,7 @@ c_type_print_modifier (struct type *type, struct ui_file *stream, address_space_id = nullptr; - if (TYPE_CODE_SPACE (type)) + if (type->is_code_space ()) address_space_id = "code"; else if (TYPE_DATA_SPACE (type)) address_space_id = "data"; diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 3bb1a2607b1..db643bf89ea 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -5025,10 +5025,8 @@ recursive_dump_type (struct type *type, int spaces) gdb_puts (" TYPE_CONST"); if (type->is_volatile ()) gdb_puts (" TYPE_VOLATILE"); - if (TYPE_CODE_SPACE (type)) - { - gdb_puts (" TYPE_CODE_SPACE"); - } + if (type->is_code_space ()) + gdb_puts (" TYPE_CODE_SPACE"); if (TYPE_DATA_SPACE (type)) { gdb_puts (" TYPE_DATA_SPACE"); diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index d05faf71acd..a4bda900ae6 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -186,9 +186,6 @@ struct type_instance_flags (((t)->dyn_prop (DYN_PROP_BYTE_SIZE) != nullptr) \ || ((t)->dyn_prop (DYN_PROP_BIT_SIZE) != nullptr)) -#define TYPE_CODE_SPACE(t) \ - (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_CODE) - #define TYPE_DATA_SPACE(t) \ (((t)->instance_flags ()).harvard_aspace == HARVARD_ASPACE_DATA) @@ -1213,6 +1210,12 @@ struct type return this->m_instance_flags.is_volatile; } + /* Return if this type is in the code space. */ + bool is_code_space () + { + return this->m_instance_flags.harvard_aspace == HARVARD_ASPACE_CODE; + } + /* Get the bounds bounds of this type. The type must be a range type. */ range_bounds *bounds () const { diff --git a/gdb/iq2000-tdep.c b/gdb/iq2000-tdep.c index 32e3750aca4..783e1720a02 100644 --- a/gdb/iq2000-tdep.c +++ b/gdb/iq2000-tdep.c @@ -95,7 +95,7 @@ iq2000_pointer_to_address (struct gdbarch *gdbarch, if (target == TYPE_CODE_FUNC || target == TYPE_CODE_METHOD - || TYPE_CODE_SPACE (type->target_type ())) + || type->target_type ()->is_code_space ()) addr = insn_addr_from_ptr (addr); return addr; diff --git a/gdb/rl78-tdep.c b/gdb/rl78-tdep.c index 0de2fceb795..4204ce5c8cb 100644 --- a/gdb/rl78-tdep.c +++ b/gdb/rl78-tdep.c @@ -1052,7 +1052,7 @@ rl78_pointer_to_address (struct gdbarch *gdbarch, /* Is it a code address? */ if (type->target_type ()->code () == TYPE_CODE_FUNC || type->target_type ()->code () == TYPE_CODE_METHOD - || TYPE_CODE_SPACE (type->target_type ()) + || type->target_type ()->is_code_space () || type->length () == 4) return rl78_make_instruction_address (addr); else -- 2.34.1