From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ER63AQXwVGoyPAYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 10:02:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nukCTzst; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 02B831E09B; Mon, 13 Jul 2026 10:02:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D52E1E033 for ; Mon, 13 Jul 2026 10:02:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E6924BA2E30 for ; Mon, 13 Jul 2026 14:02:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E6924BA2E30 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nukCTzst Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010049.outbound.protection.outlook.com [52.101.46.49]) by sourceware.org (Postfix) with ESMTPS id 83F474BA2E0C for ; Mon, 13 Jul 2026 14:00:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83F474BA2E0C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83F474BA2E0C Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.46.49 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951252; cv=pass; b=vx3Faf6e9qFHWDO0WZsKBJUdAnsYAOYKmYUlzwA8/07dD68UqwxK+Maop+NMhlG0ZbtE5Mzk9J/l1DQXFbuj/DozzeooCs8H2R82EjpCkIHYjdpK5oO/1gx9YO/lUzenB6p12HlnTOolj5g9j7DfNMINah5r/Le+pkP7R1livLg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783951252; c=relaxed/simple; bh=4vnYgwTLoF66eAIPZVyn06bxrIaHxzIB+myLQ2UzVcw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qIAJGza1YZ/96wR7Yd+bRAJo1TYdTToo9a4HIrTPtpnpdELOixSwUzt6VVzJFDtWEe/hjMU45M4lRrUeukCh5Fvw54EFxI8m7j7DyRY4idg9lS8RgH60MUcgn6gf2ZuY3f9Qg1+ZCThp3IZU8hTJJ/gdyZGZyoWz5PhVvGYo+J4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nukCTzst DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83F474BA2E0C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ymAd46zkbbafRtyE9ZgepYXoyjdqFDHyJvVIfXzPSvBKktzASaip3fXTWtkEpfMiHu9tG/u6wtF0taDk4NT10ZbTud58apFI4d9zJn1jxuclkszAnQk/81PTnT7aB50iPXnCrzg9rzVaHqKITTHabr85RZPZAh5drq8SWIT8THOKlQDKs7bdXyBk6G6e6frzTTC828/4xboW5W2VKpDyBhuZBuTE9G3Jfb8x8e8leCN/jEpW8b41RzxsjIyRx8Pt3kRxNMsuRwrThAu8RNkpwschERVvbMpm06LTII7kwmMbo/9VjMTvkvuvu/WVT0oYnVjFTE0EwMPJqhrHPt6amQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+lKbMZedb2a5nHQzk1J60UvrFA7MszFT/eLEmpiQUvk=; b=tNnK8sep5bNSQWm4Lu4PTWwbw98EUImBIQkzhibSJEVjfD0ZP9TfebLSghFUbchvNu+eq8aQ3KeYHTaYm5HMVOlUAHAo9DnHbHbcDxiPxKD3sqFNszC9k+JTRArcQbsGMOcXD+Mut4nTp62d+01lDqAaXQguKo55o2cIs7G/15KKJlMuSnmt+GZqHtLIhxTCA5007h26D3E+xgtpSM+WrKtpTkk3XeZSsKzPC2JMsd8jFPOMCmvJCpcLK6PLxWrUI9VAeGJez22R9aDgZDLh5TILzueMMobk7M7SeUxpMGV7d76LR1yKO42m2oZtZdfRAY3pGA8jWcvOozIQPe8tAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lKbMZedb2a5nHQzk1J60UvrFA7MszFT/eLEmpiQUvk=; b=nukCTzstflIqNAr8bfGeOqBEkklulWAOxiRdvaWEtl9queVkEbA49UGtXV3VLi/G4g8Qs8leDRoPNaxXgDnLdhlFkaH/2hYbiM5CQJvVOwy+frSK9Wo8dZujLSARKGuc6ezccR7gdLJnHqdFe5ahVkgSxbgl7C7Gu4ua0MwVxEo= Received: from CH0P221CA0016.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:11c::18) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 14:00:46 +0000 Received: from CH1PEPF0000AD7C.namprd04.prod.outlook.com (2603:10b6:610:11c:cafe::8) by CH0P221CA0016.outlook.office365.com (2603:10b6:610:11c::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 14:00:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000AD7C.mail.protection.outlook.com (10.167.244.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 14:00:44 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 13 Jul 2026 09:00:39 -0500 From: Tankut Baris Aktemur To: Subject: [PATCH 01/16] gdb: use type instance macros to query const, volatile, restrict Date: Mon, 13 Jul 2026 09:00:00 -0500 Message-ID: <20260713-users-aktemur-type-instance-flags-v1-1-779cad0c85ec@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7C:EE_|PH7PR12MB8426:EE_ X-MS-Office365-Filtering-Correlation-Id: cf96240b-2947-40c2-2e51-08dee0e7220e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|23010399003|376014|36860700016|1800799024|18002099003|22082099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: UTHYELwtswr7/XFQJpIO7yv2+QjLp4ld2byO3qe3mwt+Ojg/gD3IvY7Khcc1iWeS0AMvjfVFHCw6LjeplsldaTTaEE5ULoZLkJvXQEO7X2haw4tuC6LZKGlISiFQd8D1e1XXSkRisQBuOYv2+Zdn43nxti7wabxYV9LbryG5raikfZHPc29aAz65SLjBIVfNcA3DcAiqftc1GXEZI+xBHSf1pgrV9OYTAlVJTHm/ZcK6vuv1Io0fqTMOQ4sw7fSY+RmcfznwTmHyhw+oxpaDlNBzgKxol1gkM4Shoa52yby6+iIinG0Jb8rDcoURQhmsF4F831QbEGt48yKRfJQYihKmU8O8VP0IUP/grnb5fDlz2d+TgoTDSuV97WBD+bCrp3CakZ5/EprM0DvAZmDm+fpdoW8eR/EHQeyqQgg9TwidCV/pQASfttqFm9NVOWYxKCWo95lnsKvPOyUer3zsSt7FwtAgHx4ZQ67UiGcfzWlaK/SKPnbSymzkvOuNshck4fiLrXCxD81RGw105zuwJrs3NZLwUygUvrSWc2ik4ElwgSe3Yc+BAyI5dL5Gb2S7jIHUEzfN4OWVie5J3PslTGt+LR7VoLoCAcyVMbocFak7pLWDCbcJAPHPthfPFlYHQjtH73p5htMuudBbohAL963/9DyvoCQ+PNFmtXZ4Kw5qdq+GCa+9fVz8rBJq56/YjzLHgfv/OzHNUhgeTWnTDA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(23010399003)(376014)(36860700016)(1800799024)(18002099003)(22082099003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /XnwO++4qyRdeGbt/uW0UYUBGrul20R1ixsme1AaUnWmZXtvIs54x+JJj652U8ymMMi2vtXoEt4is15DgYqmsFzbUWBHF4oXXiuhQiQtraR8cb3HqNXy5g+YT55TjwNqvTRQo64Hwb5mJqEpECoZ4T3FHXh+Ov1/V0ZKuLH0ixYpjEScMOUFLfhYhRxD31eYLVtlHEyabC1DlOvRBsPgqvhhizvnyC2mrsqVyej70AoR7RFOFzVSI2fwxAchlpNYOygs4gvADJc3ox21N1l1JcK4lh4G+n0qjCq9NgFTfdnuX+ecnnSTxzMddGsR+Y5FyCt8g0yaUf2h3uGPsNoel7Dh/3fZGXLTQgyD/ZTDYSZ1EDhBc60QLIdSxKNBDQTwuY3ZyoJcHaNfOBJ2U/jSUCD478HB5lqM/PvX8baslkx/PyHFa9m5++WTGWX1PrFf X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 14:00:44.6072 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf96240b-2947-40c2-2e51-08dee0e7220e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In two cases in compile/compile-c-types.c and compile/compile-cplus-types.c, we query if a type is const, volatile, or restrict using bitmasks. For such read-only queries, there are macros. Use them for code uniformity. The new code may be slightly less optimal, but I don't think this would matter in practice. This is a code cleanup step in a series. --- gdb/compile/compile-c-types.c | 4 +--- gdb/compile/compile-cplus-types.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/gdb/compile/compile-c-types.c b/gdb/compile/compile-c-types.c index be79b582081..af9dea730eb 100644 --- a/gdb/compile/compile-c-types.c +++ b/gdb/compile/compile-c-types.c @@ -278,9 +278,7 @@ convert_type_basic (compile_c_instance *context, struct type *type) { /* If we are converting a qualified type, first convert the unqualified type and then apply the qualifiers. */ - if ((type->instance_flags () & (TYPE_INSTANCE_FLAG_CONST - | TYPE_INSTANCE_FLAG_VOLATILE - | TYPE_INSTANCE_FLAG_RESTRICT)) != 0) + if (TYPE_CONST (type) || TYPE_VOLATILE (type) || TYPE_RESTRICT (type)) return convert_qualified (context, type); switch (type->code ()) diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c index 031775c3679..ff25fc62c8b 100644 --- a/gdb/compile/compile-cplus-types.c +++ b/gdb/compile/compile-cplus-types.c @@ -1126,9 +1126,7 @@ convert_type_cplus_basic (compile_cplus_instance *instance, { /* If we are converting a qualified type, first convert the unqualified type and then apply the qualifiers. */ - if ((type->instance_flags () & (TYPE_INSTANCE_FLAG_CONST - | TYPE_INSTANCE_FLAG_VOLATILE - | TYPE_INSTANCE_FLAG_RESTRICT)) != 0) + if (TYPE_CONST (type) || TYPE_VOLATILE (type) || TYPE_RESTRICT (type)) return compile_cplus_convert_qualified (instance, type); switch (type->code ()) -- 2.34.1