From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EbswFJNiUWo2KgIAWB0awg (envelope-from ) for ; Fri, 10 Jul 2026 17:22:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PgaruHrq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 454531E070; Fri, 10 Jul 2026 17:22:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 937D21E070 for ; Fri, 10 Jul 2026 17:22:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E5374BA23C3 for ; Fri, 10 Jul 2026 21:22:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E5374BA23C3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PgaruHrq Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D901D4BA2E10 for ; Fri, 10 Jul 2026 21:21:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D901D4BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D901D4BA2E10 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783718520; cv=none; b=otQXN0chlUDHmu6urbI7xgKv/fQ5/aC+ZaROg3Tn2Fo9QD/URUccMKMhO8606DPLspV80hp8gWQr9g9AQWYRCrryZOkreH2W0ajlCSzzTA3g8kGlco2qrfnWTwqer/+6UATryeDhQu4bx3XViCQ/Cq3TKlxdy9vcc0CpooN8YMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783718520; c=relaxed/simple; bh=w23Ew6yLVVGv+porIu0iUIjerDQfz6uPX/sTbd1FAmo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=GQittkdxL1uXDPkRXPMcMTgnXRJbp2oSN4okjWkcBFHnXskoFBPHFMzqyiLITAjy2fhnlSSQUKPOVUEacgO90e5O0qy1Z78r1wrEvaAruFUwc0P/s3rVmp47+pOut/BpFfWaMfmIQ/t/wVo5eVN0U35JXDEbEaloTiJ5gaO1LhQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PgaruHrq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D901D4BA2E10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783718519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJwzIS9E3yQUn7xYXjHg2EMa4/vfUKwfeCinPiTm6Xk=; b=PgaruHrqDOEHx3RxmZSBWkO4gnpw4a53aXjsW3vJteAH0vlgsWen0Qxj5/VuIUbVIIA41K K6YzaRWfpNsylGTNjhQUwEcJ4SwCU2jBudY/beZsIBlE4fjOnFk2v8Iw9anm5OE4PpaX/t jvL0cHCy/fdpsW1gVmMeegLfVoaTtXE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-CXMLS78VP-mLnF1Q89quhA-1; Fri, 10 Jul 2026 17:21:56 -0400 X-MC-Unique: CXMLS78VP-mLnF1Q89quhA-1 X-Mimecast-MFC-AGG-ID: CXMLS78VP-mLnF1Q89quhA_1783718515 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1BB471956068; Fri, 10 Jul 2026 21:21:55 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.88.58]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 95627195608E; Fri, 10 Jul 2026 21:21:52 +0000 (UTC) Date: Fri, 10 Jul 2026 14:21:50 -0700 From: Kevin Buettner To: Matthieu Longo Cc: gdb-patches@sourceware.org, Luis Machado , Luis Machado , Andrew Burgess , "Yury Khrustalev" , Pedro Alves , "Tom Tromey" Subject: Re: [PATCH v1 04/10] gdb support: add gdb::replace algorithm for iterators and ranges Message-ID: <20260710142150.64b2a9aa@f44-mesa-1> In-Reply-To: <20260707154900.94542-5-matthieu.longo@arm.com> References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-5-matthieu.longo@arm.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xoqGYfa066L3wY4ykZYg-QR082oER9_lcqiFc6P7uuQ_1783718515 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Matthieu, I am not a C++ expert, but I'd like to understand this better... On Tue, 7 Jul 2026 16:48:54 +0100 Matthieu Longo wrote: > Add a gdb::replace helper that mirrors the behavior of std::replace > for iterator pairs, together with a convenience overload accepting a > range. > > This provides a C++17-compatible replacement for the C++20 std::replace/ > std::ranges::replace algorithms, allowing callers to use a consistent > interface until GDB transitions to C++20. The helpers should be removed > once the C++ standard library implementations become available. > --- > gdbsupport/array-view.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/gdbsupport/array-view.h b/gdbsupport/array-view.h > index 8431d7f5add..61119d7a8e2 100644 > --- a/gdbsupport/array-view.h > +++ b/gdbsupport/array-view.h > @@ -225,6 +225,32 @@ void copy (gdb::array_view src, gdb::array_view dest) > std::copy_backward (src.begin (), src.end (), dest.end ()); > } > > +/* Replace all occurrences of a value in the provided range. > + > + Note: this helper is a reimplementation of std::replace, only available > + from C++20 onwards, and consequently, should be removed once we switch > + to C++20. */ > + > +template > +void replace (ForwardIt first, ForwardIt last, > + const T &old_value, const T &new_value) > +{ > + for (auto it = first; it != last; ++it) > + { > + if (*it == old_value) > + *it = new_value; > + } > +} How does this differ from pre-C++20 std::replace? Kevin