From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Eb+jLb4gTWocLysAWB0awg (envelope-from ) for ; Tue, 07 Jul 2026 11:52:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=balQc3tf; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=balQc3tf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B4B5B1E024; Tue, 07 Jul 2026 11:52:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A62C81E024 for ; Tue, 07 Jul 2026 11:52:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8718B4BA23E1 for ; Tue, 7 Jul 2026 15:52:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8718B4BA23E1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=balQc3tf; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=balQc3tf Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010068.outbound.protection.outlook.com [52.101.84.68]) by sourceware.org (Postfix) with ESMTPS id C1D494BA23FE for ; Tue, 7 Jul 2026 15:51:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1D494BA23FE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1D494BA23FE Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.84.68 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1783439505; cv=pass; b=OZeXnmv3b+OSw6YTI+59tG9nqCUBJQyMk8KTs4UrO0mLNVPEHnQGgr6fJtabQOG5xgkqCv2li0XD1p1HEJpDrGZdetdipITTGRb/uKz4LKRKkMg6Vo6ZVeI3ira2Iv7iIS5UElyeUfSNU/odgO8iTtNDEF87/uS60LoQ3ktJkyo= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1783439505; c=relaxed/simple; bh=dK2luyBorQWlJypxihwj2QVplfnk1AZQ9O8W1uSAHU4=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=bNi9fDzVu1dWNSIwjq1/pPKvJYR+l1OFg4U1UH2dHpGeBWMX+luJbLKpYpF8QIy3rnGzKpSAhk1MJDWFj2QfAaJz29RGSHbJLOzkiskCvgUz/VEIjkFqlG65Q1kr9pvBq2X0F4TDgly5+xS+U0iSlEwQAjO/u3ptwRW/d9GoLHU= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=balQc3tf; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=balQc3tf DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1D494BA23FE ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=uKCrZpfsjmO9qOioKbKCfzKVHM8CZMSB79Q07Z+AoWKbtvKGkNyiUHC0taCWEXR4+9GJI+TkKxOUoMqMbcMMCEAl4fGRowqK/FbDueXsZgJm2r6IwcGiAQTREPojah/5gSpROztihu/951XaMlp4cWWiCc0t8Gb08qGBylWrgqh0lpVBfWmixaOeSawcJzhWdRz1CdEvy38mqduP6N8onqI2kcvEWYXGQem3/Fx/9alq5Fm4A0l3FMyfGHDARpXphi2GeMBkIzriWF7zR9y/SBZYsbm33qXxR/OhZ4aDgSZNtd+lwaQT+Je1exJGE4kY9dIAFPMCYrRScPHrXAsjaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8kqQvk4eKWfCZ695T4MXRtkym4MaEBTafXre21Q9+bE=; b=OXAK5ABqeHmxCDizKR1wjGIEtwMg/enRhQGfL01RpB0f7VkH8jU0MZYihkCedoqWqNE60BfuemqRKev3jAYQiMP9RpPkoAy6EQZilQWtp+/I5fEP9VBOdp6I6I8N4zlfVoMoX4m9R/RralzE9KNvmxr1xUVgjJ1OUD0kW/qSL9jk1rNvkKM7vB0kRRHn0/xWTtmpSyxRCj3Jnso577mjvede33hPQ5FW3pEEJzip3IDfsZSOWnmwX7v+7PWAQNY+raVz7GRmFTlGwZ0ORziREYBo9KD8BrF26v3qxN82lvWKIIfIVJvbjgPfxG+RLX13OhJKaOfNlAGfznYZAStQtA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8kqQvk4eKWfCZ695T4MXRtkym4MaEBTafXre21Q9+bE=; b=balQc3tf1i3LA5b2n70YJcpZQHBO6L5JykNrSdTCswuqjXOA2tbNtDLz3QB1VBJZ6Rid5MTHM3DIz9DipAYjc5AsqSLFL7rLOT68j0k2oro83WVxNm2f2tTlwCKvhcgmWQt5yis0PMK0rX+RJPKdIEi8MpJh3j6bhbR0bo+fne4= Received: from AS4P251CA0019.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::7) by AMDPR08MB11675.eurprd08.prod.outlook.com (2603:10a6:20b:739::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Tue, 7 Jul 2026 15:51:39 +0000 Received: from AM1PEPF000252DE.eurprd07.prod.outlook.com (2603:10a6:20b:5d3:cafe::9f) by AS4P251CA0019.outlook.office365.com (2603:10a6:20b:5d3::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.13 via Frontend Transport; Tue, 7 Jul 2026 15:51:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM1PEPF000252DE.mail.protection.outlook.com (10.167.16.56) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Tue, 7 Jul 2026 15:51:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZBxJwN1l6aRcK4yfu/55J0azTsmP0sao2yUoEN/AIPPKLlBf5EZIsWlGVesBYkvgPXYx+PqujAis0JBIsqTZEtyskd/tQathHt6nk96VfVkQYmQi1Ca+4zSl/ptbA58i7RNdkPRqv+T+qcXMYP/gDq3NpLCKfzf3LTYuH8kAASzKwhSdgIFt8E3kavCR66OaydL6DgJK3kkwldJyIsJ1XI2U6nsKUcD721gJD7NhTzghwuJfCcIvn7JVwdJpnJLpuIeCvv0lx9rcHuJ/3sRq/q+ipBKG9vVTxOrdlG61NoCmUMM/NormdGA/0WIu4G2R21lPA2Nn5uYmXuonEZTPhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8kqQvk4eKWfCZ695T4MXRtkym4MaEBTafXre21Q9+bE=; b=mwGh+4GKUHLRX2gYaW6iC5LZtt0eQz4zaC+zOcjsUTgn2QbhbJKNzJP7HGj8OLKZMhLeWVG1/DNV1zWp3qjx8c7yyiRyrljv9VP0u8up67o45KbgiG9CtuG0dSQdIlmF8F3bR0Ka8ae+BxEdpE3F43lW5UF/rA7lw4HS+4GBwr8Kq4qmDkV/ubnlBSBM31ECZ17lCb9eyr7BYJvFdJijSzfaOEze05ArP2YsX/Kmbj7dMZ42pzPVHa5CtNcau/vbn0ca+Ckp2kuaNPDHZgiY1dk8iPAZfHGA3dYdkVQdNqGD1z+c30seLEvYmovv89ape3q1ggzogtXq/AB/QO6i+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 172.205.89.229) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8kqQvk4eKWfCZ695T4MXRtkym4MaEBTafXre21Q9+bE=; b=balQc3tf1i3LA5b2n70YJcpZQHBO6L5JykNrSdTCswuqjXOA2tbNtDLz3QB1VBJZ6Rid5MTHM3DIz9DipAYjc5AsqSLFL7rLOT68j0k2oro83WVxNm2f2tTlwCKvhcgmWQt5yis0PMK0rX+RJPKdIEi8MpJh3j6bhbR0bo+fne4= Received: from AM9P193CA0016.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:21e::21) by PAWPR08MB10210.eurprd08.prod.outlook.com (2603:10a6:102:367::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Tue, 7 Jul 2026 15:50:34 +0000 Received: from AM1PEPF000252E1.eurprd07.prod.outlook.com (2603:10a6:20b:21e:cafe::9c) by AM9P193CA0016.outlook.office365.com (2603:10a6:20b:21e::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.8 via Frontend Transport; Tue, 7 Jul 2026 15:50:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 172.205.89.229) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 172.205.89.229 as permitted sender) receiver=protection.outlook.com; client-ip=172.205.89.229; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (172.205.89.229) by AM1PEPF000252E1.mail.protection.outlook.com (10.167.16.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Tue, 7 Jul 2026 15:50:32 +0000 Received: from AZ-NEU-EX04.Arm.com (10.240.25.138) by AZ-NEU-EX04.Arm.com (10.240.25.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 7 Jul 2026 15:50:32 +0000 Received: from PF4S4363.arm.com (10.57.40.47) by mail.arm.com (10.240.25.138) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 7 Jul 2026 15:50:31 +0000 From: Matthieu Longo To: CC: Luis Machado , Luis Machado , Andrew Burgess , "Yury Khrustalev" , Pedro Alves , "Tom Tromey" , Matthieu Longo Subject: [PATCH v1 08/10] gdb/linux-tdep: migrate parse_smaps_data to file_reader_t Date: Tue, 7 Jul 2026 16:48:58 +0100 Message-ID: <20260707154900.94542-9-matthieu.longo@arm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260707154900.94542-1-matthieu.longo@arm.com> References: <20260707154900.94542-1-matthieu.longo@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM1PEPF000252E1:EE_|PAWPR08MB10210:EE_|AM1PEPF000252DE:EE_|AMDPR08MB11675:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fcb55f0-c964-4402-daab-08dedc3fa1cd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|82310400026|36860700016|376014|1800799024|23010399003|56012099006|22082099003|18002099003|11063799006; X-Microsoft-Antispam-Message-Info-Original: VEGhq4ar8wN9FM8zk2h0OZ1eUSNUyrmfFkRVMdKp40iZ8mMa9mycjVzbY5wP9wLEfAYRf8x0q36V/u7+q0ZF7ECBYK2LdvyBq2zFalx/3W84QbuwjYiW7ri7aJT1Z7Q80BcQjfDaRK2hNjhGvqh5SAO0njPLI4gwWOxtibD2epWUEEglRc9RMuvu9UCEnBdScUsPnXLNkUB7/OsZphNlbdbWvz+Lx519eyJWrtNLFPAM57jILODYm8hGMzQ6V12Q8VqxcK7Nh9JUVqa8BN1LL/lkHqvF+HzJgqVoIDp8hr70mUaRuHPZ2q41OmEcpK5Z9+4l6GPUZFMBNWKR9ZSCvSV1L83/GlpeUTaxN/JwgtyBWK5LfEuZ7cP6BCXBbSoohLthpKYOxvB5nK4J2NTjEt4voHFWkB0uzq46U40vvXYuMcbmUHXJN+Io2wY6IV0d/IU2m6DrurLP6tpHh04VX1B/gOA4opxwBCaeq0xG6DIfHaFZA8VstiP1tcOvoFy7I63BborFnhwQIyfdLjjZWC9no0djljDsvW++MUkQ8t4EQEaQ4NNtSjvgPvSy3a6jiH49FgfwtAUT6Cy8jDzjf5rVHglZGD3K+l8yQ1rPT/xUOV6UxfPQhdtmn8ymH7zFEPXaRfLzM/8ldLAFfBEYfCKY8mSU1AK4URbzQrZf6Jr1wjtcSbi5BuyJD+Rkgw6t4OhK4bQdz2CXv60b2Z65FA== X-Forefront-Antispam-Report-Untrusted: CIP:172.205.89.229; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(36860700016)(376014)(1800799024)(23010399003)(56012099006)(22082099003)(18002099003)(11063799006); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: Ec+R2UuQzGmD6wEBwESTaMOF/YtVmrkOkwpyEkAkLVWPpSCDucBLFzgl81QN33FnezopHPJp6xN/4QqHdOAOKZfZrX14gz4+TP5IXMGKbTRRSdZL5BWqusp+V4JKN6ikz3ZE9B6z5ATpvPO85xtp5YCwt0rNnvKqGUi1HnOzKuawLV6MYFLIh4QSVWLkwaLoBI03feIn+Pi75kseHh0J7ljoGv4R8khDL3svGAFagkvDyyeAYUW2LyFlzuuAoFUFk+g6/Hi8RUlwvlPvmgEpu8xVw/2OeIp2eJqtBvdZhZe8PWtMFcOG9Kz6mrJze8MHoUy6LucQw4GMy0+jMchJcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10210 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DE.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cd630b0d-6ccc-408e-d9fb-08dedc3f7a8d X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700016|1800799024|14060799003|35042699022|23010399003|11063799006|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: hdS+eCymDJCs6OxpL376Cqlmw3MUPirIRakJC5RN4abzEoyBHDw6qVE13i3xrCeqol7B6twwfGGhowooa77uZLo6G/l319jbhC0MyNePkbBGiJ+E8l4rQYxB934Zjsjd51Cr93CCK2BEUMu1lyZcJBIaoOALPNVSMZNjimFvXU4sQ/8zF639N5GBcgZKf+bkkLuHWhfCOZegF9vPYgrroKwMOLCHYISJ6Me9FJlzg6KRjTelHXUGHvtTDBx6sirRQIUiHp1olRpZMdtFtbYXWcnU0AeNkdFkrswyA1lmAMQiXRVYfn3STqTTuwPKCL1QtRnmenJvRQit7q82B2LlpAtjAfLCrMhqfTZQ1aJ+QFX6jmwfQ45A+ARJKEwBBIZzMUR1Tg3l9hX7e3BjRKjhP3uMbDOThGBL2/YlWOwvFnn49GIYKRMHJjUDhSbZa3au739tyEG/An9ltTWN9npV2jy15AWD3EMesdBzRL9/gZGl5kr4OeaDufm9Rb0bPie9Qmem90Yd2QWsAnRqJ1q7Un+Bea6crivpleB3BpVSX8C8cU+nlYvWoMGllpGrHjdC/4R0wMPp8yNRwaOGLIZbbxXPWS4YvnM7Q4mZybbVM/W8JAFj6/YW3GAs+/Mt3WJgr2+w5v7L3K1l/VWcYrJN+ctHtAHy9nCPioIymsJQfT0A6G55A9vIxHRLftU1ph2tI5cQeqKSXeeMlvGUlCaHdA== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700016)(1800799024)(14060799003)(35042699022)(23010399003)(11063799006)(18002099003)(22082099003)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1jRjvIJavLwsGTyUAx0q6kF+WCTSx161QDlur5ILZbW6YZ8fK1Rcm1Y9qXhMiYuumHLsJ09UpVd4mBPljH2epGvxGosXgTC/EZVXp5cT4JDlryoVNl0agIvgFn1Dk+qcy6gIOEjIpLlLwB3SZUOYeOFILEkA2IWrM9BPLlseIUbc2iAsjRKQgZBh06oCuUGa6khToTpw4kHIAu5B7AAu0jM7rsahFjOuP6MkU3F4OSkJ5bGxVzcSCt1xhzKKVjTmazJn6gluylPeUkMmWFjEcQgh9kSnooFav39PbrhWy78f9ZFL0Fltr85ZoCJP/vt2aHSXJqFTrP8WSTbo0z6tptioWMQN2lFOU1KWKvNa1nnBH/JOA/DiDxQTP/cR9qzwhpMvxhtLMDV2RzhbuXzD6Cle5Zl89pqa/83PCXzgE1ZwRPSs+bDwCMKzVbKSzjT4 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 15:51:38.7930 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fcb55f0-c964-4402-daab-08dedc3fa1cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252DE.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMDPR08MB11675 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --- gdb/linux-tdep.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index f1cea3040f9..dbc69a5a7fc 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1530,18 +1530,17 @@ parse_smaps_key_value (const char *keyword, const char *line, /* Helper function to parse the contents of /proc//smaps into a data structure, for easy access. - DATA is the contents of the smaps file. The parsed contents are stored - into the SMAPS vector. */ + FREADER is a wrapper around the contents of the smaps file. + The parsed contents are stored into the SMAPS vector. */ static std::vector -parse_smaps_data (const char *data, - const std::string &maps_filename) +parse_smaps_data (const file_reader_t &freader) { char *line, *t; - gdb_assert (data != nullptr); + gdb_assert (freader); - line = strtok_r ((char *) data, "\n", &t); + line = strtok_r (freader.data (), "\n", &t); std::vector smaps; @@ -1597,8 +1596,8 @@ parse_smaps_data (const char *data, if (sscanf (line, "%64s", keyword) != 1) { - warning (_("Error parsing {s,}maps file '%s'"), - maps_filename.c_str ()); + warning (_("Error parsing keyword in {s,}maps file '%s'"), + freader.c_filepath ()); break; } @@ -1612,12 +1611,12 @@ parse_smaps_data (const char *data, decode_vmflags (line, &v); if (parse_smaps_key_value (keyword, line, "Rss:", - maps_filename, + freader.filepath (), &rss)) continue; if (parse_smaps_key_value (keyword, line, "Swap:", - maps_filename, + freader.filepath (), &swap)) continue; @@ -1628,8 +1627,9 @@ parse_smaps_data (const char *data, if (sscanf (line, "%*s%lu", &number) != 1) { - warning (_("Error parsing {s,}maps file '%s' number"), - maps_filename.c_str ()); + warning (_("Error parsing numeric value associated with " + "key '%s' in {s,}maps file '%s'"), + keyword, freader.c_filepath ()); break; } if (number > 0) @@ -1679,12 +1679,6 @@ parse_smaps_data (const char *data, return smaps; } -static std::vector -parse_smaps_data (const file_reader_t &freader) -{ - return parse_smaps_data (freader.data (), freader.filepath ()); -} - /* Helper that checks if an address is in a memory tag page for a live process. */ -- 2.55.0