From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id P+saC6/aS2r/ACoAWB0awg (envelope-from ) for ; Mon, 06 Jul 2026 12:41:19 -0400 Received: by simark.ca (Postfix, from userid 112) id 1B4CC1E024; Mon, 06 Jul 2026 12:41:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 70B791E024 for ; Mon, 06 Jul 2026 12:41:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D7D64BA23C8 for ; Mon, 6 Jul 2026 16:41:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D7D64BA23C8 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C906D4BA2E07 for ; Mon, 6 Jul 2026 16:40:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C906D4BA2E07 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C906D4BA2E07 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783356020; cv=none; b=VG2o67ZD5OUNMvSBk5DbsnvGsIbrkl+TdMGVmtqo252C4INHR1Qsmf3HNbVBJGdEpQkdOeeRL0q5ZfyeC1K1cbcnd7Bwkty8DHayVja7046v4BiKKhwSnN/iwZCkl3zxX6Dmhij4xngjD6ehwDLL2XO3y+cJ/uenu3sXHckAWH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783356020; c=relaxed/simple; bh=0TgtLfps3OtdpqnnzhGcjkIS9zwMr4TSJMwJqzs9A2s=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LvCYyzd4JR0SEjlaxiKP56cUKM3pSoJls519MzJJH1JPfY52ZG36Hyhp7Zn5vts4A76j+BE6e8tJCJwbQ2tdDgIHo3qSgkNtBhDjCc2yoKyHmdboVOhCtFegb8gUVRDHVgDR27DWTtJm6yHnVboblZVSviGQREYUj1I+tuTAZ+Q= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C906D4BA2E07 Received: by simark.ca (Postfix) id 08AAC1E024; Mon, 06 Jul 2026 12:40:14 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb/record-full: make record_full_arch_list_add take an rvalue ref Date: Mon, 6 Jul 2026 12:40:09 -0400 Message-ID: <20260706164012.507674-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org record_full_arch_list_add moves its `rec` argument, so it should take an rvalue ref to reflect that. Otherwise the fact that the object is moved from can be a "surprise" to the callers. Change-Id: Ibeb56b1523ad8aee077d3bc3cad1f00d6b47ea2f --- gdb/record-full.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/record-full.c b/gdb/record-full.c index 1392510a175c..aa451c05a5d9 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -735,7 +735,7 @@ record_full_log_release_first (void) /* Add a struct record_full_entry to record_full_arch_list. */ static void -record_full_arch_list_add (record_full_entry &rec) +record_full_arch_list_add (record_full_entry &&rec) { record_full_incomplete_instruction.effects.push_back (std::move (rec)); } @@ -758,7 +758,7 @@ record_full_arch_list_add_reg (struct regcache *regcache, int regnum) if (regnum == gdbarch_pc_regnum (regcache->arch ())) record_full_incomplete_instruction.pc = std::move (rec.reg ()); else - record_full_arch_list_add (rec); + record_full_arch_list_add (std::move (rec)); return 0; } @@ -784,7 +784,7 @@ record_full_arch_list_add_mem (CORE_ADDR addr, int len) rec.get_loc (), len)) return -1; - record_full_arch_list_add (rec); + record_full_arch_list_add (std::move (rec)); return 0; } @@ -2399,7 +2399,7 @@ record_full_entry::from_bfd (bfd *cbfd, asection *osec, int *bfd_offset) bfd_get_filename (cbfd))); break; } - record_full_arch_list_add (rec); + record_full_arch_list_add (std::move (rec)); } void base-commit: abcf25501f986df152581faeff08419c198a7ec3 -- 2.55.0