From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 54y6GGW/S2rQ5SkAWB0awg (envelope-from ) for ; Mon, 06 Jul 2026 10:44:53 -0400 Received: by simark.ca (Postfix, from userid 112) id 5356B1E098; Mon, 06 Jul 2026 10:44:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 617361E024 for ; Mon, 06 Jul 2026 10:44:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2D7B84BA2E0F for ; Mon, 6 Jul 2026 14:44:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D7B84BA2E0F Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1EE784BA2E2A for ; Mon, 6 Jul 2026 14:43:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1EE784BA2E2A Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1EE784BA2E2A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783348989; cv=none; b=eQE3i3y4rRDSHyZ/Oeena4DUwq+/Zirjl6/7jaQtGHqufukDTVI6mZufTJ6U9Sr2SnC7Hiq0ERazADnM+B4iXT9DoVb3Lc/14v/GX3vsZ1keb7GiIGJ5FfeA9peWGfo4dqY7n7YPU9kede9YVsKtlvh4cJP1lv45lCTPHQ49B70= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783348989; c=relaxed/simple; bh=oGTFkicJi1DCPNRW3x14L25L7U0yvxZZ/ojiFWsl8Wg=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=n4CBOGjV0FPn9tZF1UE4SUxqEG1vIm31imALvmEMI2/0yFU2YSWfYW7Bi34NmO6VgIfPcNz8A05EhtM6Kfugu5b3Xqz+RgUFbymeOBObyDGFA7JRDsuPbVdUcPutLp+1ZeVFF1kCZU+ZKn+18xzXDRus9E6VOnHm8HtiSUptHB0= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1EE784BA2E2A Received: by simark.ca (Postfix) id F19AD1E024; Mon, 06 Jul 2026 10:43:07 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb/record-full: fix some -Wpessimizing-move errors Date: Mon, 6 Jul 2026 10:43:03 -0400 Message-ID: <20260706144305.180512-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Compiling record-full.c with clang shows: /home/smarchi/src/binutils-gdb/gdb/record-full.c:2386:14: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] 2386 | rec.entry = std::move (record_full_reg_entry::from_bfd | ^ /home/smarchi/src/binutils-gdb/gdb/record-full.c:2386:14: note: remove std::move call here 2386 | rec.entry = std::move (record_full_reg_entry::from_bfd | ^~~~~~~~~~~ 2387 | (cbfd, osec, bfd_offset)); | ~ /home/smarchi/src/binutils-gdb/gdb/record-full.c:2393:14: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] 2393 | rec.entry = std::move (record_full_mem_entry::from_bfd | ^ /home/smarchi/src/binutils-gdb/gdb/record-full.c:2393:14: note: remove std::move call here 2393 | rec.entry = std::move (record_full_mem_entry::from_bfd | ^~~~~~~~~~~ 2394 | (cbfd, osec, bfd_offset)); | ~ It's indeed not recommended to std::move the return value of a function. Remove the std::moves. Change-Id: I80d947aa3d917fe3fcaaad0c3e329cb1de48a8ee --- gdb/record-full.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdb/record-full.c b/gdb/record-full.c index 695d9d1622cd..1392510a175c 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -2383,15 +2383,13 @@ record_full_entry::from_bfd (bfd *cbfd, asection *osec, int *bfd_offset) { case record_full_reg: /* reg */ { - rec.entry = std::move (record_full_reg_entry::from_bfd - (cbfd, osec, bfd_offset)); + rec.entry = record_full_reg_entry::from_bfd (cbfd, osec, bfd_offset); break; } case record_full_mem: /* mem */ { - rec.entry = std::move (record_full_mem_entry::from_bfd - (cbfd, osec, bfd_offset)); + rec.entry = record_full_mem_entry::from_bfd (cbfd, osec, bfd_offset); break; } base-commit: 748bc6a7febf874d84657f538c9d9e3b8153c6e7 -- 2.55.0