From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GWsNE8mDSWpIASgAWB0awg (envelope-from ) for ; Sat, 04 Jul 2026 18:06:01 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O9Qy/0Lp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3B1791E024; Sat, 04 Jul 2026 18:06:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 17EDB1E024 for ; Sat, 04 Jul 2026 18:05:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C314A4B9DB50 for ; Sat, 4 Jul 2026 22:05:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C314A4B9DB50 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O9Qy/0Lp Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 4A1B94BA7987 for ; Sat, 4 Jul 2026 22:05:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A1B94BA7987 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A1B94BA7987 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783202726; cv=none; b=LqzRHocpeQ5m/UrjBCSNz94b1h1WFbnYGV9loZP2ivkgTPZTPwc/wODz426VM4G/+GJRa9ciPi+R6UxC3Vqtrjgdp/R+OPyuxVB9sWcR4c781r2hllGmUODjiUIpHfBxx4nrLuasgdAvvmqGtJS48wJ3lHFVBCNqcBjEibcvnMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783202726; c=relaxed/simple; bh=ITTAvSsadVul+wdLGGTStPUneURTCe8gWIntLY/k5Ss=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=uUxJ2xWDfxhmsV82H45ku4gYZxX1aSNru3ZioLIIwZd4XfYtkbpIEz66RwGKbnrTbvguYJ2nd1EBx7AYNdiLlKw0pEioT9Ss/AqqAP84UwWGbwPpMM98Wm1gw47yGVBI+qS3FaAebm+VxVlB/9qq+OwNmIla91TsbrZkbyEsqZU= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O9Qy/0Lp reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A1B94BA7987 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id fnnfwA8iElPo5g8UHwX2t5; Sat, 04 Jul 2026 22:05:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id g8UFwdtt1ooyIg8UGwf2oN; Sat, 04 Jul 2026 22:05:24 +0000 X-Authority-Analysis: v=2.4 cv=AZ6xH2XG c=1 sm=1 tr=0 ts=6a4983a4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=ItBw4LHWJt0A:10 a=RvZCCkNEdiyUzWe8lpgA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4tSMNciV4XRNIlM2BCVU9XmiN2A72ky0WhT2qwrZv+4=; b=O9Qy/0LpJrJQmbpBFWqFBcM843 KgUSwYWbK7ScY061ljb9Y23jpwwbDIaS0EVAaiAv8ON1UBV7ejDvubuO9gt9z6Sd2x334tK8nGYiW VTbQAZ0/jbSfUNdDa9zSNzgFP; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:38412 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wg8UF-00000000OSH-3ABJ; Sat, 04 Jul 2026 16:05:23 -0600 From: Tom Tromey Date: Sat, 04 Jul 2026 16:05:22 -0600 Subject: [PATCH 8/9] Use std::forward in fortran_array_walker MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260704-print-opts-cleanup-v1-8-fb54a5112a8d@tromey.com> References: <20260704-print-opts-cleanup-v1-0-fb54a5112a8d@tromey.com> In-Reply-To: <20260704-print-opts-cleanup-v1-0-fb54a5112a8d@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wg8UF-00000000OSH-3ABJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net ([192.168.122.1]) [75.166.225.82]:38412 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBc0wLadpJk3tPb5izvxcob9L3T2o6FU8DWtuGxPODhzK82zpZfV7ZKmbKm2HUauzF2aCCzH0pk27Hqqx/4nNWoFI3KOkFAgSch/srQeDRzV40o1+VqH O3E6OhNfV+pdWqW2whuP6qtHtIgyPGDyaUWuYXmpmC+scHL17++ThQEWsq3XmAo4uQ2HbsupfrJ0Nf42deIe8FFhAXXx0KuKIOs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes fortran_array_walker to std::forward some arguments. This isn't needed in the current tree, but is needed to make the next patch work correctly. Sometime earlier this year I had a patch where I ended up removing the use of std::forward. After debugging this case, I tend to think that if a function uses variadic template parameters, then it should always use the "&&" and std::forward to pass them on, just because this is more future-proof -- one never knows when one might need this. --- gdb/f-array-walker.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/f-array-walker.h b/gdb/f-array-walker.h index 4392e54013b..e7deef8ac5a 100644 --- a/gdb/f-array-walker.h +++ b/gdb/f-array-walker.h @@ -195,10 +195,10 @@ class fortran_array_walker template parameter class IMPL. */ template fortran_array_walker (struct type *type, CORE_ADDR address, - Args... args) + Args&&... args) : m_type (type), m_address (address), - m_impl (type, address, args...), + m_impl (type, address, std::forward (args)...), m_ndimensions (calc_f77_array_dims (m_type)), m_nss (0) { /* Nothing. */ } -- 2.49.0