From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 6/9] Use 'const' with some value_print_options
Date: Sat, 04 Jul 2026 16:05:20 -0600 [thread overview]
Message-ID: <20260704-print-opts-cleanup-v1-6-fb54a5112a8d@tromey.com> (raw)
In-Reply-To: <20260704-print-opts-cleanup-v1-0-fb54a5112a8d@tromey.com>
I found one spot using value_print_options where 'const' would be
appropriate.
---
gdb/ada-varobj.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/ada-varobj.c b/gdb/ada-varobj.c
index 6d4cf166b87..623df0f01ed 100644
--- a/gdb/ada-varobj.c
+++ b/gdb/ada-varobj.c
@@ -807,7 +807,7 @@ ada_varobj_get_type_of_child (struct value *parent_value,
static std::string
ada_varobj_get_value_image (struct value *value,
- struct value_print_options *opts)
+ const value_print_options *opts)
{
string_file buffer;
@@ -826,7 +826,7 @@ ada_varobj_get_value_image (struct value *value,
static std::string
ada_varobj_get_value_of_array_variable (struct value *value,
struct type *type,
- struct value_print_options *opts)
+ const value_print_options *opts)
{
const int numchild = ada_varobj_get_array_number_of_children (value, type);
@@ -851,7 +851,7 @@ ada_varobj_get_value_of_array_variable (struct value *value,
static std::string
ada_varobj_get_value_of_variable (struct value *value,
struct type *type,
- struct value_print_options *opts)
+ const value_print_options *opts)
{
ada_varobj_decode_var (&value, &type);
--
2.49.0
next prev parent reply other threads:[~2026-07-04 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 22:05 [PATCH 0/9] Some cleanups and C++-ification of value_print_options Tom Tromey
2026-07-04 22:05 ` [PATCH 1/9] Return value_print_options from get_formatted_print_options Tom Tromey
2026-07-04 22:05 ` [PATCH 2/9] Return value_print_options from get_no_prettyformat_print_options Tom Tromey
2026-07-04 22:05 ` [PATCH 3/9] Convert get_user_print_options Tom Tromey
2026-07-04 22:05 ` [PATCH 4/9] Return a const reference from gdbpy_get_print_options Tom Tromey
2026-07-04 22:05 ` [PATCH 5/9] Return value_print_options from varobj_formatted_print_options Tom Tromey
2026-07-04 22:05 ` Tom Tromey [this message]
2026-07-04 22:05 ` [PATCH 7/9] Don't use 'struct' keyword with value_print_options Tom Tromey
2026-07-04 22:05 ` [PATCH 8/9] Use std::forward in fortran_array_walker Tom Tromey
2026-07-04 22:05 ` [PATCH 9/9] Use references for value_print_options Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260704-print-opts-cleanup-v1-6-fb54a5112a8d@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox