From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vfsoH5m0RmomuSIAWB0awg (envelope-from ) for ; Thu, 02 Jul 2026 14:57:29 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gWTCvo3n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6C7331E024; Thu, 02 Jul 2026 14:57:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 95ED11E024 for ; Thu, 02 Jul 2026 14:57:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 571064BA23E6 for ; Thu, 2 Jul 2026 18:57:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 571064BA23E6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gWTCvo3n Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 434464BA2E07 for ; Thu, 2 Jul 2026 18:57:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 434464BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 434464BA2E07 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783018623; cv=none; b=bGdsFDtDV+ursozChqNfEo5UBGTP43i11R9NmYrfiNiuIvLlGeFc8XOn+wwmCuwUJ8vcby2mmyIko0FQWqbEZoOIinxxPpD2X2sW9CIWKca0BE4UfifKOxrgwkZkhmBKDyqoHrbBoRavVwNdaTBhIV+vBVaheV5FKo5ZiETRjAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783018623; c=relaxed/simple; bh=mGCdT4ENV6O9F6EFc5OYwErKPjbFG56hyz2VVWT4C6c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=R+XCkJxPzUwvhAkIM98+aCQrmr3LGJ4YspCGuWAFNQ548fR1H3FML2bePPTY8afsVimFiGArm48UKpPlgFSwZjUVTqYurljhEJuD3XELWKFlBsnvU1i+trDZ8jOOs+u4cZPbcgZJnI+MG6AhQyqe7IjJKRTDL4rXvAqvSUlBZFE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gWTCvo3n DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 434464BA2E07 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-497deab2d66so402846b6e.0 for ; Thu, 02 Jul 2026 11:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1783018622; x=1783623422; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JYc4xRekjXYhQtwzDLjPmjdrHZBQlXAQ+o5qHbLAi1E=; b=gWTCvo3nN6N0u+rP6/ZrpKi4hgP8jSIbJazJ8vsBJXON2Rj1T3tJ+3SRnoGEKqFvW2 Bf1zOGj9AWbOxYpbOuzhKtgr6iT/iWy81blrLancV6G9/pO0Pxwor12w/O0plq9gTcYE Iz44q0+YJ4mnHAAs6D0bKaQn9NhU17y2dUWKAzNgKZdDg1pNQfW7OM0ukVsWM0TxlLl0 tHA2DYPraIJpmjwFNugDymHGnWl0/bwtrz8UKS8byHwAM4S6jLa7J0Pf1HOCNB6D+fhg icTAbOLUB7RMzHA9uvsZe2m4W1+eebtjaMVmE+5dXIoRj0wSljNBcVsGT3alYxyjDv41 DP6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783018622; x=1783623422; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JYc4xRekjXYhQtwzDLjPmjdrHZBQlXAQ+o5qHbLAi1E=; b=bBWqOJcdHMkiOpehtlmNs0+k9q6QXStBit/5NZKQ4H+g+07wzz9WosskvBLKVIyANj zhoNo70ldhLIVDJgZu+bfJKMuB8SjdUj/8i/iDvB6OH898TUWn4CGkgO/FeHmmTecBSQ VvvBU1x9Ol+w+k+fFZXbA6f3XLBTjVXepc0mpMHeC7ereBEZy8crvyQvdOeNNIstP84O qtH91T38id9VLKgGzqQNnFByRTjZaHGEveOPCUyvw/reMqb2+/HaIRkFm4bBH/eTV75A u5ZaUollfkWjz5pPrS/4X63I9pMnwK2rwQnRmSI7Fb7FBgH6/vZUdTJdNBX2Z1MCvIKb fjWg== X-Gm-Message-State: AOJu0Yzs0Awx3H9nPpkp5QqiDzof3XOORkUYXNwFqwCUNiFjSRwHsoj4 q+1Hz31zfudFRmldeID34Q3ghdbNjyi/sQ7hi8Qg63Q9qJsFwj67meofXVb+OYLHlmBesZR6AE0 O+O0= X-Gm-Gg: AfdE7clM5daNnbBgDuuluOUOWR6evmE7w9NQN6DzwnG7p7FwLm/1WIReei1qYwd0+1H dgX9OHf/AJRJxdMlQ0f+NchLiSsWkx5uwGdMl1eRfEyucOTEfULVuQMW6aOW85xoonAle8y8zBC t+VK0rbnubNOnq4GeD/vYscLlJ/rQxuqEcRsgrLbEEQoxuy1UTQFKkjGL3hTK5ZpOwMzOnakX29 HoIrNPay6QbmZaqRqZPGPAohnObV8XTs/Ui8sQQPo+n0MlIVeDR5JX2eXEJfqe3VHXXS9p6yn6b O1B7+w9kMMcjR6NEHkV00rspnNq4PqIZ5EwXkL92NrPlq8K42AYMPdfi8HfvfopK40Bhz6zMG/v 6bSsKaLd5Ssvstkcj28O3k5La4ZGsk/7fZ09YLP5TyGnRAs9JdPuwNcvidpGA6/e/b8xlTZhZAL qceW1+PZQTO3nKof61kwplSjCLaTReCb/v X-Received: by 2002:a05:6808:17aa:b0:496:6b1:cc7f with SMTP id 5614622812f47-497e1bec6ebmr856115b6e.3.1783018622577; Thu, 02 Jul 2026 11:57:02 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 5614622812f47-497d1b329eesm2354017b6e.13.2026.07.02.11.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 11:57:01 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Handle -1 in ptid_t::parse Date: Thu, 2 Jul 2026 12:56:59 -0600 Message-ID: <20260702185659.2658180-1-tromey@adacore.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org ptid_t::parse fails to correctly handle the -1 return from hex_or_minus_one in the 'p' case. As Mark Wielaard pointed out, it does this check: if (hex != ((unsigned_lwp_type) lwp)) However on 32-bit, this means that it will mishandle (ULONGEST) -1. This patch fixes the problem by adding a check for the -1 case. I built a -m32 gdb and verified this fix; I'm checking it in. --- gdbsupport/ptid.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbsupport/ptid.cc b/gdbsupport/ptid.cc index 5de1da3ba44..933e441f9b8 100644 --- a/gdbsupport/ptid.cc +++ b/gdbsupport/ptid.cc @@ -109,7 +109,7 @@ ptid_t::parse (const char *buf, const char **obuf, bool for_remote, error (_("invalid remote ptid: %s"), buf); lwp = (ptid_t::lwp_type) hex; - if (hex != ((unsigned_lwp_type) lwp)) + if (hex != ((unsigned_lwp_type) lwp) && hex != (ULONGEST) -1) error (_("invalid remote ptid: %s"), buf); if (obuf != nullptr) base-commit: de5bd217372a41c119492ef90ebd53eaae78f248 -- 2.54.0