From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id g84SG/ZmRWoHjCEAWB0awg (envelope-from ) for ; Wed, 01 Jul 2026 15:13:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=CERj3HFJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5FBA61E024; Wed, 01 Jul 2026 15:13:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C349D1E024 for ; Wed, 01 Jul 2026 15:13:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83CDB4BA2E18 for ; Wed, 1 Jul 2026 19:13:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83CDB4BA2E18 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=CERj3HFJ Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id EF9E34BA5435 for ; Wed, 1 Jul 2026 19:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF9E34BA5435 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF9E34BA5435 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782933213; cv=none; b=ZXJ5U38MTKLh8f/YKXO/iNa9tGMMrAX2Mhzv5sMiLENNXKifUI1nPraY1G6lWaCZI1gPHaCxeaoSAMhyl0UGyuw3FzRUI3/5lxaP6BvyhOVq5jixAyONbF2fEDeoHgi+tsgPGDShFqYvYEt/mpt6tM4EAeFCMVm1yRWwXi10ZyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782933213; c=relaxed/simple; bh=nThKOHaXGW/Ks9/+asn/AOR0LcrDjKdXthDaUTdrme8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=guOcvIKC4RcZLgOl5zLrK6NyojV2QLUflMNwbVQlDfoC7S55m1W/WH3j0DacjvBgq1jLvyqPjL8SLGAf/YZJhddDqbaDr6EAGl7DjEkHJQw8zAS5f9T16am9m2eNo0rRYYIBGO0UBhSiehYIYK/ShGB6iZSTrcI1OlK5wobTCYg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=CERj3HFJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF9E34BA5435 Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-4864ebb6268so451245b6e.3 for ; Wed, 01 Jul 2026 12:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1782933211; x=1783538011; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+iXRqUUeBf6t4s/HY5XEQmKpWMqRN/Q/bGs0t4cIlIc=; b=CERj3HFJlR9t+2eATZ3pMujpGk/ShXZXsXnksx+tiu7i5jiaK8TOUm/m6WkU19Meye hpIoqy2kZL96/+eME5FIaKhGl7GuCBzE7ZIrSju/ui2MzbIjw93fyaBspGSwrcvXHkvm Lv5SJsQGI2XDVqBGm3n1A+f4unmPepx1yW7cqp+DsffhME6ks/ds9ZfpuvuZecBDnwOn XnixayZ/22WMJX2KZejCtluPinDgFd2MtihE58Y6Pz2i++Q9pVtR5BaQQ7qgjuYfW3/N ybcobdsyphkKWez/RNZ/0smQkPuLKzC+HUIeawqbo9G9rHRIz7CDxeOa2E0W8DvwSFA2 D/OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782933211; x=1783538011; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+iXRqUUeBf6t4s/HY5XEQmKpWMqRN/Q/bGs0t4cIlIc=; b=IrQEzQ4b39ompNSwf2UeSDR0ToX2b4SEw5eyDq5ZfGsev7NBlwd7MbkFU/3wMfAg/f Et8TkTzzNY4DEqn5hBVaVAQ7XcJHpcYQBAWM9gfiV2vEFSMucFS5a7vzAakFfktK5Urv A4tB6WGzRuhyVh74kkBzSB1NBu3uIVSaobcNxzbFYZVl0SQL9SZSjZaGODsYNqR9kuoG B67b3QH0RiNg7N8ZWfFHibmTH1Gs079NB68M1aW93F6gDi2MbGVk9iazDYYUwYjeaN/3 l45pxTxzrW0SCvGmTR4mkj77BINGSDyIWdSXRlks6kf0+QkuG9TI/wsElWq3oYp7MNzB 5OIw== X-Gm-Message-State: AOJu0Yybsh/b0JCve2dQEwUZORQCSlJgzUSBB9oUXBjgPh/V5wTfulXJ fwsFPCyisD/wQAGd9kdPeeNJXOmwHL/5S+U1tlEAa8Y54Q4RQEXPu3Kv7KCYs4ouZqS1Jwp597Q B/S0= X-Gm-Gg: AfdE7cnu34AY5WdjuVDWofqCfhyVXayewsAbzjVxZdr5hc+7HApwACgflWC6UpzTZrV aEON0YNSOS/FOTEuZzL2xLp6qhV6wBatkDAtEdODUgKZmKuyAn2tZPYvTue0n3c+O8LPJd5Q51g EkVLwor6we7H/8taANQUOBz8kYAE0wUKer3CVmayVc31qC2pdAu+vJYvXVMvXw0NnytKbdJtfG6 9IRr6pP8QUrR7aXcIgTWecVhmbNbHRv01rByjtwG6HyqrVuBrAhoKNYmexog95FpGEyZgfhbY78 yDmzSrff1nBjbPZw+A0TpDT8WwWzBiPCeMuTgruPsC/CzQ/nxcm+f3wvCUzulQ3Uqfh37nkD6+a YcaCSgE2Yr7h/tBmBauq8gDxWMC1E2et3A/ROZ6vzgS4LSr56xxYrGPDaeqOUDAABtfdnC+Ie5K WzcbVhKdFGGiaWc7V84cYVBl0QOgu2Xhhs X-Received: by 2002:a05:6808:309b:b0:489:f199:42bb with SMTP id 5614622812f47-4960ee0f200mr2197860b6e.8.1782933211507; Wed, 01 Jul 2026 12:13:31 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 5614622812f47-49606b4fbe5sm2027901b6e.16.2026.07.01.12.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 12:13:30 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Assume an unrecognized gnatmake is very new Date: Wed, 1 Jul 2026 13:13:29 -0600 Message-ID: <20260701191329.2287960-1-tromey@adacore.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I don't know why -- though I suspect there may have been a change to the output of "gnatmake --version" -- but recently some gdb.ada tests have stopped running when llvm-gnatmake is used. The llvm-gnatmake I am testing against prints a version string that isn't recognized by gnat_version_compare. However, it seems to me that AdaCore is probably the main place where this can even occur; and furthermore that without some extra work, it seems reasonable for gnat_version_compare to assume that an unrecognized gnatmake is "very new". --- gdb/testsuite/lib/ada.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/ada.exp b/gdb/testsuite/lib/ada.exp index e20b35c8ebe..086866aca99 100644 --- a/gdb/testsuite/lib/ada.exp +++ b/gdb/testsuite/lib/ada.exp @@ -180,7 +180,8 @@ proc find_ada_tool {tool} { } # Compare the GNAT version against L2 using version_compare. If the -# compiler does not appear to be GCC, this will always return false. +# compiler does not appear to be GCC, this will assume that gnatmake +# is very new. proc gnat_version_compare {op l2} { set gnatmake [find_gnatmake] @@ -189,7 +190,8 @@ proc gnat_version_compare {op l2} { return 0 } if {![regexp {GNATMAKE ([0-9]+(\.[0-9]+)*)} $output match version]} { - return 0 + # Assume a "very new" version. + set version 99 } return [version_compare [split $version .] $op $l2] base-commit: c2d4b5e1135f75f7e4ef7ff68fa899bfe483671b -- 2.54.0