[PATCH v2 0/1] gdb: Preserve IFUNC marker when finding inferior functions

[Muhammad Kamran <muhammad.kamran@arm.com>]

This patch fixes a GDB inferior-call issue exposed by malloc being a GNU
IFUNC in glibc on AArch64.  The underlying problem is not AArch64-specific:
it can affect any inferior helper found through find_function_in_inferior's
minimal-symbol fallback when that helper is a GNU IFUNC.

GDB calls find_function_in_inferior ("malloc") when expression evaluation
needs to allocate memory in the inferior, for example for string literal
arguments.  In the minimal-symbol fallback, GDB created a synthetic ordinary
function pointer from the minimal symbol address.  If the symbol was a GNU
IFUNC, this lost the IFUNC marker, so call_function_by_hand did not resolve
the symbol before calling it.

The patch uses find_minsym_type_and_address to classify the minimal symbol
and propagates the IFUNC marker to the synthetic function type when needed.
The existing fallback return type is unchanged.

Changes since v1:
	* Reword the commit message.
	* Add a test case using a no-debug IFUNC malloc to exercise the
	  minimal-symbol fallback.

Muhammad Kamran (1):
  gdb: Preserve IFUNC marker when finding inferior functions

 .../gdb.base/gnu-ifunc-inferior-call-malloc.c | 27 +++++++++++
 .../gdb.base/gnu-ifunc-inferior-call.c        | 45 +++++++++++++++++++
 gdb/testsuite/gdb.base/gnu-ifunc.exp          | 40 +++++++++++++++++
 gdb/valops.c                                  |  6 ++-
 4 files changed, 117 insertions(+), 1 deletion(-)
 create mode 100644 gdb/testsuite/gdb.base/gnu-ifunc-inferior-call-malloc.c
 create mode 100644 gdb/testsuite/gdb.base/gnu-ifunc-inferior-call.c

-- 
2.43.0