From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rL8VCDT7NGp0AA8AWB0awg (envelope-from ) for ; Fri, 19 Jun 2026 04:17:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=BrW1wnWJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 04CB81E098; Fri, 19 Jun 2026 04:17:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 518BA1E024 for ; Fri, 19 Jun 2026 04:17:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D81554B9DB78 for ; Fri, 19 Jun 2026 08:17:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D81554B9DB78 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=BrW1wnWJ Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013046.outbound.protection.outlook.com [40.107.201.46]) by sourceware.org (Postfix) with ESMTPS id 176BA4BA23C2 for ; Fri, 19 Jun 2026 08:17:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 176BA4BA23C2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 176BA4BA23C2 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.201.46 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1781857042; cv=pass; b=A/qo3dtAhwSXKZNjnp4pjR5Bff4JtHvsVtlOmbk/hbxqVqBqLrI05WQgBV3/XDian/ez4zUttpHDzRuetxcKd15WmWuwT9p8aBMiq4p6NCTEaHfhpPX2My1fFtYe6blbb9rcJBw3gEcHzhchvWTLtf6OTcjvSahgkhr9lTvnqWc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1781857042; c=relaxed/simple; bh=GLLyjv1aCvc+6Ixc4EU+uPEBkyt5UzO3XYhAYwBSog4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rKLEhGE6AX3VRRc6dnB7SyIHh/coXx4zh02NBTigrO45lZdQgjZDj5QV+G5yN0DDCp7OaekgkQXtQTANQqgfiPkwhnV0mgWmou+NA94aQnkwhOx0UAR8AprF1uaas1GBkvTFJTTkp+HUquwelkAKwcFOkTo0O+TRiyKvtvt52es= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=BrW1wnWJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 176BA4BA23C2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y3UQ5/+sO5ObAYxWPqzOAXYYzHt6vAEOGfWbp77q/f49QSNam+ExvIKARHQyywTvid+/stFtB+/z4AfPbMKlAfq6wlV5TxYePhtuZvYNt4Th4yPv4gbaiv94ZJ9Tx94BZsuSe/LJf/SWnl5bVzp4Rvmm5uA0mczz7s0IovPpDE6M+iD2wQrK7RZVwcuTLbxNNqKp3driY4qSMCnN2EH/zzOzX0Ra6+IzIJhliiA6xBA0qvQSbiK68LFNhY7OU1SzFP+IJ6nKldD90n+yXzPA6Bd8QJ0b/PYySiFKxFubAPXCWustKgp3R4sTx2fYkfziWg2bRkQri2spFiJ/m85sdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t4tFc4EHPlf0aVFrMQ5e2/mmEnT3GDKdtEhN+kMdFLA=; b=PZN0GtKH2z9+sak3f2X7gLl8bynjQ+qa5HvsR4kzfVggNTEhp2+ekpvRBe7BswiU4vZE9R6Z3igFxk9asNEnWU+yHToCTpUa3wtde8EyHQvCJCfMTFTXp6z1rzjsqzECbtIpt8/R+GuOW2GxFjSYCdOBVD0G1AZjI1Hm2N/0rRAn6sj30usdQ7RT/7Ol8zcZ5KQhbR7pasXb3tb0jNbC/lkguOCWezEw3AX0In8A2K3TAy98AAFuLpHUnz97iD1ocEq8P6aTTuh5rWqUGZIhSXO1NlkuAnPrCsCUFQaCKKON6+x2heB6Uj+KPyR2kQ4gVvPkPHGJ3lbbnFbb2oqAYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4tFc4EHPlf0aVFrMQ5e2/mmEnT3GDKdtEhN+kMdFLA=; b=BrW1wnWJwzYaQEiP8hY7xKcPmI6TzMaU1DH9Tgb6lb3OFoULP1cCdFl6j7Dje+K6cwYSiii0A0rmHQ3Hyrk7ehKv1GU+Nydii7K+5BrsgPkUs5QxS+80btYKLY7uJoPqYG0Jk6aFRc9cHkKBN412LALY6NIu3R5nBAzM8hsNJgc= Received: from MN2PR05CA0066.namprd05.prod.outlook.com (2603:10b6:208:236::35) by IA1PR12MB9522.namprd12.prod.outlook.com (2603:10b6:208:594::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.12; Fri, 19 Jun 2026 08:17:17 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:208:236:cafe::5f) by MN2PR05CA0066.outlook.office365.com (2603:10b6:208:236::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.139.12 via Frontend Transport; Fri, 19 Jun 2026 08:17:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Fri, 19 Jun 2026 08:17:15 +0000 Received: from ctr-rack32-mi300x-1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 19 Jun 2026 03:17:15 -0500 From: Luis Machado To: Subject: [PATCH] [testsuite] Log gdb_do_cache misses only, not hits Date: Fri, 19 Jun 2026 03:16:55 -0500 Message-ID: <20260619081655.2166546-1-luis.machado@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|IA1PR12MB9522:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bf972f1-5eac-49c3-768f-08decddb2c5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|23010399003|376014|36860700016|18002099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: YC3lGysAjvLsLv5goxq7PpuDKgJYT5gNcP0VtJFjG6pjgCccTAjQhQG2T6mGEMmo4uOBSEhVZDzO8IpQw8t3o4ROdd/SSC+sqfGFKWA1JV9ZkZCpQGy3QiiOFfb0wGnVfTjAaRCL8IKiNaCNy7ZeZtjvMRt1mFmUyaE6U5UTEO1UtObWYddq2+iTYSEKzZvFWs2iUv6nZ+R60vrHjd1SHuNdE/XHb/mfyaUFQ0rXrJyPznNaR3MGqmNCDrllNrU8O0qxgplWUdJxynr4zqsEH4GzbK8PKzDce8RTABvmV97BOsYcALkn7bmjPzxTm0o1f70dtkvvRxn3qq9jP6SBCXjEOkb+Dba5oMVRyw8/MiUXF2iePmsxYFbeWP9Nam/yvLN4Z6lBnjCu8qE4nZPytTMhrYkr5aa3rl5a5QmKG60Sat+eVZN3TzHLt3mXyHeX3q4mo4l62lAD0LNdU+o9f5y05jT/cferZsh75VzW4gfQc+JUooUk1pWmMq/OSV6sIi9AjNHJ/fdKLsT0y4gKrcFq2ME0M1+xWZC6zYk3RbwKwn0v+LzrgKaXIaRBF+8T565J1AAwiLBxnHdYxccVGERA59J6WAA1x9TLtjGF90P9wJy/aXEorey6PQAQaeOw8VEgaKTaBL58aaNjTXqVLY+7fZ2FWwg4vwOl52ZU2OVlK1y9mPruCczHEKtOFtCLDlNr2dfZb++HLhpRS1VyzQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(23010399003)(376014)(36860700016)(18002099003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yJiymLXPHZoWJSmjOt1Ynm/2/5Q20s4yXMszNtw54q7vhv1FujZpUrFUMNy5OqwZ/26GMzW1GuDudVoJdJrxAp1UA8IT4EhIOrgUYIG8pEwYdE1YsjRoayvrNulE3nhJL6z/mJKRwVJVhK5p4vTEtLYOnYp8FX63VRUyb5fg2Vg5KIGIuNLYRuljObArMZWVAD9LDFjGA49VV04r49k0o7steQj2roYuXZF90y74fzJgoQEPzCUnsy96MtxBt9imDXsiLaEmilYdtfVnoOOLFbUD5bkqh4pe/I23fSsOFcRc9DWReXuh+E8WhnuD1YkLGTjTXROBjbxlkk6CKKqVNwm34JnPy4llNDYc6tmtOkhMrQgt6vc5uEAa9LFWiG4y/UJDZWki42USlsO8ME7+gPuC8DdVs9qIdaW2cuJvULvmaD6aXgfflX0axK81wKui X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2026 08:17:15.8563 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf972f1-5eac-49c3-768f-08decddb2c5b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9522 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The verbose -log in gdb_do_cache fired unconditionally on every call, including cache hits. With many tests calling gdb_caching_procs like get_compiler_info_1 per compilation, this produced dozens of repeated identical lines per test file in the log, like so: gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) gdb_do_cache: get_compiler_info_1 ( c ) Move the log to just before actual computation, after both the in-memory and on-disk cache checks. This helps keep the logs clean. --- gdb/testsuite/lib/cache.exp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/cache.exp b/gdb/testsuite/lib/cache.exp index 71688ee373e..1ba8c881716 100644 --- a/gdb/testsuite/lib/cache.exp +++ b/gdb/testsuite/lib/cache.exp @@ -103,8 +103,6 @@ proc gdb_do_cache {name args} { global gdb_data_cache objdir global GDB_PARALLEL - verbose -log "gdb_do_cache: $name ( $args )" - # Normally, if we have a cached value, we skip computation and return # the cached value. If set to 1, instead don't skip computation and # verify against the cached value. @@ -195,6 +193,7 @@ proc gdb_do_cache {name args} { set old_gdb_nested_caching_proc_calls $::gdb_nested_caching_proc_calls set ::gdb_nested_caching_proc_calls {} + verbose -log "gdb_do_cache: $name ( $args )" set real_name gdb_real__$name set gdb_data_cache(${cache_name},value) [gdb_do_cache_wrap $real_name {*}$args] set gdb_data_cache(${cache_name},exit) $::gdb_exit_called -- 2.34.1