From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0WvbM7sMNGqfqg0AWB0awg (envelope-from ) for ; Thu, 18 Jun 2026 11:20:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nc68FmK2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rZEo6hl7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nc68FmK2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rZEo6hl7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CEE541E098; Thu, 18 Jun 2026 11:20:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B03641E024 for ; Thu, 18 Jun 2026 11:20:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DCB04BA2E32 for ; Thu, 18 Jun 2026 15:20:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DCB04BA2E32 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nc68FmK2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rZEo6hl7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nc68FmK2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rZEo6hl7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 35EFB4BA2E08 for ; Thu, 18 Jun 2026 15:19:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35EFB4BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 35EFB4BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781795999; cv=none; b=GYNDqZ8WJTfFZ0QgtGi4WhasAH1uKZRrAkb/uzf9E6yjAAefLnN2gB+/0QE+MsgfgnUpyDvISt/jIfrLWGODMOpequp/U1LDMBQhyTHFOUSUCALuquegHJJ567/nEWQewqpg4fOHveYLb7H06uknnLREIao2JP5tukr+m/7ENYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781795999; c=relaxed/simple; bh=z1g5AFIjT5q5heR22/Yut2BvPp6/Zcd3I3pNHZiOHME=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=j+9656lSjNiVjo/aPmBA2S2oZMValmJhH4uqQrwxyBrWRINjlLd4dfiX9M/bEt36m6mCwe6L7oo7Dd89+XBYdQa7i8n0U8EdS/JN+1NGZodqhliuAb5r84QmUh1OYyu9bpKgngpyalYCHTlLlDp+FHztQEXOcbzNcctB0IYlcYg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nc68FmK2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rZEo6hl7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nc68FmK2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rZEo6hl7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35EFB4BA2E08 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3E9516D3BA for ; Thu, 18 Jun 2026 15:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781795998; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=74QRBckZ2PQPytxDXF5WRXSWQ5trYqtYEmpr0H8PfH0=; b=nc68FmK2tcccZr2SXptec4ZeQlVJ+PNtbsDQu9bg7mIN44liJusz5fGO+2C6KFPjhzHon2 Lmnycz02hbkyMCg0QrXCle8ikSSmNaHI+j5dEs9PhV8hXmt+Mmb6qR9xjMEF0pLnMi1Xff 4wgFEk1TfYI581clTgt0ijf1Q/plGrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781795998; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=74QRBckZ2PQPytxDXF5WRXSWQ5trYqtYEmpr0H8PfH0=; b=rZEo6hl7dbfjFydSjV8h6Nsy4TgaRTXx6L32QTnJpCRn7o8I5JFWjTzv18P+r+6vlAzamR WgcxkgTRx2ThBdAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781795998; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=74QRBckZ2PQPytxDXF5WRXSWQ5trYqtYEmpr0H8PfH0=; b=nc68FmK2tcccZr2SXptec4ZeQlVJ+PNtbsDQu9bg7mIN44liJusz5fGO+2C6KFPjhzHon2 Lmnycz02hbkyMCg0QrXCle8ikSSmNaHI+j5dEs9PhV8hXmt+Mmb6qR9xjMEF0pLnMi1Xff 4wgFEk1TfYI581clTgt0ijf1Q/plGrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781795998; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=74QRBckZ2PQPytxDXF5WRXSWQ5trYqtYEmpr0H8PfH0=; b=rZEo6hl7dbfjFydSjV8h6Nsy4TgaRTXx6L32QTnJpCRn7o8I5JFWjTzv18P+r+6vlAzamR WgcxkgTRx2ThBdAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2A746779A8 for ; Thu, 18 Jun 2026 15:19:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id itAkCZ4MNGpGTwAAD6G6ig (envelope-from ) for ; Thu, 18 Jun 2026 15:19:58 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [pre-commit] Add shellcheck Date: Thu, 18 Jun 2026 17:19:57 +0200 Message-ID: <20260618151957.76500-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I found a pure python implementation of shellcheck [1]. Use it to run shellcheck on scripts in the repo. Exclude any scripts that are not currently clean. Running it seems reasonably fast: ... $ pre-commit run shellcheck --all-files -v shellcheck...............................................................Passed - hook id: shellcheck - duration: 0.06s ... For information on other solutions, see this RFC [2]. [1] https://pypi.org/project/pureshellcheck/0.2.2/ [2] https://sourceware.org/pipermail/gdb-patches/2024-November/213400.html --- .pre-commit-config.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 141451501ed..630f85b8127 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -129,3 +129,11 @@ repos: language: unsupported_script entry: gdb/contrib/check-file-mode.sh files: '^(gdb|gdbserver|gdbsupport)/.*$' + - id: &id5 shellcheck + name: *id5 + language: python + additional_dependencies: ['pureshellcheck==0.2.2'] + entry: pureshellcheck + files: '^(gdb|gdbsupport|gdbserver)/' + types: ['shell'] + exclude: '^(gdb/config/djgpp/(djcheck.sh|djconfig.sh)|gdb/contrib/ari/(create-web-ari-in-src.sh|gdb_ari.sh|update-web-ari.sh)|gdb/contrib/(cc-with-tweaks.sh|expect-read1.sh|gdb-add-index.sh|license-check-new-files.sh)|gdb/gdb_buildall.sh|gdb/gdb_mbuild.sh|gdb/regformats/regdat.sh|gdb/syscalls/update-linux-from-src.sh|gdb/testsuite/make-check-all.sh|gdb/gcore-1.in|gdb/po/gdbtext|gdb/testsuite/lib/pdtrace.in)$|/configure$' base-commit: 478b1846cdb82b776c8dcbec20ecd198297cd8ff -- 2.51.0