From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QY8XAPH1M2p+hA0AWB0awg (envelope-from ) for ; Thu, 18 Jun 2026 09:43:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qWBCMNC5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aNqSGN4Z; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1f6woLoF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CHJVgWXq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EFA401E098; Thu, 18 Jun 2026 09:43:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4813D1E024 for ; Thu, 18 Jun 2026 09:43:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF3124BA2E1A for ; Thu, 18 Jun 2026 13:43:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF3124BA2E1A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qWBCMNC5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aNqSGN4Z; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1f6woLoF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CHJVgWXq Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 38A4B4B9DB6B for ; Thu, 18 Jun 2026 13:38:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38A4B4B9DB6B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38A4B4B9DB6B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781789923; cv=none; b=dSxDxwNWtfIbWDeI1/mEvs5QNTvu3qt4OcTIw/0gm0cyMdqZFs5S64CZ0bKCpt+ThWDLLDs8dW4S5yKL71hI8SqH//KwzxJNhif2DUGTSl8UmT4h0Sqy6GqblH78BuMPAlcrAfnfkyzRvwSvIjhcwC3OCl/zPZcj5hSzar+H0c8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781789923; c=relaxed/simple; bh=qaqYrLmgXhPHUN1TsySKtlYwlT1/mqGwu09NknXW8YI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=GxWm341hl8hDWxZIHJjhfKhPXAggTRiSYa1kCFBro3KQlCJLoAVQSjPY/6m6HKPWY7oCEkg8pAWAsRHTuOHQox05u+jHe0hgy81oxFPurrZ89HPSWHklL64ite0xHNedeiwMCvCgLkrKfD6j2shjlZyMIbZu2H7O6EicSKNBXI0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qWBCMNC5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aNqSGN4Z; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1f6woLoF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CHJVgWXq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 38A4B4B9DB6B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7B5EF6D2F8 for ; Thu, 18 Jun 2026 13:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781789900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LHAXJ4Ne/cGBobpi+epsZnWIhUUKA6OgHlFE+QKdUB4=; b=qWBCMNC5l/MTWuWJ4CzQ/dhO4ZNhcf7WNDZ47Q74VMZ4k2aJ180gAWRnvShk1/43FWkNfR 3DmPCTd9nMCx1o5hIW4pnaUJNyfWQFwnAB5HQel/im6iw7W2Oinlghm30HFuPee2KlcMql oec8SMc/9HNrjD8S8VfHMKyKXNIfjTs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781789900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LHAXJ4Ne/cGBobpi+epsZnWIhUUKA6OgHlFE+QKdUB4=; b=aNqSGN4Zmrvm+BKNvTzYG6EmjtdlQmQlDfpLU3i9YirtHhYuCiQvomeOpF3nPKR5kNe5Pi ZrBVa51VZZZ5KuCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1f6woLoF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CHJVgWXq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781789899; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LHAXJ4Ne/cGBobpi+epsZnWIhUUKA6OgHlFE+QKdUB4=; b=1f6woLoFw5XJpzR6MfuCbO705aqO4xgjhPkLDrG43VXDxtfnmXinGVG5hbKGSRCYeF/I56 Jop+H9Wz4w2pQJZIkSSwkxkxHabKRhfe7Y6v3j6gVcfS5noE7eAgq3lFfBGp6lFm7j7R7m lp7NTCO7/2po4LEQ0uLZJs2bCUnkpXg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781789899; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LHAXJ4Ne/cGBobpi+epsZnWIhUUKA6OgHlFE+QKdUB4=; b=CHJVgWXq2bvuhvJrTuaqry3rZK9Z8MjCJkvjXZHqOrn1ecDYiI9vkak4YxrUq3jj8HNTsw 61hARb5yMzmQmkDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 637A1779A8 for ; Thu, 18 Jun 2026 13:38:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SQTcFsv0M2oSaAAAD6G6ig (envelope-from ) for ; Thu, 18 Jun 2026 13:38:19 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 0/9] [gdb] More whitespace fixes Date: Thu, 18 Jun 2026 15:38:09 +0200 Message-ID: <20260618133818.55460-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 7B5EF6D2F8 X-Spamd-Result: default: False [-2.96 / 50.00]; BAYES_HAM(-2.95)[99.79%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:dkim, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, check-whitespace-pre-commit.py:url] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I came across the trailing-whitespace hook here ( https://github.com/pre-commit/pre-commit-hooks ) and tried it out: ... # Out-of-the-box pre-commit hooks. - repo: https://github.com/pre-commit/pre-commit-hooks rev: v6.0.0 hooks: - id: trailing-whitespace files: '^(gdb|gdbserver|gdbsupport)/.*$' exclude: 'ChangeLog' args: [--chars," \t"] ... The args field is necessary to stop it removing ^L. The result is: ... $ pre-commit run trailing-whitespace --all-files trim trailing whitespace................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing gdbsupport/Makefile.in Fixing gdb/config/djgpp/fnchange.lst Fixing gdb/doc/annotate.texinfo Fixing gdb/doc/stack_frame.txt Fixing gdb/exc_request.defs Fixing gdb/doc/refcard.tex Fixing gdb/gdb-gdb.gdb.in Fixing gdb/configure.tgt ... This made me look again at our homegrown whitespace check, and I found that it recognizes a set of clean files that doesn't include the above files. This patch series: - in check-whitespace-pre-commit.py, adds a todo list of files which are not yet clean, enabling complete checking for all other files, and - reduces the todo list with each following patch. Tom de Vries (9): [gdb] Increase clean range in check-whitespace-pre-commit.py [gdb] Fix leftover conflict marker in gdb/config/djgpp/README [gdb] Fix new blank line at EOF in a few scripts [gdb] Fix new blank line at EOF in a few xml files [gdb] Ignore whitespace in imported file gdb/exc_request.defs [gdb] Fix trailing whitespace in some files [gdb] Ignore trailing whitespace in gdb/gdb-gdb.gdb.in [gdb] Fix trailing whitespace in annotate.texinfo [gdb] Fix trailing whitespace in refcard.tex .pre-commit-config.yaml | 1 + gdb/.gitattributes | 6 +++++ gdb/config/djgpp/.gitattributes | 3 +++ gdb/config/djgpp/djcheck.sh | 1 - gdb/config/djgpp/fnchange.lst | 2 +- gdb/configure.tgt | 6 ++--- gdb/contrib/ari/create-web-ari-in-src.sh | 1 - gdb/contrib/ari/gdb_ari.sh | 1 - gdb/contrib/check-whitespace-pre-commit.py | 13 +++++++---- gdb/doc/annotate.texinfo | 8 +++---- gdb/doc/refcard.tex | 26 +++++++++++----------- gdb/doc/stack_frame.txt | 2 +- gdb/features/aarch64-pauth.xml | 1 - gdb/features/library-list-aix.dtd | 1 - gdb/features/s390-core64.xml | 1 - gdb/features/sparc/sparc32-cp0.xml | 1 - gdb/features/sparc/sparc32-fpu.xml | 1 - gdb/features/sparc/sparc64-cp0.xml | 1 - gdb/features/sparc/sparc64-fpu.xml | 1 - 19 files changed, 41 insertions(+), 36 deletions(-) create mode 100644 gdb/config/djgpp/.gitattributes base-commit: 478b1846cdb82b776c8dcbec20ecd198297cd8ff -- 2.51.0