From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/6] [pre-commit] Drop types_or filtering for tclint
Date: Wed, 17 Jun 2026 13:35:04 +0200 [thread overview]
Message-ID: <20260617113509.3510116-2-tdevries@suse.de> (raw)
In-Reply-To: <20260617113509.3510116-1-tdevries@suse.de>
The pre-commit tclint hook filters files using:
...
types_or: [file]
files: '^gdb/testsuite/.*\.(exp|tcl)$'
...
The types_or setting overrides the default file type of the hook. In the case
of tclint, there's no such default.
So this setting is not required, and causes additional filtering to run.
It was probably added by using one of the python hooks as a starting point.
Remove it.
---
.pre-commit-config.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index a5b526b1eec..902e58d4d8c 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -123,5 +123,4 @@ repos:
hooks:
- id: tclint
args: [--trust-plugins]
- types_or: [file]
files: '^gdb/testsuite/.*\.(exp|tcl)$'
--
2.51.0
next prev parent reply other threads:[~2026-06-17 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 11:35 [PATCH 0/6] [pre-commit] Clean up .pre-commit-config.yaml Tom de Vries
2026-06-17 11:35 ` Tom de Vries [this message]
2026-06-17 11:35 ` [PATCH 2/6] [pre-commit] Drop require_serial for pre-commit-setup Tom de Vries
2026-06-17 11:35 ` [PATCH 3/6] [pre-commit] Remove pass_filenames setting for check-whitespace Tom de Vries
2026-06-17 11:35 ` [PATCH 4/6] [pre-commit] Remove stages setting for two hooks Tom de Vries
2026-06-17 11:35 ` [PATCH 5/6] [pre-commit] Drop always_run setting for codespell-log Tom de Vries
2026-06-17 11:35 ` [PATCH 6/6] [pre-commit] Reorganize .pre-commit-config.yaml Tom de Vries
2026-06-17 19:28 ` [PATCH 0/6] [pre-commit] Clean up .pre-commit-config.yaml Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617113509.3510116-2-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox