From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cLFaJUAWMWou3AkAWB0awg (envelope-from ) for ; Tue, 16 Jun 2026 05:24:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0lA/H8ua; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OmOkp3yw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0lA/H8ua; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OmOkp3yw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 898E61E024; Tue, 16 Jun 2026 05:24:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 33EE71E024 for ; Tue, 16 Jun 2026 05:24:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E931D48F66D1 for ; Tue, 16 Jun 2026 09:24:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E931D48F66D1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0lA/H8ua; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OmOkp3yw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0lA/H8ua; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OmOkp3yw Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B00654B920C6 for ; Tue, 16 Jun 2026 09:23:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B00654B920C6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B00654B920C6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781601827; cv=none; b=YQqg5ngeR+qeXlhKX/Tnqp0BOnda6/R2KOW9ry47FFx/T4rjNopLgP6UkVmOjIRLlByhU+KxdQMXE0utJ4q20zTXyA+OoY6QAOzkLSzr1vTe5Qu77QGxYRAUH6lTLGsbPF/p2ctnKg3RHT2vAQptB4HrpIPkaTYzs69+eYFcXvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781601827; c=relaxed/simple; bh=90dpi4hKuoqxHfg8Dl8R2/NTWMv7mz/KllyJaAMsE/M=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=mQY6yi1qbyVWDJOQWuRg54SdkcC6njnVNqLuWw9krkdQFqqWDTdvgWmVeRnixxFfRQqL6zBztzu12ptHrfevVFKPGHu9xu+VUL751wuSWRiCkHXhPBkdG6Bz3Gun2AEUmd6DT33orU+nfMj3ovfngekNtwQNvV93b94QvYftu4I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0lA/H8ua; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OmOkp3yw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0lA/H8ua; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OmOkp3yw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B00654B920C6 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9A2D775AAE for ; Tue, 16 Jun 2026 09:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781601826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=p7CRnu8kTEJfsaVzdtG4ihaEycBb29fGT5+LnuE6nhY=; b=0lA/H8ua76JPjx04yF2f1JIRcln3PxsQwRhVB8E8EjouqBqyBOM+v4ewR2KIeqM6zUQLuE xNklI8oknmW9yGmWCgJBE1HmTAKLGcZ5lpOtr+1IIlxGQu43JYWBeBZR7x18vHbJ4f9EMC AeTlbDw2tbx7FvwQRT65hXV9wbCKbDc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781601826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=p7CRnu8kTEJfsaVzdtG4ihaEycBb29fGT5+LnuE6nhY=; b=OmOkp3ywwP3ho8MK7gxONX6HDrI2uyTm8SM9eNkrfSvqahsOA6BKTLbRwHkSk+w9R+ZUv+ /Vn1ME6OptADdwAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0lA/H8ua"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OmOkp3yw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781601826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=p7CRnu8kTEJfsaVzdtG4ihaEycBb29fGT5+LnuE6nhY=; b=0lA/H8ua76JPjx04yF2f1JIRcln3PxsQwRhVB8E8EjouqBqyBOM+v4ewR2KIeqM6zUQLuE xNklI8oknmW9yGmWCgJBE1HmTAKLGcZ5lpOtr+1IIlxGQu43JYWBeBZR7x18vHbJ4f9EMC AeTlbDw2tbx7FvwQRT65hXV9wbCKbDc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781601826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=p7CRnu8kTEJfsaVzdtG4ihaEycBb29fGT5+LnuE6nhY=; b=OmOkp3ywwP3ho8MK7gxONX6HDrI2uyTm8SM9eNkrfSvqahsOA6BKTLbRwHkSk+w9R+ZUv+ /Vn1ME6OptADdwAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7F02E779A8 for ; Tue, 16 Jun 2026 09:23:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dGY2HSIWMWqPMwAAD6G6ig (envelope-from ) for ; Tue, 16 Jun 2026 09:23:46 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [pre-commit] Stop using deprecated language script Date: Tue, 16 Jun 2026 11:23:46 +0200 Message-ID: <20260616092346.3242305-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 9A2D775AAE X-Spamd-Result: default: False [-3.00 / 50.00]; BAYES_HAM(-2.99)[99.96%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:dkim, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In v4.4.0, pre-commit renamed language script to unsupported_script. The rename was done to stress that pre-commit doesn't provide an environment for the script to run in [1]. The language script is now a deprecated alias for unsupported_script, and the plan seems to be to initially produce a deprecation warning, and eventually remove support for the alias completely. Start using the new name: unsupported_script. Furthermore, the check-include-guards hook uses language python, and indeed it uses a python script, but it doesn't really need a virtual environment. It imports modules fnmatch, re, sys and typing, all of which are available in python 3.10 and later, which is the environment pre-commit itself requires (because we require pre-commit v4.5.1 or later, and pre-commit requires python 3.10 since v4.4.0). So while we're at it, use unsupported_script for this hook as well, reducing the amount of environments pre-commit has to manage. Tested using "pre-commit run --all-files" with python 3.10, as well as 3.13. [1] https://github.com/pre-commit/pre-commit/pull/3577 --- .pre-commit-config.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3c2a27acb11..351b9f6933f 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -84,7 +84,7 @@ repos: hooks: - id: check-include-guards name: check-include-guards - language: python + language: unsupported_script entry: gdb/check-include-guards.py # All gdb header files, but not headers in the test suite. files: '^(gdb(support|server)?)/.*\.h$' @@ -100,7 +100,7 @@ repos: stages: [pre-commit] - id: check-whitespace name: check-whitespace - language: script + language: unsupported_script entry: gdb/contrib/check-whitespace-pre-commit.py files: '^(gdb(support|server)?)/.*$' pass_filenames: true @@ -114,7 +114,7 @@ repos: require_serial: true - id: check-file-mode name: check-file-mode - language: script + language: unsupported_script entry: gdb/contrib/check-file-mode.sh files: '^(gdb|gdbserver|gdbsupport)/.*$' - repo: https://github.com/nmoroze/tclint base-commit: a3ccc1836915eb694ac0f9b97ebb345bf7c83597 -- 2.51.0