From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gTjJMhftMGq/pAkAWB0awg (envelope-from ) for ; Tue, 16 Jun 2026 02:28:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Z/widAH1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7g/IwRPF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C6Wq01xg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=o6JrQKDB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CAC411E098; Tue, 16 Jun 2026 02:28:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 658381E024 for ; Tue, 16 Jun 2026 02:28:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 038D848FDECC for ; Tue, 16 Jun 2026 06:28:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 038D848FDECC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Z/widAH1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7g/IwRPF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C6Wq01xg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=o6JrQKDB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 9C93748FBCBB for ; Tue, 16 Jun 2026 06:23:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C93748FBCBB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9C93748FBCBB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781591021; cv=none; b=KNCZJpeljHOwMlQl1w6QUGgb9Zvkvp1h+fOwZR7DTMEETD2ETesoUtRUKnDDmPJXqU6UCbOx3fWvxC4+Rz6LNEipAmpW1KynZcOz+ruDddAwvSLQV+ImW21La6tHXRSxGN73P5robTWcTUFzWDu+PwuZw7iAHIwuQjncbLMO35M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781591021; c=relaxed/simple; bh=dZVLZb1oYBhIZ2315aWkFWfm6HSi8zOiGu1NP6jUEvY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=ZKm47IJjby/SGwUH59H8aPvjtb5OJ0ngYr8YuZZKJr4zeo4dZxNb3MBnuQegMSXMv3t+GxdzyxB2inQJ5fMw7nO0wcgUj9g3++uHvxi/A3jlfFgxcugiljDFIwzHoMgHwWGMs3cFNHNC9ctwKvHQ+gvpTYPJ4/Ea19U5/89eh60= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Z/widAH1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7g/IwRPF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C6Wq01xg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=o6JrQKDB DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C93748FBCBB Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9D7226CB0D for ; Tue, 16 Jun 2026 06:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781590980; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/PfN5i2dultL1mMiQqFFNY9fE5Xy/nXEmRnOm5dUG84=; b=Z/widAH1HORoYwYcCE+SLBX0Ot0dNuwUwpqERtEA03Y6g+2RncMvFTzVlccKBAinvQUIF2 HDzMe8uaDxNbkKF6yJ6rICDgv9w8GPknMStFR3OW459Mh8evv+/XN+xEEQD4ulfkImW8dK p9WOCJoGu9Y7qi1OlpdnezpsoKr1Zi4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781590980; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/PfN5i2dultL1mMiQqFFNY9fE5Xy/nXEmRnOm5dUG84=; b=7g/IwRPF3qfg5oGMCOpOtHVszkYTMhKti5OPE7vk55/8hw/u+6bNUcK2QXD+6M1Q8Jj9NQ ygdoEO49jwX/6aCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=C6Wq01xg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o6JrQKDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781590979; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/PfN5i2dultL1mMiQqFFNY9fE5Xy/nXEmRnOm5dUG84=; b=C6Wq01xgaW0NV4ch+5hNlCJpqd1oYo/VIhYtaTy4FL1xj2OLjM0yRyHrGjAx9h6x6Lz/eg sqfNJ9woch7azmRy85UxwwGfVRio1bmewMcA7BbxtXXPfnIQ6dUYUPcslfh/608+sa7sLF BvyJP+hoV55AeICVffj0AQXU4zN0NO8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781590979; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/PfN5i2dultL1mMiQqFFNY9fE5Xy/nXEmRnOm5dUG84=; b=o6JrQKDBA+7efXbWkvcr92kEh4BJOawws+0egKA8foRP8eWX6V86hqlW9MS3SIMBE0oFa0 1uwe90ZUu6hXa5AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 86EC0779AB for ; Tue, 16 Jun 2026 06:22:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aAT3HsPrMGr8fAAAD6G6ig (envelope-from ) for ; Tue, 16 Jun 2026 06:22:59 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 12/12] [gdb] Use using in compat_x32_clock_t typedef Date: Tue, 16 Jun 2026 08:22:57 +0200 Message-ID: <20260616062257.3164438-13-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260616062257.3164438-1-tdevries@suse.de> References: <20260616062257.3164438-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 9D7226CB0D X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In commit 6c85ef111b0 ("[gdb] Use using instead of typedef"), I did: ... -typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t; +using compat_x32_clock_t = long __attribute__ ((__aligned__ (4))); ... which I had to revert because clang ignores the attribute in this variant. Pedro suggested instead using: ... using compat_x32_clock_t [[gnu::aligned (4)]] = long; ... which does work with both clang and gcc. [ Note that it's not a question of how the attribute is worded, this also works: ... using compat_x32_clock_t __attribute__ ((__aligned__ (4))) = long; ... It's just a question of where the attribute is placed. ] Fix this by using Pedro's suggestion. Suggested-By: Pedro Alves --- gdb/nat/amd64-linux-siginfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/nat/amd64-linux-siginfo.c b/gdb/nat/amd64-linux-siginfo.c index 99faccabf37..d524cb9f80a 100644 --- a/gdb/nat/amd64-linux-siginfo.c +++ b/gdb/nat/amd64-linux-siginfo.c @@ -203,7 +203,7 @@ struct compat_siginfo_t }; /* For x32, clock_t in _sigchld is 64bit aligned at 4 bytes. */ -typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t; +using compat_x32_clock_t [[gnu::aligned (4)]] = long; struct __attribute__ ((__aligned__ (8))) compat_x32_siginfo_t { -- 2.51.0