From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DFUCMAAXLGpxTAMAWB0awg (envelope-from ) for ; Fri, 12 Jun 2026 10:26:08 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=la0m9F5b; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B0AB51E070; Fri, 12 Jun 2026 10:26:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03BA91E070 for ; Fri, 12 Jun 2026 10:26:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25B414B99F68 for ; Fri, 12 Jun 2026 14:26:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25B414B99F68 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=la0m9F5b Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 83D014BA2E1A for ; Fri, 12 Jun 2026 14:25:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83D014BA2E1A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83D014BA2E1A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781274325; cv=none; b=cPK3pl8vKTsGHHJQBvm1LMlaVGp/YX2m5Odizf5zMaNY16GbEF/hELVEZWAW4WchFgpsuKvZpuswVh/8Bd/6VQaRLsQOYPEgcyuFZJYW8PZQMITzbbPJT7w1J5Ttnmws1zFp6v3KQBcIajJMqHKe8jiDb8+DlqqWnuT13Ka3nTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781274325; c=relaxed/simple; bh=nrYbRHe1bArD8W1/MRbqFnZSA1QPKs5cf7J9Okt06EI=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=lI3bC5bU4hHo1fMz2enRbEDcclngU98/zA/Uc2QZZWWa53P/z86t5C7LtxO7mgs04b6MlyAyTgD45s+0gP6gxeSsGQUmaEiY3txevWaxyfcrnscn6oRIF7rmQmlmqqRmkHYyypKZRxkFBwoV8myyIhZ3kLiniwBZ0lYqpZEm19E= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=la0m9F5b reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83D014BA2E1A Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id Y1pjwXNezVGUKY2p3w1AUt; Fri, 12 Jun 2026 14:25:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Y2p2wwy6knfJUY2p2wL4pR; Fri, 12 Jun 2026 14:25:24 +0000 X-Authority-Analysis: v=2.4 cv=KajSsRYD c=1 sm=1 tr=0 ts=6a2c16d5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=ItBw4LHWJt0A:10 a=O6vHjcNCt2mKJDviqfsA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rk1MZ4WwdDP74A6/jZIgtJ7Yj9FO52oorTP4i04JZSs=; b=la0m9F5brprvfT5UTDt7HRv0oB mAflv3ysn+OiXEGBZJU4Ab1CYIPEQqk6RvvrJuWsKsHwehWFBgs4+M47GKP9JKsEB5nzCYfZppaEu Icmzpt6MnABaaIH1J75PWDDbz; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:50348 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wY2p2-00000001fM4-0r0l; Fri, 12 Jun 2026 08:25:24 -0600 From: Tom Tromey Date: Fri, 12 Jun 2026 08:25:22 -0600 Subject: [PATCH 2/5] Make two ui_out methods 'private' MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260612-submit-zebra-style-v1-2-cfd00b5c984c@tromey.com> References: <20260612-submit-zebra-style-v1-0-cfd00b5c984c@tromey.com> In-Reply-To: <20260612-submit-zebra-style-v1-0-cfd00b5c984c@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wY2p2-00000001fM4-0r0l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net ([192.168.122.1]) [75.166.225.82]:50348 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNvqwR5jInKQ7pYM1fbPTarT4PqDZLMmfyBm62yUY4pnWlagtUDuN4xRCsbbKzvyEHMQc6c2qPEKTzr4gA23muI8lR06Oii7U7t/ZO3YqpnCsbIg1KVY jB2yvlAC9ecgHELsNFbxMpohjFkWeNKGOxMskotLSFte7JkOKUDH+cOByuYtR9cWaPKfIP7tqBD5yG5SuCNuo7pHWpv8RWKii+Y= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This marks ui_out::table_begin and ui_out::table_end as private. They should only be called from ui_out_emit_table. --- gdb/ui-out.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ui-out.h b/gdb/ui-out.h index d59e58631e9..a7230846115 100644 --- a/gdb/ui-out.h +++ b/gdb/ui-out.h @@ -30,6 +30,7 @@ class ui_out_level; class ui_out_table; +class ui_out_emit_table; struct ui_file; /* the current ui_out */ @@ -173,11 +174,9 @@ class ui_out field, ... }, ... ] }''. If NR_ROWS is negative then there is at least one row. */ - void table_begin (int nr_cols, int nr_rows, const std::string &tblid); void table_header (int width, ui_align align, const std::string &col_name, const std::string &col_hdr); void table_body (); - void table_end (); void begin (ui_out_type type, const char *id); void end (ui_out_type type); @@ -393,6 +392,12 @@ class ui_out { return false; } private: + + /* A table can only be started or ended by ui_out_emit_table. */ + friend class ui_out_emit_table; + void table_begin (int nr_cols, int nr_rows, const std::string &tblid); + void table_end (); + /* A helper for vmessage that wraps a call to do_message. This will update CURRENT_STYLE when needed. */ void call_do_message (ui_file_style ¤t_style, -- 2.49.0