From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7VOMGbm7JmpoKTwAWB0awg (envelope-from ) for ; Mon, 08 Jun 2026 08:55:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTdMqk7t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kJC3o/pR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTdMqk7t; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kJC3o/pR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5704B1E062; Mon, 08 Jun 2026 08:55:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4DF4A1E062 for ; Mon, 08 Jun 2026 08:55:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 669AE4AADCED for ; Mon, 8 Jun 2026 12:55:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 669AE4AADCED Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTdMqk7t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kJC3o/pR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTdMqk7t; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kJC3o/pR Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id AFC274A9BE5D for ; Mon, 8 Jun 2026 12:54:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFC274A9BE5D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFC274A9BE5D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780923274; cv=none; b=llBEnWDCP8dlNS9mv2hVrWtS2BX8ostkP/NQvoIMUWWxQ1bNIj5Bkdu2q/yM+JY4eLwHSNwJhJgCJmaj+HWaxkuj9QtZihcRUHt5OJ815AMdreDkmZY7chAo6LwlbWJOqewLR229IQ1eM/YmukhI9hX/MLsEiswSmK79ecReE5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780923274; c=relaxed/simple; bh=UzkUIq1C23uSmwQOci72NW4njuELeKx1BkONMw25+CE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=In6ueJc9XFZQvMkIhdzgv+aHZv8S/qY1PVox2rTk9PyIHhnBoSsdFpV/VD1ylFadlcRzd3xzmgge3dOHWg6otCOIvETr3kzbCH4Ohe0gCcageVKVSn3IfnY8NMQ02cZG7qKoBmG8pKq8T85E2WSm36/BUf3m0usIgcFhfj+o1nA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTdMqk7t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kJC3o/pR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oTdMqk7t; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kJC3o/pR DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFC274A9BE5D Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2D1CB678CD for ; Mon, 8 Jun 2026 12:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780923261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MoUohK6ZBLuHQueIUvYJdfKms5J0xBHpvqT93LQoznw=; b=oTdMqk7thCoEB7TWg03bqiNWoteRaGnwaoD6+Z0zIIHqQnAX1xVguPTeipAzJmDsCkYQHW /RKp92TZd+oPMqd87WN9tfuAV3AZTsm3jS6CCYBEy/iR+4bgoldfKRSeLhJupXqfynsoJL AFD7wPFvEA2ET0J7HeLH9jaBukhOzXA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780923261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MoUohK6ZBLuHQueIUvYJdfKms5J0xBHpvqT93LQoznw=; b=kJC3o/pR44SxuBrUYBJeqqfJniGisZBQRcaKZSeqG9MmBbSnS+XFgpFTt7bkxY2pGlX16+ I6YkRLbqEAH+c3Ag== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oTdMqk7t; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="kJC3o/pR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780923261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MoUohK6ZBLuHQueIUvYJdfKms5J0xBHpvqT93LQoznw=; b=oTdMqk7thCoEB7TWg03bqiNWoteRaGnwaoD6+Z0zIIHqQnAX1xVguPTeipAzJmDsCkYQHW /RKp92TZd+oPMqd87WN9tfuAV3AZTsm3jS6CCYBEy/iR+4bgoldfKRSeLhJupXqfynsoJL AFD7wPFvEA2ET0J7HeLH9jaBukhOzXA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780923261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MoUohK6ZBLuHQueIUvYJdfKms5J0xBHpvqT93LQoznw=; b=kJC3o/pR44SxuBrUYBJeqqfJniGisZBQRcaKZSeqG9MmBbSnS+XFgpFTt7bkxY2pGlX16+ I6YkRLbqEAH+c3Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 12398779A7 for ; Mon, 8 Jun 2026 12:54:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sCMGA327Jmr9WQAAD6G6ig (envelope-from ) for ; Mon, 08 Jun 2026 12:54:21 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 3/3] [gdb/contrib] Fix ELFParseError in dwarf-to-dwarf-assembler.py Date: Mon, 8 Jun 2026 14:54:20 +0200 Message-ID: <20260608125420.2318026-4-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260608125420.2318026-1-tdevries@suse.de> References: <20260608125420.2318026-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 2D1CB678CD X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When running dwarf-to-dwarf-assembler.py on outputs/gdb.dwarf2/implptr-64bit/implptr-64bit-d2-o8-a4-r4-t0, I run into: ... elftools.common.exceptions.ELFParseError: expected 8, found 5 ... for the DWARF: ... <2><335>: Abbrev Number: 8 (DW_TAG_variable) <336> DW_AT_name : p <338> DW_AT_location : 6 byte block: f2 14 3 0 0 0 \ (DW_OP_GNU_implicit_pointer: <0x314> 0) ... Pyelftools expects that DW_OP_GNU_implicit_pointer has an 8-byte reference operand (because it's a 64-bit DWARF unit), but instead it has a 4-byte reference. The DWARF is correct, it's a cornercase of using DW_OP_GNU_implicit_pointer in DWARF v2, where DW_FORM_ref_addr references have the same size as an address on the target system, something that was changed in DWARF v3. Handle this by catching the error and printing: ... DW_AT_location "\xf2\x14\x03\x00\x00\x00" DW_FORM_block \ # Failed to print DWARF expression: expected 8, found 5 ... --- gdb/contrib/dwarf-to-dwarf-assembler.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/contrib/dwarf-to-dwarf-assembler.py b/gdb/contrib/dwarf-to-dwarf-assembler.py index c1818f9fdb8..797d5a46d72 100755 --- a/gdb/contrib/dwarf-to-dwarf-assembler.py +++ b/gdb/contrib/dwarf-to-dwarf-assembler.py @@ -48,6 +48,7 @@ from io import BytesIO, IOBase from logging import getLogger from typing import Annotated, Optional +from elftools.common.exceptions import ELFParseError from elftools.construct.lib.container import ListContainer from elftools.dwarf.compileunit import CompileUnit as RawCompileUnit from elftools.dwarf.die import DIE as RawDIE @@ -245,6 +246,9 @@ class DWARFAttribute: postfix = " # Failed to print op as DWARF expression: " + hex( int(str(e)) ) + except ELFParseError as e: + # Fall through to basic printing. + postfix = " # Failed to print DWARF expression: " + str(e) # Print the data as a string in "\x01\x02\x03\x04" format. result = "" for op in self.value: -- 2.51.0