From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9jk7LwrZImoDJDYAWB0awg (envelope-from ) for ; Fri, 05 Jun 2026 10:11:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=O/YhXgal; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBPB8T1u; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=O/YhXgal; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBPB8T1u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD7851E0A6; Fri, 05 Jun 2026 10:11:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AD2201E062 for ; Fri, 05 Jun 2026 10:11:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41E274BCA402 for ; Fri, 5 Jun 2026 14:11:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41E274BCA402 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=O/YhXgal; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBPB8T1u; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=O/YhXgal; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBPB8T1u Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id E1E834BA2E06 for ; Fri, 5 Jun 2026 14:10:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1E834BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1E834BA2E06 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780668653; cv=none; b=DCa2s915iySHa436UB/hYKujB/uYe+nVxMbWByPXnQC5gFTH4bWiVdp9v8Iw+efKPGGuQ0X5Cp3KzXHAsdR+cg3w4X4bnQb78RD4fgKAc9gZMoSKJUPG4q/ga0hxKu3ocrhud7P7iRZnHyHDwhUdWCOkdTKMw3YGD12I7MyQeQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780668653; c=relaxed/simple; bh=Aa+Z3yFzVYQavQikwJAx+tFmgK6NXdfg0jm0dIa3rWA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=stWh9/ezM5jG6CVmDj/kT50jqoH9v1ijDgML4r417grakjnsTTfeKBVYjhA3rXp3Z2Y9KeerTLEeyG6xOjIJUxE+ohowaCTv7yPOpuIXu8JwIFdqVS2ycPUz0mSyQ8HUx9I4ylft7UXOcQl5SoHhEvbpaaMZ6NjCXWtm5uKSXBM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=O/YhXgal; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBPB8T1u; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=O/YhXgal; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KBPB8T1u DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1E834BA2E06 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D71836AF8A for ; Fri, 5 Jun 2026 14:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780668651; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jAGMrAQFNK6v1hN8/EZTHHhkTmxJIJxmyPMKNJIqSfY=; b=O/YhXgallXmxzZDx4NgdSCPcPSm1oE56ZuAM+WsFbaP/0VCdDGkWq0l3Qn5BtOy5ZyUi+Q YZ70yOKXssTVFgsitJz/vOTIuT7WRG5xnrVft75NcPWd2iGxYQExdJpOwT5/xWOdUEzsG+ SXM8KrRqUcvG935szQZ5K7qxMouGgJo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780668651; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jAGMrAQFNK6v1hN8/EZTHHhkTmxJIJxmyPMKNJIqSfY=; b=KBPB8T1uycYpPGRANLL84BknuLcQqVRqAXJYlsHdpB4cJSxtHJsSCyjItzgU1vJTzYlfz+ Tdzi6DG/8FxdlODA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="O/YhXgal"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KBPB8T1u DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780668651; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jAGMrAQFNK6v1hN8/EZTHHhkTmxJIJxmyPMKNJIqSfY=; b=O/YhXgallXmxzZDx4NgdSCPcPSm1oE56ZuAM+WsFbaP/0VCdDGkWq0l3Qn5BtOy5ZyUi+Q YZ70yOKXssTVFgsitJz/vOTIuT7WRG5xnrVft75NcPWd2iGxYQExdJpOwT5/xWOdUEzsG+ SXM8KrRqUcvG935szQZ5K7qxMouGgJo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780668651; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jAGMrAQFNK6v1hN8/EZTHHhkTmxJIJxmyPMKNJIqSfY=; b=KBPB8T1uycYpPGRANLL84BknuLcQqVRqAXJYlsHdpB4cJSxtHJsSCyjItzgU1vJTzYlfz+ Tdzi6DG/8FxdlODA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C386B779A8 for ; Fri, 5 Jun 2026 14:10:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1vKKLuvYImqtPAAAD6G6ig (envelope-from ) for ; Fri, 05 Jun 2026 14:10:51 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [RFC] [pre-commit] Add check-new-file-license Date: Fri, 5 Jun 2026 16:10:51 +0200 Message-ID: <20260605141051.881518-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:dkim, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: D71836AF8A X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I forgot to add a copyright notice to a file. I came across gdb/contrib/license-check-new-files.sh, and ran it out of curiosity, and it pointed out the file. Add a pre-commit check check-new-file-license that runs the script. The check is only run for new files, because it's fairly slow, about 2 seconds for an empty file: ... $ touch gdb/bla.c $ git add gdb/bla.c ... check-new-file-license...................................................Passed - hook id: check-new-file-license - duration: 2.88s gdb/bla.c: None ... [master 86d2adef7bc] try 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 gdb/bla.c ... I added support in gdb/contrib/license-check-new-files.sh to check the staging area by representing it as a diff between HEAD and HEAD+STAGED. --- .pre-commit-config.yaml | 10 ++++++++++ gdb/contrib/license-check-new-files.sh | 16 ++++++++++------ 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index fe8466433ac..1f1a217b887 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -112,6 +112,16 @@ repos: additional_dependencies: ["pyyaml"] always_run: true require_serial: true + - id: check-new-file-license + name: check-new-file-license + language: python + entry: gdb/contrib/license-check-new-files.sh + args: [-s, HEAD, HEAD+STAGED] + files: '^$' + additional_dependencies: ["GitPython", "scancode-toolkit"] + always_run: true + verbose: true + require_serial: true - repo: https://github.com/nmoroze/tclint rev: v0.8.0 hooks: diff --git a/gdb/contrib/license-check-new-files.sh b/gdb/contrib/license-check-new-files.sh index b961780a23f..8e9c398db7a 100755 --- a/gdb/contrib/license-check-new-files.sh +++ b/gdb/contrib/license-check-new-files.sh @@ -110,14 +110,18 @@ def main(argv): print(f'not a git repository (or any parent up to mount point "{dir}")') sys.exit(2) - # Get from/to commits - fc = get_commit(repo, from_commit) - tc = get_commit(repo, to_commit) + if from_commit == "HEAD" and to_commit == "HEAD+STAGED": + diff = repo.index.diff("HEAD", R=True) + else: + # Get from/to commits. + fc = get_commit(repo, from_commit) + tc = get_commit(repo, to_commit) + diff = fc.diff(tc, paths=paths) + paths = [str(dir) for dir in args.paths.split(",")] + print(f'Scanning directories {",".join(f"{s}/" for s in paths)}...') # Loop over new files - paths = [str(dir) for dir in args.paths.split(",")] - print(f'Scanning directories {",".join(f"{s}/" for s in paths)}...') - for file in fc.diff(tc, paths=paths).iter_change_type("A"): + for file in diff.iter_change_type("A"): filename = file.a_path if not args.skip: print(f"checking licenses for {filename}... ", end="", flush=True) base-commit: 17113bdf7c556b987c55b170acad223f24304298 -- 2.51.0