From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kWL8H+6eImqs0DUAWB0awg (envelope-from ) for ; Fri, 05 Jun 2026 06:03:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L9DdwR3j; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FNLrl9m; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L9DdwR3j; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FNLrl9m; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7C3071E0A6; Fri, 05 Jun 2026 06:03:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 74F231E062 for ; Fri, 05 Jun 2026 06:03:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F281F4BCA40C for ; Fri, 5 Jun 2026 10:03:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F281F4BCA40C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L9DdwR3j; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FNLrl9m; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L9DdwR3j; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FNLrl9m Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id A84234BA5436 for ; Fri, 5 Jun 2026 10:02:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A84234BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A84234BA5436 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780653752; cv=none; b=TbyhXuHVQqEHh2zWQMNOBFcKnk5NL28Q99A0E9iDNKhmzhzVgrlZiPtH9WAhdHF5X0B2Ald/EYtCKOsJTrxm0ga76s1NFaCArb5AYCobP6EENiZjMJGqFNaPWjERyessKrNisHbth8cqoa50+mJcEfNqaFH9zov4KEA/eXTtH3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780653752; c=relaxed/simple; bh=fQpE5KGgYQe8RSr5RJRZehj/a/0cdnekHFRsT+n+DsY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=FUNqtC5dbS0fRSj4J8ghAHDezhDOLDwtJpnU5SODgpIBK3V8vEQrMmzlpq5AN53Nb+cncq3UaFYaM+jRcVLGqETr9AfmcwR9PsUVes42DlgFOUw2+FcLhXxPlHmEfesm6KpOiyWD5Q4JLXwdP4qqvzj/FO5t2Qa1c8SaQGGemtw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L9DdwR3j; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FNLrl9m; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L9DdwR3j; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FNLrl9m DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A84234BA5436 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF55C6B250 for ; Fri, 5 Jun 2026 10:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780653751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u8OMsme+EEwF6mYrBMAdiu+EE9z0sUqEtCcBIAKR27Y=; b=L9DdwR3jLrMmHAJv4MSC+h2q4au0ZDe9tWPkFawMtAZLO8n/w74r7EuFOOg7dVj5Gh1UVW M5hRJhjJHGIBG473xQUTMnpwWXcvZA11Y1dZ2swNI+b/dP9uW3b2n8+ulUDRQcoCrtIFcq wG87YRx7PDuTIPGYMyzm/R29mXRnH0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780653751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u8OMsme+EEwF6mYrBMAdiu+EE9z0sUqEtCcBIAKR27Y=; b=6FNLrl9mPsQjaRLWCAv0IFqxtHDd1L6yZnNUSL4fZg/OdYPpxnvJeLrnZ8ViXspkzVUGJJ o/NiZIDRZdH2ysDA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L9DdwR3j; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6FNLrl9m DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780653751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u8OMsme+EEwF6mYrBMAdiu+EE9z0sUqEtCcBIAKR27Y=; b=L9DdwR3jLrMmHAJv4MSC+h2q4au0ZDe9tWPkFawMtAZLO8n/w74r7EuFOOg7dVj5Gh1UVW M5hRJhjJHGIBG473xQUTMnpwWXcvZA11Y1dZ2swNI+b/dP9uW3b2n8+ulUDRQcoCrtIFcq wG87YRx7PDuTIPGYMyzm/R29mXRnH0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780653751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u8OMsme+EEwF6mYrBMAdiu+EE9z0sUqEtCcBIAKR27Y=; b=6FNLrl9mPsQjaRLWCAv0IFqxtHDd1L6yZnNUSL4fZg/OdYPpxnvJeLrnZ8ViXspkzVUGJJ o/NiZIDRZdH2ysDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9BEA1779AA for ; Fri, 5 Jun 2026 10:02:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +vrUJLeeImo1RwAAD6G6ig (envelope-from ) for ; Fri, 05 Jun 2026 10:02:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Fix Wnon-pod-varargs in bppy_repr Date: Fri, 5 Jun 2026 12:02:31 +0200 Message-ID: <20260605100231.837277-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: AF55C6B250 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I build gdb with clang and ran into a build breaker: ... gdb/python/py-breakpoint.c:1074:52: error: cannot pass object of non-trivial \ type 'const std::string' (aka 'const basic_string') through variadic \ function; call will abort at runtime [-Wnon-pod-varargs] 1074 | return PyUnicode_FromFormat ("<%s (invalid)>", tp_name); | ^ ... This looks like fallout from commit dafd73bcda6 ("gdb/python: fix memory leak in gdb_py_tp_name"), which changed the return type of gdbpy_py_obj_tp_name from const char * to std::string. We could fix this using tp_name.c_str (), but instead fix this by simplifying the code using gdb_py_invalid_object_repr. Tested on x86_64-linux. --- gdb/python/py-breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 30d5ea471c2..ecb42cee5f9 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -1071,7 +1071,7 @@ bppy_repr (PyObject *self) const auto bp = (struct gdbpy_breakpoint_object*) self; if (bp->bp == nullptr) - return PyUnicode_FromFormat ("<%s (invalid)>", tp_name); + return gdb_py_invalid_object_repr (self); std::string str = " "; if (bp->bp->thread != -1) base-commit: 9c8d2849382cca1cb24dc99a8b3da35cb2a334a6 -- 2.51.0