From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EZv8NOXqHmp/3y8AWB0awg (envelope-from ) for ; Tue, 02 Jun 2026 10:38:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JHbNnqV4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D4EF81E062; Tue, 02 Jun 2026 10:38:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6BD231E062 for ; Tue, 02 Jun 2026 10:38:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F25784BA2E1A for ; Tue, 2 Jun 2026 14:38:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F25784BA2E1A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JHbNnqV4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 45F674BA2E2F for ; Tue, 2 Jun 2026 14:36:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45F674BA2E2F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45F674BA2E2F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780410971; cv=none; b=DslDmZTlQ57v/gLKn7WPsVXXv2/knC1dgBCmrQTlj182Cfnpb0+udW2XTbtk78Zc9Nm7XaJnhJSoEU72M4S4uS4iYb/QyShXeh5QarmD8R53WASi0BRKIedRx1mxd58+8eS36Ms/ziyVciLdU8a4+jSXOxgQg5feWybBWZOITxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780410971; c=relaxed/simple; bh=2ji0tEVTOV0fc0j14R04WP0lkhxaU0vhSJ9HCSnubGM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VubOirEZaCAMQcylRfNBjPqpYbIYqL/pY4Lr+Vta8jNFJoJ8i5hRycjiCt5EQnOdUiY3p2nsDeFT51OIWSm/7uEa24v/iQ7FKLsEFFHOURbiLPMf1DxnfYsV1l1iNM+/4fjOaFI7xN42xhBTOIuNqNHQ0QubewGCHYuuuBvo10Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JHbNnqV4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45F674BA2E2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780410970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWc7m2xvl8KO5r3HV+zVOHPOkLJKv6L5aiOZ50S4Rng=; b=JHbNnqV4omw5XzMuO1S0QgahEO3vlZsC6mkwO6IS5OvjLGAmLM40OdwKVpBlfGvIWtUt8C DE8uclqIjJjIfjJoc7+ueNXf4OS6ddkZ9RJ0q6p/1NmXTogYUH5FmkKHHnXTE5CdV3K9aR l0tyVfPkzjbhn/XaimsAGd5yedyClys= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-HEpvu64JNMKN-HQaO4wVxA-1; Tue, 02 Jun 2026 10:36:08 -0400 X-MC-Unique: HEpvu64JNMKN-HQaO4wVxA-1 X-Mimecast-MFC-AGG-ID: HEpvu64JNMKN-HQaO4wVxA_1780410967 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A25B8195608B; Tue, 2 Jun 2026 14:36:07 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.9]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE92D1684; Tue, 2 Jun 2026 14:36:04 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Thiago Jung Bauermann , Eli Zaretskii Subject: [PATCH v4 7/8] gdb/record: Define new version of the record-save section Date: Tue, 2 Jun 2026 11:33:41 -0300 Message-ID: <20260602143342.12245-8-guinevere@redhat.com> In-Reply-To: <20260602143342.12245-1-guinevere@redhat.com> References: <20260602143342.12245-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LIbGq57cWHmhgHNDj75rbFvOa8WhdpVINBC4JBnxzDs_1780410967 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With the changes to the internal representation of the history, we can no longer support the previous record save format. This commit makes it official, documenting the new format and changing the magic number. Reviewed-by: Thiago Jung Bauermann Reviewed-By: Eli Zaretskii --- gdb/NEWS | 4 ++++ gdb/record-full.c | 35 +++++++++++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index 7c8cf9af4c2..4dd3d84c19d 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -51,6 +51,10 @@ * Support for the binary file format dbx has been removed. +* The format for a saved execution record, created when the command + 'record save' is used, has been updated, and previous formats are + no longer supported. + * When connected to an extended-remote target GDB can now automatically set the 'remote exec-file' in some cases. GDB will auto set the remote exec-file only if the remote wasn't started with diff --git a/gdb/record-full.c b/gdb/record-full.c index 0dd4207e0c6..4e8326e1298 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -79,7 +79,8 @@ ((record_full_next_insn != record_full_list.size ()) \ || ::execution_direction == EXEC_REVERSE) -#define RECORD_FULL_FILE_MAGIC netorder32(0x20091016) +#define RECORD_FULL_FILE_MAGIC_OLD netorder32(0x20091016) +#define RECORD_FULL_FILE_MAGIC netorder32(0x20260415) /* These are the core structs of the process record functionality. @@ -2214,6 +2215,27 @@ record_full_core_target::has_execution (inferior *inf) 8 bytes: memory address (network byte order). n bytes: memory value (n == memory length). + Version 3 (all numbers are in network order). + 4 bytes: Magic number (0x20260415). + NOTE: be sure to change whenever this file format changes! + + Records: + record_full_instruction: + 1 byte: signal. + 4 bytes: number of reg and mem entries for this instruction. + 4 bytes: instruction sequence number. + 4 bytes: PC register ID. + N bytes: PC address of instruction (N == size of PC). + Effects: + record_full_reg: + 1 byte: record_type (record_full_reg, see enum record_full_type). + 4 bytes: Register ID. + n bytes: register value (n == actual register size). + record_full_mem: + 1 byte: record_type (record_full_mem, see enum record_full_type). + 4 bytes: memory length. + 8 bytes: memory address. + n bytes: memory value (n = memory length). */ /* bfdcore_read -- read bytes from a core file section. */ @@ -2409,9 +2431,14 @@ record_full_restore (struct bfd &cbfd) /* Check the magic code. */ bfdcore_read (&cbfd, osec, &magic, sizeof (magic), &bfd_offset); if (magic != RECORD_FULL_FILE_MAGIC) - error (_("Version mismatch or file format error in core file %ps."), - styled_string (file_name_style.style (), - bfd_get_filename (&cbfd))); + { + if (magic == RECORD_FULL_FILE_MAGIC_OLD) + error (_("This old recording format is no longer supported.")); + else + error (_("Version mismatch or file format error in core file %ps."), + styled_string (file_name_style.style (), + bfd_get_filename (&cbfd))); + } if (record_debug) gdb_printf (gdb_stdlog, " Reading 4-byte magic cookie " -- 2.54.0