From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id be4XGjPdGmpoWCkAWB0awg (envelope-from ) for ; Sat, 30 May 2026 08:50:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HpqQlXUj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qwLDvQyc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xVomf1hr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ktD3DaOV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 594401E0A3; Sat, 30 May 2026 08:50:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7002B1E062 for ; Sat, 30 May 2026 08:50:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B33E04BA799A for ; Sat, 30 May 2026 12:50:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B33E04BA799A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HpqQlXUj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qwLDvQyc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xVomf1hr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ktD3DaOV Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 2E92A4BA23FE for ; Sat, 30 May 2026 12:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E92A4BA23FE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2E92A4BA23FE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780145430; cv=none; b=I7Z/tOxh2i25BNY5B9TihVRWcwGJJ//siqu4G4xS2LJqSCpIN8YGhK7cSI8vI7hsPBn5DS6lMRSkASZEsWQqhStBy6XCxDM2SqmjNtxbX0Y+hTPGNS+aD1h5AdETmHd7YZzt3Q5O+7vL+rDI5fHNuTNbUS54jPDUTYkgGakX9/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780145430; c=relaxed/simple; bh=XCWbuVK/OxNmPNDx5huaZl05F71bc736xc+QN3Guddo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=t/3RzykoK4GcnFgOGdUFdryZfs2STwessuJx6vqPkEFTYFbc14tPN/Hb/M8NsNw4+1qJkUgsGDNif6hxJD0OuWuNDDw9zKT9lw+M1tPQPm8AG5LLE3CFRdjwy0AblszR1M6Wumje+GsOfDhqPkhSZLs7zkgdHgXYM25CEwRusNg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HpqQlXUj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qwLDvQyc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xVomf1hr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ktD3DaOV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E92A4BA23FE Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C8B986BA03 for ; Sat, 30 May 2026 12:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780145429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ez3HDH2C2WE5L3zTboQLttjai612NOvtSvFZqXXNUSs=; b=HpqQlXUjxa7ytxt5GD4dFvrE5VIDZwDcCBorBpNh+phJ0NtBQAUBrSvxEGnQ+aQBQFqIC3 mWktXP0SIYS7dTcetAO4MQil0NJextXdc9O3HbkFZGhC0X0TzYIwnOOybVo92StFXZs7Pc YsKR/97SI8adZspduBUDFSBHevvgCK4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780145429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ez3HDH2C2WE5L3zTboQLttjai612NOvtSvFZqXXNUSs=; b=qwLDvQycjORumUV482M5Ve+kMD2uHP/ATHNVy1b5A6jqxGVI2YF0NWq3iHj5xp9WlW9uzQ /QByY2E9Z6LzrxDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xVomf1hr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ktD3DaOV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780145428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ez3HDH2C2WE5L3zTboQLttjai612NOvtSvFZqXXNUSs=; b=xVomf1hrBX6Pa16lHt1aU+RCQuQwwHBfnqJPJYNvUnbKNkOgfpyX+oOtDYe0T0R/R3RXyP 5svKJgVg0IoVWCRQ05rZNrc8YfJj+ul9qyfFhzxI3YhgORrY6gHJWo73ONUT0SipyaGzsJ sQvtVGgEaOmFuilLcSA6TEa04D9qaLc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780145428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ez3HDH2C2WE5L3zTboQLttjai612NOvtSvFZqXXNUSs=; b=ktD3DaOVcf/QSNEgmWC8umOjoGENQXBbbQ1Sm9kmdvNSY+EFSxJD6dJp1oDqLV0u49ZyLz rBnGzhCt3Un0qdDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B3F52779A7 for ; Sat, 30 May 2026 12:50:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6g2LKhTdGmqTfAAAD6G6ig (envelope-from ) for ; Sat, 30 May 2026 12:50:28 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/symtab] Revert "Add assert in free_cached_comp_units constructor" Date: Sat, 30 May 2026 14:50:28 +0200 Message-ID: <20260530125028.1823106-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: C8B986BA03 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This reverts commit b083976272bd663ed036692e54796870b3bf6c89. The new assert triggers in test-cases gdb.ada/uninitialized-variable-record.exp and gdb.ada/uninitialized_vars.exp on x86_64-linux. --- gdb/dwarf2/read.c | 3 --- gdb/dwarf2/read.h | 6 ------ 2 files changed, 9 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 0d313f62f4a..742be7656b1 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -902,9 +902,6 @@ class free_cached_comp_units explicit free_cached_comp_units (dwarf2_per_objfile *per_objfile) : m_per_objfile (per_objfile) { - /* The destructor frees all cached comp units, including ones currently - cached, so check that there are no currently cached comp units. */ - gdb_assert (m_per_objfile->nr_of_cus () == 0); } ~free_cached_comp_units () diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h index 603fe089d6a..15dd2abf3a1 100644 --- a/gdb/dwarf2/read.h +++ b/gdb/dwarf2/read.h @@ -969,12 +969,6 @@ struct dwarf2_per_objfile /* Free all cached compilation units. */ void remove_all_cus (); - /* Return the number of cached compilation units. */ - size_t nr_of_cus () const - { - return m_dwarf2_cus.size (); - } - /* Increase the age counter on each CU compilation unit and free any that are too old. */ void age_comp_units (); base-commit: 44df4c640694765fc028bdb0c64d346638466eab -- 2.51.0