From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WWH5GgSMGWru8iYAWB0awg (envelope-from ) for ; Fri, 29 May 2026 08:52:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p8qTu7N6; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q8WdD9Gf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Bn4rZURw; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QX12uVl5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 67EC71E0A3; Fri, 29 May 2026 08:52:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AEAA61E062 for ; Fri, 29 May 2026 08:52:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 358694BA23E0 for ; Fri, 29 May 2026 12:52:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 358694BA23E0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p8qTu7N6; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q8WdD9Gf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Bn4rZURw; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QX12uVl5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 5EF924BA2E2E for ; Fri, 29 May 2026 12:51:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5EF924BA2E2E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5EF924BA2E2E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780059112; cv=none; b=URNRp9x0+tINTeIO2PqnhCExBIvS+OIPM30+4ZM2DuEynQEZQvOh+jdEpOMd+JqMIYDPj5PQZRRUv36TFPHGaCQjgM1AFYZXJWvdwZ7JVTp0MKBTguAfEbeuRrxhk/P8P8UIArhRVx4B16EAVtKZ2AhSM72FrWKmex3ErXNqdK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780059112; c=relaxed/simple; bh=/u/ZeNlMZx0X92P6g5PYlaH7RhXJR5UqNU8CMQzIJt4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=KK5zbfHnMjdsLPuKflx+z3ZSLbyTWm5MdmMq3Foi1JRNQ3Ceayku9yQlKuGTS7IZBgbJuJACL4CrXXewYzNW3VcTXx2P1/qh/H2OhihmER4vfpAhkN44bAwU+CWYg7k2vXHS0RMHzuJvp4Sgz0/Fy222T/0leaYbG3WuPS0b7MQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p8qTu7N6; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q8WdD9Gf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Bn4rZURw; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QX12uVl5 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5EF924BA2E2E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 334866AD6B for ; Fri, 29 May 2026 12:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780059111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7p1hXD0CjIXvx8DpwyfBeutA7k48xjAs+iRwRIx/Js=; b=p8qTu7N6ouIGIJ4JoMoTb7PFjr2FflAfPJY+rqmpA1mNk6DLBu27aOtuNwNx060b12rJsv k6yqfrst3IFAVJ5y2UyGWwKsFNQKpHlnAtOifDWS0VfTsBv3HTWQmT7q464Y8iV9CmwI0Y 2Ma/GZv+puPBIlNmfxyvJ4D7U2tijho= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780059111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7p1hXD0CjIXvx8DpwyfBeutA7k48xjAs+iRwRIx/Js=; b=q8WdD9GfZ1Vf4rbzd6YH5Gkx95Fm+aklwRZcSzfYnRL+/bDM1F8agO5uFPUU9zrnLYUieX ekXmVhtp0h/eyxCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Bn4rZURw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QX12uVl5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780059110; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7p1hXD0CjIXvx8DpwyfBeutA7k48xjAs+iRwRIx/Js=; b=Bn4rZURw/AzbqOyOD7aYalaTQpApKJD+Z2lPnYI3tljIfH2/8AZw33Qq7aBoikRO8FBoyK jnT/8XqCjL5ubRydP/t+UaIUiWD0LKVswDv2PC+fzDlOaNFnXCvZFihJ3bVggVmVbhYjo6 ai2dUxm6Q7mct8T6RcKUJyZWkERn2Kw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780059110; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7p1hXD0CjIXvx8DpwyfBeutA7k48xjAs+iRwRIx/Js=; b=QX12uVl5Jvty7TWDO21ywIbd6iqtwkdMeXvilAB06sYsCJ9vLFNncqvBlLHeHBnEZ3s2jb yl3Uq2bRwMoUGLCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1F19D779A8 for ; Fri, 29 May 2026 12:51:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eHZCBuaLGWocIQAAD6G6ig (envelope-from ) for ; Fri, 29 May 2026 12:51:50 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/2] [gdb/testsuite] Fix ambiguous operator warning Date: Fri, 29 May 2026 14:51:48 +0200 Message-ID: <20260529125149.2027857-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260529125149.2027857-1-tdevries@suse.de> References: <20260529125149.2027857-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 334866AD6B X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,sourceware.org:url,suse.de:dkim,suse.de:mid]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With gcc 16, defaulting to c++20, and test-case gdb.cp/cmpd-minsyms.exp I run into: ... cmpd-minsyms.cc: In function 'int main(int, char**)':^M cmpd-minsyms.cc:39:13: warning: C++20 says that these are ambiguous, even \ though the second is reversed:^M 39 | if (a == b)^M | ^^M cmpd-minsyms.cc:26:8: note: candidate 1: 'int GDB::operator==(const GDB&) [with T = int]'^M 26 | int operator == (GDB const& other)^M | ^~~~~~~~^M cmpd-minsyms.cc:26:8: note: candidate 2: 'int GDB::operator==(const GDB&) [with T = int]' (reversed)^M cmpd-minsyms.cc:26:8: note: try making the operator a 'const' member function^M ... Fix this by following the advice: ... - int operator == (GDB const& other) + int operator == (GDB const& other) const { return 1; } ... Likewise in gdb.cp/many-args.exp. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34187 --- gdb/testsuite/gdb.cp/cmpd-minsyms.cc | 2 +- gdb/testsuite/gdb.cp/cmpd-minsyms.exp | 2 +- gdb/testsuite/gdb.cp/many-args.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.cp/cmpd-minsyms.cc b/gdb/testsuite/gdb.cp/cmpd-minsyms.cc index 504dfec0f9c..afef5d7dcd4 100644 --- a/gdb/testsuite/gdb.cp/cmpd-minsyms.cc +++ b/gdb/testsuite/gdb.cp/cmpd-minsyms.cc @@ -23,7 +23,7 @@ class GDB static int harder (T a) { return 1; } template static X even_harder (T a) { return static_cast (a); } - int operator == (GDB const& other) + int operator == (GDB const& other) const { return 1; } void a (void) const { } void b (void) volatile { } diff --git a/gdb/testsuite/gdb.cp/cmpd-minsyms.exp b/gdb/testsuite/gdb.cp/cmpd-minsyms.exp index 19653a4ccc9..ccd7f5d692a 100644 --- a/gdb/testsuite/gdb.cp/cmpd-minsyms.exp +++ b/gdb/testsuite/gdb.cp/cmpd-minsyms.exp @@ -48,7 +48,7 @@ gdb_test_no_output "set language c++" # of the minimal symbol. set min_syms [list \ "GDB::operator ==" \ - "GDB::operator==(GDB const&)" \ + "GDB::operator==(GDB const&) const" \ "GDB::harder(char)" \ "GDB::harder(int)" \ {"int GDB::even_harder(char)"} \ diff --git a/gdb/testsuite/gdb.cp/many-args.cc b/gdb/testsuite/gdb.cp/many-args.cc index b5685b13c47..8c8805297f7 100644 --- a/gdb/testsuite/gdb.cp/many-args.cc +++ b/gdb/testsuite/gdb.cp/many-args.cc @@ -26,7 +26,7 @@ struct ss unsigned char aa; - bool operator== (const ss &rhs) + bool operator== (const ss &rhs) const { return (memcmp (&this->static_field, &rhs.static_field, sizeof (this->static_field)) == 0 -- 2.51.0