From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zKrzI4XvEmpsrhQAWB0awg (envelope-from ) for ; Sun, 24 May 2026 08:31:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MRiZTKB/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DpHL46KO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AiCoH9Bf; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ETQHMAwq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7B4351E0A3; Sun, 24 May 2026 08:31:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB1CD1E062 for ; Sun, 24 May 2026 08:30:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C8894B99F53 for ; Sun, 24 May 2026 12:30:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C8894B99F53 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MRiZTKB/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DpHL46KO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AiCoH9Bf; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ETQHMAwq Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D29B34B9DB75 for ; Sun, 24 May 2026 12:30:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D29B34B9DB75 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D29B34B9DB75 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779625824; cv=none; b=ts0haFBExCZcvBMHccA+qbXIdSsX0GvyB2jb+6b6MlP0UDaYFm69LX3tduB+Xs22nnPsdpv2+knzoNgKcvqqDGoNbvsqtBLjbTtWl51t2XaT/N2ns0E4oQ32khVuG2jdbFVps9+2Wjo9tjGll9OY4ul1A/ikXn+W5o0zMtixjdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779625824; c=relaxed/simple; bh=Fy7lFBmJGsY1DZRtqOsgsu1vsiDquDiKQKRs7/dGd6w=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=u/JAk/nzlb4IjWExZUzD8g/UyAAQZyYV4BIYEFZYr3rHgxv/UCF071DaeIA9yDbWc2PjQScSAhHZZ9wTx+ne7g+CFyaFbSNVzUJ0pIf6xpEpQQ7dw6LQ27UfYiQ5y9dokibFDxHudMrw8sdmHXpJzrnLgnfNmkB1OARiQROU8Ts= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MRiZTKB/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DpHL46KO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AiCoH9Bf; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ETQHMAwq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D29B34B9DB75 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F0C3F6B029 for ; Sun, 24 May 2026 12:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779625823; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HjsgjAvxcpXyW62Gpf9EbRzVTo5YuGABkEaMRAq2+wI=; b=MRiZTKB/2mAaapuo/82Hn11XnPHuwCNokyd/hxpXc5+kcmnWG2j42LMqhFHc06PU+tw7mz 4svp1jRBzpCMPM+BbtCY9Kb/8aDljx2fjW89YjuTjNAr+BOygVJv++DL1irvg//qBwisUh wKhFaqb2Lk7SSnbf2ADDmFyNjN6TwpM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779625823; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HjsgjAvxcpXyW62Gpf9EbRzVTo5YuGABkEaMRAq2+wI=; b=DpHL46KOmIycRqtwBvv1W5DhGsGquKpEZsRhnL3IVmcskt/LLEnwmgQZ299gjoppp01vXf Cgx/UM7riCs4JWAw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779625822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HjsgjAvxcpXyW62Gpf9EbRzVTo5YuGABkEaMRAq2+wI=; b=AiCoH9BfvFItV5YTtQW3gj/BMzAHpLQ/DA4/Gz3f7pR6Q9sUhPMg3736nzfgc2MaMgRdae dTa6oLBjR2G45EV/+LLJGcJ6IEI9O+lnSUNKj3dXIs/0+OuWjoiN0iAxW11aOXaPflEPCg kOUnjSIrYH//iZ3/hZEoZ+dMMqQcrRw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779625822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HjsgjAvxcpXyW62Gpf9EbRzVTo5YuGABkEaMRAq2+wI=; b=ETQHMAwqVbTkt7B7+1ngdky+fFOI5d4cNzxb0OBcHBkDgaWBtGIbRg5c7MMuFUczmNWboB wHsUr5ro+BXUU6DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DAD49596A2 for ; Sun, 24 May 2026 12:30:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E5r+M17vEmobdAAAD6G6ig (envelope-from ) for ; Sun, 24 May 2026 12:30:22 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/python] Boolify gdb_python_initialized Date: Sun, 24 May 2026 14:30:22 +0200 Message-ID: <20260524123022.1211375-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; internal_greylist_whitelist(0.00)[10.150.64.97]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that while gdb_python_initialized is an int, there's also an assignment using false: ... gdb_python_initialized = false; ... Fix this by converting gdb_python_initialized to bool type. --- gdb/python/python-internal.h | 2 +- gdb/python/python.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 82f3262ae07..10c984bad4b 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -330,7 +330,7 @@ struct program_space; struct bpstat; struct inferior; -extern int gdb_python_initialized; +extern bool gdb_python_initialized; extern PyObject *gdb_module; extern PyObject *gdb_python_module; diff --git a/gdb/python/python.c b/gdb/python/python.c index fd254a340d8..e6d58f2f16a 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -82,7 +82,7 @@ static const char *gdbpy_should_print_stack = python_excp_message; /* True if Python has been successfully initialized, false otherwise. */ -int gdb_python_initialized; +bool gdb_python_initialized; extern PyMethodDef python_GdbMethods[]; @@ -2796,7 +2796,7 @@ do_start_initialization () PyEval_SaveThread (); /* Only set this when initialization has succeeded. */ - gdb_python_initialized = 1; + gdb_python_initialized = true; return true; } @@ -2819,7 +2819,7 @@ test_python () bool saw_exception = false; { scoped_restore reset_gdb_python_initialized - = make_scoped_restore (&gdb_python_initialized, 0); + = make_scoped_restore (&gdb_python_initialized, false); try { CMD (output); @@ -3123,7 +3123,7 @@ gdbpy_initialize (const struct extension_language_defn *extlang) static int gdbpy_initialized (const struct extension_language_defn *extlang) { - return gdb_python_initialized; + return gdb_python_initialized ? 1 : 0; } PyMethodDef python_GdbMethods[] = base-commit: c5590002d8ee23c8ee3d64803e4e03c5992903c1 -- 2.51.0