From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0VjjDFxqEGr3Ug8AWB0awg (envelope-from ) for ; Fri, 22 May 2026 10:38:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ctK8j88q; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ThF5eOsl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ctK8j88q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ThF5eOsl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 30B2B1E024; Fri, 22 May 2026 10:38:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6B2A1E024 for ; Fri, 22 May 2026 10:38:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C75548F3408 for ; Fri, 22 May 2026 14:38:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C75548F3408 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ctK8j88q; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ThF5eOsl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ctK8j88q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ThF5eOsl Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 3E85D48F36B3 for ; Fri, 22 May 2026 14:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E85D48F36B3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E85D48F36B3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779460671; cv=none; b=f1FrE7vZuZuh7V8YqOKZMTwT/5AnTGGquNandnKOfhoykrhhVdunJyX7khGzN25A/OT7TIKltgpS5LZjNCPseP+a3q4dBUKTBk7qnAYeAQ6P+mToLXltjAQ43YHjipA+4mvtx9gFL8DbRYivy5OY9IbexgsZB1/qR/0LIlpoAI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779460671; c=relaxed/simple; bh=c7FgNgMDNzJ9MYVIlFaJ+pJO48Yuo3jX5NBfHIeY/nQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=MQjAEX6zvRU662MBI14zWMw9CL5q4BV5xVsVaKDUVuH/D8QbmTGUfF8Rtj7bMbe0w/oiRKsErF1AI+62mYg3avBKeEPIPvV99FbT81lQEoamdBkQRKazR2jR1xRkgsIqFGT7zQzXLGW0l3zgTRRdffhBci+pPB4gqnUtNjzLzAM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ctK8j88q; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ThF5eOsl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ctK8j88q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ThF5eOsl DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E85D48F36B3 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 046E867424 for ; Fri, 22 May 2026 14:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779460659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYYUmP81VV9XfbAKKzhgFcMn2ZWU1MdMJwPkt+w1F4I=; b=ctK8j88qkx/VGTrJoBmZIqLlKqVTbP/4V4G/BGaTqQbiRSQzBVelXKfrvWwImU2PvLguaY q8RHUWtiEuHVVjx/kMlpAhMLlApaxqgGY4yRNbsFTlxmMigDQdJprpA1JMW9AiKu35L4yJ I9mPbevGkYJKy+WQkIwcPbDJH3x/WuQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779460659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYYUmP81VV9XfbAKKzhgFcMn2ZWU1MdMJwPkt+w1F4I=; b=ThF5eOslx4iNlfQUTSnfRBZzZxiWfEllClS1Wcnqa7+XyTIMi/dnt1m86txQCJCFCcZAsE UiXiApfvnfnQQpDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ctK8j88q; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ThF5eOsl DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779460659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYYUmP81VV9XfbAKKzhgFcMn2ZWU1MdMJwPkt+w1F4I=; b=ctK8j88qkx/VGTrJoBmZIqLlKqVTbP/4V4G/BGaTqQbiRSQzBVelXKfrvWwImU2PvLguaY q8RHUWtiEuHVVjx/kMlpAhMLlApaxqgGY4yRNbsFTlxmMigDQdJprpA1JMW9AiKu35L4yJ I9mPbevGkYJKy+WQkIwcPbDJH3x/WuQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779460659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYYUmP81VV9XfbAKKzhgFcMn2ZWU1MdMJwPkt+w1F4I=; b=ThF5eOslx4iNlfQUTSnfRBZzZxiWfEllClS1Wcnqa7+XyTIMi/dnt1m86txQCJCFCcZAsE UiXiApfvnfnQQpDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E1BCE593A8 for ; Fri, 22 May 2026 14:37:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gM+JNTJqEGqTdAAAD6G6ig (envelope-from ) for ; Fri, 22 May 2026 14:37:38 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 4/4] [gdb/testsuite] Improve dwarf assembly for implicit const in .debug_names Date: Fri, 22 May 2026 16:37:37 +0200 Message-ID: <20260522143737.3373000-5-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260522143737.3373000-1-tdevries@suse.de> References: <20260522143737.3373000-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 046E867424 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In the assembly generated for the dwarf assembly for test-case gdb.dwarf2/debug-names-tu-dwarf5.exp, there's this bit: ... .uleb128 0x2003 /* DW_IDX_GNU_language */ .uleb128 0x21 /* DW_FORM_flag_present */ .sleb128 0x0002 /* DW_LANG_C */ ... As it happens, 0x21 is not DW_FORM_flag_present, but DW_FORM_implicit_const, and the following entry is the value of the attribute. Fix the comment, and make the relation between the two entries more clear by printing: ... .uleb128 0x2003 /* DW_IDX_GNU_language */ .uleb128 0x21 /* DW_FORM_implicit_const */ .sleb128 0x0002 /* DW_FORM_implicit_const value: DW_LANG_C */ ... --- gdb/testsuite/lib/dwarf.exp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp index 5358dc317a1..9575f4b0b1c 100644 --- a/gdb/testsuite/lib/dwarf.exp +++ b/gdb/testsuite/lib/dwarf.exp @@ -3636,8 +3636,9 @@ namespace eval Dwarf { _op .uleb128 $_constants(DW_IDX_GNU_language) \ "DW_IDX_GNU_language" _op .uleb128 $_constants(DW_FORM_implicit_const) \ - "DW_FORM_flag_present" - _op .sleb128 $_constants($word) $word + "DW_FORM_implicit_const" + _op .sleb128 $_constants($word) \ + "DW_FORM_implicit_const value: $word" } else { error "unrecognized extra keyword $word" } -- 2.51.0