From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6xIpFNZED2o0GQ0AWB0awg (envelope-from ) for ; Thu, 21 May 2026 13:45:58 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=TbQ4yIHA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 35BD21E091; Thu, 21 May 2026 13:45:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 73B121E024 for ; Thu, 21 May 2026 13:45:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 35B9A48F66D0 for ; Thu, 21 May 2026 17:45:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35B9A48F66D0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=TbQ4yIHA Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 7E0534BABF32 for ; Thu, 21 May 2026 17:45:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E0534BABF32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E0534BABF32 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779385533; cv=none; b=sjvq33gU7iIXYDKpkx/jYXLMePqOoUDcatRJm5WShBVmAMKTUSG0hNmhkEoE+AzVl1Dnw+BcOcBD44n4/aUjzi1Wo9D7a3jDuCCvIrXZT69IE/VB63oHyAklOR0X0axhKeSJ/WiiZCM9gPDwJ0QZwMiDsfxqsFnS/VEcNhB2q2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779385533; c=relaxed/simple; bh=Hr1nAmpAHQc2MbF3ZKqjErsfHAKi40CVsFS0lfFXWtE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qV76Ffg8v9nvtolEfmJFD7SyHFPBpI76n+J1IHc2j1byQD4jS+tpRKnXLEyIXXWuLGlYiCgU8Hl3q4TF9DpicHlwYOAC0isVUG5z1xSOxVN6YU2KO85tMxmtUpyKBEmPdMILpYvEAPdbdKSF4xwC9qrYzImkDURWn7Oqc+q7fXU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=TbQ4yIHA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E0534BABF32 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7e55b95ba13so3631532a34.3 for ; Thu, 21 May 2026 10:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1779385532; x=1779990332; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+fqe4GIMdeXYuLpGRM0rkPvfIc1u0qPEEkboOb8hnr8=; b=TbQ4yIHAcvmp2Ai3Q74WHtMeqRCSOoWHS9O1AiIs63me5venYPgrjaXZDlYmQPITRL 6LqosULo4mvUYraJvXx/avOVIJGSNaGMti5MW/3Yz020hAx8QHR7DHt9k0T+hTDcOKCO bNfseCpGSVvi1lo5z8r0Wx/zzsB/NwFH9gj1Lf7Df+2RwCy+BOsdUVtNxAdHKRtsptzF JlKfXulBiYKBBwcPb5hOUZDEcPCBvM6joAooASa2le2j63AMageWV8Kt8IYnNzV9Jo29 TbuUN1LJ2QYwuz/HquY+s5kLjtsF5hFg2ir0g5/evqWFNSJk1CZU/CAdTrfxBSZgLycq 7CLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779385532; x=1779990332; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+fqe4GIMdeXYuLpGRM0rkPvfIc1u0qPEEkboOb8hnr8=; b=qE3RvzJ8ae6SD41GsGm9jcuFx27KHCO2j1nGBUKByvl7tOmUynyvi8FWLIXZFB2QVY W/R9iCpATZhcoeCSCIfOdyNl3Q17wkkyQNUR5bDICVXgqjCxHgXsnjj1r567Rb6m/RrT B6X7aFvzCZfu5u+yQpujwoxD8sC3wAQD5YMwngMxmgvSWQHH5PWkah8AWvnF4ruw0HMR Rk1P0DOdqkiO2hRam1f76st4JOZVaCuzrRQ1f95C8OAxLexH9jIZLVwvScDP9upnT0Uy KSFsa9V+eqnxFAWB00l0ZTdaD+JUiH/y2pXYocZuvFvp8NBi9d5jdgvnEQOLTUEJ9NsK Ijog== X-Gm-Message-State: AOJu0Yw0eOSQsmS1qHfkbebT0DrLt7U+loOX2FcXa3yEgDRDrg83iibI LtL21BbRdXWh8xsL9zXE/SrsGKMxpo4FrVrFpgo+32RXL45VAkqHOjTgNBvru8NusgcBaSFUIis NDlw= X-Gm-Gg: Acq92OEooqwae++coJaHjk3VUQilG8wa+0R2/sM3TAtNGheMXDUDgwtafUgDInNhnes Z8fGQB1PIV87gDR6SRkhIvKNWwvjwL6ulJ+ISspy91svagcyhajGzYRA+fo/kkdnYcb8wmjqLao oOXg9rwhYeRxMYkO6C8ABSgFQLQWe51+R4OntlniRhBmndtYGTzuAehWyXfsHvg+r15AEqhSaSb MoNEfVe0ROTiWszvImT7bipcfPWZJq7X2rfUcQGPAOUaIl02COmslpaOOvjdjZpYngGfbsg1usc wnIJkl1/ME6IS7QHcNTMEdMueskyrKvirLTQ5DuvVfUV2rov3Qa148W/wfaxFT13udMbcYijkWS ajZh/vxd2QRIvgFDEurkwRY+7k/GaeG1QdygMYX1gtM6cAM4YeDxxUrBzXBOzJkFsuU1/oh6+48 NzPZ1VA0OAAr+otaf2wlC3R11GJmho96KB92EHRUsFoO8= X-Received: by 2002:a05:6830:4193:b0:7e5:68c3:6246 with SMTP id 46e09a7af769-7e5fedc772emr102373a34.10.1779385532463; Thu, 21 May 2026 10:45:32 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e5f6e78c32sm853735a34.13.2026.05.21.10.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 10:45:31 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Andrew Burgess , Tom Tromey Subject: [PATCH] Use gdb::Requires in gdb::ref_ptr Date: Thu, 21 May 2026 11:45:27 -0600 Message-ID: <20260521174527.2962256-1-tromey@adacore.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Andrew pointed out that the use of is_convertible in gdb::ref_ptr is incorrect, and that it should instead check the value. This can easily be done using gdb::Requires. --- gdbsupport/gdb_ref_ptr.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gdbsupport/gdb_ref_ptr.h b/gdbsupport/gdb_ref_ptr.h index 0eb654324c6..757c3f395ba 100644 --- a/gdbsupport/gdb_ref_ptr.h +++ b/gdbsupport/gdb_ref_ptr.h @@ -21,6 +21,7 @@ #define GDBSUPPORT_GDB_REF_PTR_H #include +#include "gdbsupport/traits.h" namespace gdb { @@ -76,7 +77,7 @@ class ref_ptr /* Copy another instance. */ template> + typename = gdb::Requires>> ref_ptr (const ref_ptr &other) : m_obj (other.m_obj) { @@ -93,7 +94,7 @@ class ref_ptr /* Transfer ownership from OTHER. */ template> + typename = gdb::Requires>> ref_ptr (ref_ptr &&other) noexcept : m_obj (other.m_obj) { @@ -115,7 +116,7 @@ class ref_ptr /* Copy another instance. */ template> + typename = gdb::Requires>> ref_ptr &operator= (const ref_ptr &other) { /* Note that self-assignment is not checked here, as it isn't @@ -141,7 +142,7 @@ class ref_ptr /* Transfer ownership from OTHER. */ template> + typename = gdb::Requires>> ref_ptr &operator= (ref_ptr &&other) { /* Note that self-assignment is not checked here, as it isn't base-commit: ea27a7ae9048367bde15246b248f856803efc674 -- 2.54.0