From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aed8Bl5NB2pflz0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 12:44:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KSKEP7iz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 157B51E0B1; Fri, 15 May 2026 12:44:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 017BF1E067 for ; Fri, 15 May 2026 12:44:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9360640A00CD for ; Fri, 15 May 2026 16:44:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9360640A00CD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KSKEP7iz Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 3105F4C31849 for ; Fri, 15 May 2026 16:39:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3105F4C31849 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3105F4C31849 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778863156; cv=none; b=wboJ1E9yI0Hi3+ZwJGpMY7WXwapCBkbYz/DH43sxGx69f5NjuCEiTEPHssJl0/lAaHtEBAX5qWQvak8VBQOYeV7SQRcCa/22A9GxDS5hB8NYRLKMr203N21Nosl8AiP2d4FJ0KJ2xkESl2Mhguwsq0R9X04gGFqv8MEXO8rvSsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778863156; c=relaxed/simple; bh=0zwnpnWpJt5H93ms0TtavU4lyZ4bcZYxJtIOYqRQ1ng=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UeCQAMPUIUJwGSHin1UhjYk4vaG7UWy4VJijulc/8xW9wSLHIJLUB1ui0YY0mFm1+ipWMn2TJ8FMzNMVQnd2D6gLXSD0VCyPMJ4djnFbjyjN+R6DRGBYq4pScHSoRhzfJOxKb4MQDGHSqs94KJPmikFTHBdG98WIm7wTGD0+PcQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KSKEP7iz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3105F4C31849 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778863155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/2HgKUTpQWge7upEpXh4FZY89Lxl9SjOw93DHMs9mC8=; b=KSKEP7izH+g6XiLY1h9LGw+lwL7oFPCPVf/DtgMnJ8bAR+Th06TLumd1S9btoMEQ4TCtlo yZoGlGlCwX7hHD+HQGPailmNrhbjR6idUfIr02iW4kL8aW8HjL/VRHWl2B7u1293V70w5y bV+vS4vnwaV3u9ZEXzIYMJMJ+v1BHtU= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-Z98JyIrYO3WSqK6X2NhfpA-1; Fri, 15 May 2026 12:39:14 -0400 X-MC-Unique: Z98JyIrYO3WSqK6X2NhfpA-1 X-Mimecast-MFC-AGG-ID: Z98JyIrYO3WSqK6X2NhfpA_1778863153 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 42856195605C for ; Fri, 15 May 2026 16:39:13 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.23]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C05241955F2D; Fri, 15 May 2026 16:39:11 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: [PATCH v3 7/7] gdb/record: rename record_full_list to record_full_log Date: Fri, 15 May 2026 13:37:06 -0300 Message-ID: <20260515163706.3355686-10-guinevere@redhat.com> In-Reply-To: <20260515163706.3355686-1-guinevere@redhat.com> References: <20260515163706.3355686-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pQ5WyS4vXRc2-FJnrzpDccTDGE_ieI-CLZBpcV5iEDE_1778863153 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Now that we no longer use a linked list to manage the history, the name "record_full_list" is no longer meaningful. This commit changes the name to record_full_log since it is the execution log. I decided to not say "record_full_execution_log" to avoid overly long lines when accessing it. --- gdb/record-full.c | 120 +++++++++++++++++++++++----------------------- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/gdb/record-full.c b/gdb/record-full.c index 055d2c66346..3c63753d24e 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -76,7 +76,7 @@ #define DEFAULT_RECORD_FULL_INSN_MAX_NUM 200000 #define RECORD_FULL_IS_REPLAY \ - ((record_full_next_insn != record_full_list.size ()) \ + ((record_full_next_insn != record_full_log.size ()) \ || ::execution_direction == EXEC_REVERSE) #define RECORD_FULL_FILE_MAGIC_OLD netorder32(0x20091016) @@ -446,7 +446,7 @@ static struct record_full_core_buf_entry *record_full_core_buf_list = NULL; /* The following variables are used for managing the history of executed instructions from the inferior. - record_full_list contains all instructions that were fully executed and + record_full_log contains all instructions that were fully executed and saved to the log, so that we can replay the execution. record_full_next_insn always points to the next instruction that would @@ -459,7 +459,7 @@ static struct record_full_core_buf_entry *record_full_core_buf_list = NULL; happening. It is manipulated by the "arch list" functions for historical reasons. */ -static std::deque record_full_list; +static std::deque record_full_log; static record_full_instruction record_full_incomplete_instruction; static int record_full_next_insn; @@ -665,14 +665,14 @@ record_full_reset_history () record_full_insn_count = 0; record_full_next_insn = 0; - record_full_list.clear (); + record_full_log.clear (); } static void -record_full_list_release_following (int index) +record_full_log_release_following (int index) { - for (int i = record_full_list.size () - 1; i > index; i--) - record_full_list.pop_back (); + for (int i = record_full_log.size () - 1; i > index; i--) + record_full_log.pop_back (); /* Set the next instruction to be past the end of the log so we start recording if the user moves forward again. */ record_full_next_insn = index; @@ -686,7 +686,7 @@ record_full_save_instruction () ++record_full_insn_count; record_full_incomplete_instruction.insn_num = record_full_insn_count; record_full_incomplete_instruction.effects.shrink_to_fit (); - record_full_list.push_back (std::move (record_full_incomplete_instruction)); + record_full_log.push_back (std::move (record_full_incomplete_instruction)); record_full_next_insn++; record_full_reset_incomplete (); @@ -696,12 +696,12 @@ record_full_save_instruction () room for adding a new instruction at the end of the log. */ static void -record_full_list_release_first (void) +record_full_log_release_first (void) { - if (record_full_list.empty ()) + if (record_full_log.empty ()) return; - record_full_list.pop_front (); + record_full_log.pop_front (); --record_full_next_insn; } @@ -765,7 +765,7 @@ record_full_arch_list_add_mem (CORE_ADDR addr, int len) static void record_full_check_insn_num (void) { - if (record_full_list.size () == record_full_insn_max_num) + if (record_full_log.size () == record_full_insn_max_num) { /* Ask user what to do. */ if (record_full_stop_at_limit) @@ -781,9 +781,9 @@ record_full_check_insn_num (void) /* Before inferior step (when GDB record the running message, inferior only can step), GDB will call this function to record the values to - record_full_list. This function will call gdbarch_process_record to + record_full_log. This function will call gdbarch_process_record to record the running message of inferior and set them to - record_full_arch_list, and add it to record_full_list. */ + record_full_arch_list, and add it to record_full_log. */ static void record_full_message (struct regcache *regcache, enum gdb_signal signal) @@ -821,8 +821,8 @@ record_full_message (struct regcache *regcache, enum gdb_signal signal) if we delivered it during the recording. Therefore we should record the signal during record_full_wait, not record_full_resume. */ - if (signal != GDB_SIGNAL_0 && !record_full_list.empty ()) - record_full_list[record_full_next_insn - 1].sigval = signal; + if (signal != GDB_SIGNAL_0 && !record_full_log.empty ()) + record_full_log[record_full_next_insn - 1].sigval = signal; if (signal == GDB_SIGNAL_0 || !gdbarch_process_record_signal_p (gdbarch)) @@ -847,8 +847,8 @@ record_full_message (struct regcache *regcache, enum gdb_signal signal) record_full_save_instruction (); - if (record_full_list.size () == record_full_insn_max_num) - record_full_list_release_first (); + if (record_full_log.size () == record_full_insn_max_num) + record_full_log_release_first (); } static bool @@ -1325,7 +1325,7 @@ record_full_wait_1 (struct target_ops *ops, if (execution_direction == EXEC_REVERSE) record_full_next_insn--; - /* Loop over the record_full_list, looking for the next place to + /* Loop over the record_full_log, looking for the next place to stop. */ do { @@ -1339,14 +1339,14 @@ record_full_wait_1 (struct target_ops *ops, break; } if (execution_direction != EXEC_REVERSE - && record_full_next_insn == record_full_list.size ()) + && record_full_next_insn == record_full_log.size ()) { /* Hit end of record log going forward. */ status->set_no_history (); break; } - record_full_list[record_full_next_insn].exec_insn (regcache); + record_full_log[record_full_next_insn].exec_insn (regcache); /* step */ if (record_full_resume_step) @@ -1380,7 +1380,7 @@ record_full_wait_1 (struct target_ops *ops, "watchpoint.\n"); continue_flag = 0; } - if (record_full_list[record_full_next_insn].sigval.has_value ()) + if (record_full_log[record_full_next_insn].sigval.has_value ()) continue_flag = 0; if (execution_direction == EXEC_REVERSE) @@ -1395,10 +1395,10 @@ record_full_wait_1 (struct target_ops *ops, gdb_assert (execution_direction == EXEC_REVERSE); record_full_next_insn = 0; } - else if (record_full_next_insn > record_full_list.size ()) + else if (record_full_next_insn > record_full_log.size ()) { gdb_assert (execution_direction == EXEC_FORWARD); - record_full_next_insn = record_full_list.size (); + record_full_next_insn = record_full_log.size (); } /* Reset the current instruction to point to the one to be replayed moving forward. */ @@ -1412,9 +1412,9 @@ record_full_wait_1 (struct target_ops *ops, ? record_full_next_insn - 1 : record_full_next_insn; if (record_full_get_sig) status->set_stopped (GDB_SIGNAL_INT); - else if (record_full_list[insn].sigval.has_value ()) + else if (record_full_log[insn].sigval.has_value ()) status->set_stopped - (record_full_list[insn].sigval.value ()); + (record_full_log[insn].sigval.value ()); else status->set_stopped (GDB_SIGNAL_TRAP); } @@ -1537,8 +1537,8 @@ record_full_registers_change (struct regcache *regcache, int regnum) } record_full_save_instruction (); - if (record_full_list.size () == record_full_insn_max_num) - record_full_list_release_first (); + if (record_full_log.size () == record_full_insn_max_num) + record_full_log_release_first (); } /* "store_registers" method for process record target. */ @@ -1587,7 +1587,7 @@ record_full_target::store_registers (struct regcache *regcache, int regno) } /* Destroy the record from here forward. */ - record_full_list_release_following (record_full_next_insn); + record_full_log_release_following (record_full_next_insn); } record_full_registers_change (regcache, regno); @@ -1620,7 +1620,7 @@ record_full_target::xfer_partial (enum target_object object, error (_("Process record canceled the operation.")); /* Destroy the record from here forward. */ - record_full_list_release_following (record_full_next_insn); + record_full_log_release_following (record_full_next_insn); } /* Check record_full_insn_num */ @@ -1639,8 +1639,8 @@ record_full_target::xfer_partial (enum target_object object, } record_full_save_instruction (); - if (record_full_list.size () == record_full_insn_max_num) - record_full_list_release_first (); + if (record_full_log.size () == record_full_insn_max_num) + record_full_log_release_first (); } return this->beneath ()->xfer_partial (object, annex, readbuf, writebuf, @@ -1796,11 +1796,11 @@ record_full_base_target::get_bookmark (const char *args, int from_tty) { char *ret = NULL; - if (record_full_list.empty ()) + if (record_full_log.empty ()) return (gdb_byte *) ret; /* Return stringified form of instruction count. */ - ret = xstrdup (pulongest (record_full_list[record_full_next_insn].insn_num)); + ret = xstrdup (pulongest (record_full_log[record_full_next_insn].insn_num)); if (record_debug) { @@ -1862,16 +1862,16 @@ record_full_base_target::info_record () gdb_printf (_("Record mode:\n")); /* Do we have a log at all? */ - if (!record_full_list.empty ()) + if (!record_full_log.empty ()) { /* Display instruction number for first instruction in the log. */ gdb_printf (_("Lowest recorded instruction number is %u.\n"), - record_full_list[0].insn_num); + record_full_log[0].insn_num); /* If in replay mode, display where we are in the log. */ if (RECORD_FULL_IS_REPLAY) gdb_printf (_("Current instruction number is %u.\n"), - record_full_list[record_full_next_insn].insn_num); + record_full_log[record_full_next_insn].insn_num); /* Display instruction number for last instruction in the log. */ gdb_printf (_("Highest recorded instruction number is %s.\n"), @@ -1879,7 +1879,7 @@ record_full_base_target::info_record () /* Display log count. */ gdb_printf (_("Log contains %lu instructions.\n"), - (unsigned long int) record_full_list.size ()); + (unsigned long int) record_full_log.size ()); } else gdb_printf (_("No instructions have been logged.\n")); @@ -1928,14 +1928,14 @@ record_full_base_target::record_will_replay (ptid_t ptid, int dir) static void record_full_goto_entry (size_t target_insn) { - if (target_insn >= record_full_list.size ()) + if (target_insn >= record_full_log.size ()) error (_("Target insn not found.")); else if (target_insn == record_full_next_insn) error (_("Already at target insn.")); else if (target_insn > record_full_next_insn) { gdb_printf (_("Go forward to insn number %s\n"), - pulongest (record_full_list[target_insn].insn_num)); + pulongest (record_full_log[target_insn].insn_num)); record_full_goto_insn (target_insn, EXEC_FORWARD); } else @@ -1966,7 +1966,7 @@ record_full_base_target::goto_record_begin () void record_full_base_target::goto_record_end () { - record_full_goto_entry (record_full_list.size () - 1); + record_full_goto_entry (record_full_log.size () - 1); } /* The "goto_record" target method. */ @@ -2403,7 +2403,7 @@ record_full_restore (struct bfd &cbfd) int bfd_offset = 0; /* "record_full_restore" can only be called when record list is empty. */ - gdb_assert (record_full_list.empty ()); + gdb_assert (record_full_log.empty ()); if (record_debug) gdb_printf (gdb_stdlog, "Restoring recording from core file.\n"); @@ -2454,9 +2454,9 @@ record_full_restore (struct bfd &cbfd) } /* Update record_full_insn_max_num. */ - if (record_full_list.size () > record_full_insn_max_num) + if (record_full_log.size () > record_full_insn_max_num) { - record_full_insn_max_num = record_full_list.size (); + record_full_insn_max_num = record_full_log.size (); warning (_("Auto increase record/replay buffer limit to %u."), record_full_insn_max_num); } @@ -2634,16 +2634,16 @@ record_full_base_target::save_record (const char *recfilename) /* Reverse execute to the begin of record list. */ for (int i = record_full_next_insn - 1; i >= 0; i--) - record_full_list[i].exec_insn (regcache); + record_full_log[i].exec_insn (regcache); /* Compute the size needed for the extra bfd section. */ save_size = 4; /* magic cookie */ - for (int i = record_full_list.size () - 1; i >= 0; i--) + for (int i = record_full_log.size () - 1; i >= 0; i--) { /* Number of effects of an instruction. */ save_size += sizeof (uint32_t) + sizeof (uint8_t) + sizeof (uint32_t); - save_size += 4 + record_full_list[i].pc.len; - for (auto &entry : record_full_list[i].effects) + save_size += 4 + record_full_log[i].pc.len; + for (auto &entry : record_full_log[i].effects) switch (entry.type ()) { case record_full_reg: @@ -2682,12 +2682,12 @@ record_full_base_target::save_record (const char *recfilename) /* Save the entries to recfd and forward execute to the end of record list. */ - for (int i = 0; i < record_full_list.size (); i++) + for (int i = 0; i < record_full_log.size (); i++) { - record_full_list[i].to_bfd (obfd, osec, &bfd_offset, gdbarch); + record_full_log[i].to_bfd (obfd, osec, &bfd_offset, gdbarch); /* Execute entry. */ if (i < record_full_next_insn) - record_full_list[i].exec_insn (regcache); + record_full_log[i].exec_insn (regcache); } unlink_file.keep (); @@ -2714,10 +2714,10 @@ record_full_goto_insn (size_t target_insn, if (dir == EXEC_REVERSE) for (int i = record_full_next_insn; i > target_insn; i--) - record_full_list[i-1].exec_insn (regcache); + record_full_log[i-1].exec_insn (regcache); else for (int i = record_full_next_insn; i < target_insn; i++) - record_full_list[i].exec_insn (regcache); + record_full_log[i].exec_insn (regcache); } /* Alias for "target record-full". */ @@ -2732,10 +2732,10 @@ static void set_record_full_insn_max_num (const char *args, int from_tty, struct cmd_list_element *c) { - if (record_full_list.size () > record_full_insn_max_num) + if (record_full_log.size () > record_full_insn_max_num) { - while (record_full_list.size () > record_full_insn_max_num) - record_full_list_release_first (); + while (record_full_log.size () > record_full_insn_max_num) + record_full_log_release_first (); } } @@ -2744,21 +2744,21 @@ set_record_full_insn_max_num (const char *args, int from_tty, static void maintenance_print_record_instruction (const char *args, int from_tty) { - if (record_full_list.empty ()) + if (record_full_log.empty ()) error (_("Not enough recorded history")); int offset = record_full_next_insn - 1; /* Reduce the offset by 1 if the record_full_next_insn is after the end so that we show the last recorded instruction instead of crashing. */ - if (offset == record_full_list.size ()) + if (offset == record_full_log.size ()) offset--; if (args != nullptr) { offset += value_as_long (parse_and_eval (args)); - if (offset >= record_full_list.size () || offset < 0) + if (offset >= record_full_log.size () || offset < 0) error (_("Not enough recorded history")); } - auto to_print = record_full_list.begin () + offset; + auto to_print = record_full_log.begin () + offset; gdbarch *arch = current_inferior ()->arch (); struct value_print_options opts; -- 2.54.0