From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4RmmGd0mB2qVQD0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 09:59:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IyN3K7nT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HE+XVWSc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IyN3K7nT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HE+XVWSc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 638F81E0B1; Fri, 15 May 2026 09:59:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ED9651E093 for ; Fri, 15 May 2026 09:59:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20D7B4B0A6D8 for ; Fri, 15 May 2026 13:59:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20D7B4B0A6D8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IyN3K7nT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HE+XVWSc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IyN3K7nT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HE+XVWSc Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 73FA34B0A6D8 for ; Fri, 15 May 2026 13:58:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73FA34B0A6D8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 73FA34B0A6D8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778853516; cv=none; b=RJDC35TUGTnAVPOFdQVzp6MJkrGNCcFE+rY0FOinaAhzaqkBYEJoewe2sBac2SwEyqmfFkbaR5wc6AQ64s5LbVJNa0H1cDqIrScfIn0J3ac2iw4ZwQQPHm3vCqRN2uShXBSYq/g3jZktdPH9xRBwIjsAKNG2q/OgDO2nLdTnmUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778853516; c=relaxed/simple; bh=C9zhUox3g5PotITyzeQgSx+3v36uSGQvfuuSzGV3ZFg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=hUac78vsZT08dUwDP06R8at0gFsXcJCiN0wyj1mo7s/V3zuE8ob4GU0OqVH0YLnQcYo3k0RCRWw8eNsS6BFa+Brytd2mQcBlNoyIZTZ9li/1cELpjn4vfaAFsiZjtLAhQMlajmDFuOH6uuDu4Znm1dijqcO4kGaeoASLZeIPR04= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IyN3K7nT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HE+XVWSc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IyN3K7nT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HE+XVWSc DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73FA34B0A6D8 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7A9FB674FE for ; Fri, 15 May 2026 13:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChlNrhMhf6zl/2txJdISlvEuI2ziPe5ZQsQKjhT4waw=; b=IyN3K7nT3LUSYeUCsUL0Kg1Hg+UEZOMIXleRHC+rncr98W+Fhckc8sA2h/W1KUYIKAnvl7 so9+ZGTMHRV75FZC5yAQqEFEAA6qXct41E1K4NLFm+OKXqPlegsdUHKNGKDtkD4O4CPgn2 /CCvyxQdQxBbHVsUnIlJMJjZyvp5CGE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChlNrhMhf6zl/2txJdISlvEuI2ziPe5ZQsQKjhT4waw=; b=HE+XVWScImnZ96o5/IyPh/1al/jU01IEDiqqSMEWp3BbFJl+ql5fmJhQtmL6VogEpGzGWD yAA3tH5TVCO73GCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChlNrhMhf6zl/2txJdISlvEuI2ziPe5ZQsQKjhT4waw=; b=IyN3K7nT3LUSYeUCsUL0Kg1Hg+UEZOMIXleRHC+rncr98W+Fhckc8sA2h/W1KUYIKAnvl7 so9+ZGTMHRV75FZC5yAQqEFEAA6qXct41E1K4NLFm+OKXqPlegsdUHKNGKDtkD4O4CPgn2 /CCvyxQdQxBbHVsUnIlJMJjZyvp5CGE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChlNrhMhf6zl/2txJdISlvEuI2ziPe5ZQsQKjhT4waw=; b=HE+XVWScImnZ96o5/IyPh/1al/jU01IEDiqqSMEWp3BbFJl+ql5fmJhQtmL6VogEpGzGWD yAA3tH5TVCO73GCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 65F79593A9 for ; Fri, 15 May 2026 13:58:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2ASTF4smB2q9CAAAD6G6ig (envelope-from ) for ; Fri, 15 May 2026 13:58:35 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v3 5/5] [gdb/python] Use py_{none,notimplemented} more often Date: Fri, 15 May 2026 15:58:34 +0200 Message-ID: <20260515135834.2502165-5-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260515135834.2502165-1-tdevries@suse.de> References: <20260515135834.2502165-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Replace: ... { Py_INCREF (Py_NotImplemented); return Py_NotImplemented; } ... with: ... return py_notimplemented ().release (); ... Likewise for py_none. --- gdb/python/py-block.c | 5 +---- gdb/python/py-connection.c | 3 +-- gdb/python/py-finishbreakpoint.c | 5 +---- gdb/python/py-frame.c | 8 ++------ gdb/python/py-lazy-string.c | 5 +---- gdb/python/py-record-btrace.c | 8 ++------ gdb/python/py-record.c | 8 ++------ gdb/python/py-symbol.c | 5 +---- gdb/python/py-type.c | 5 +---- gdb/python/py-value.c | 3 +-- 10 files changed, 13 insertions(+), 42 deletions(-) diff --git a/gdb/python/py-block.c b/gdb/python/py-block.c index 17c9cbdaff0..6fe18e45564 100644 --- a/gdb/python/py-block.c +++ b/gdb/python/py-block.c @@ -550,10 +550,7 @@ blpy_richcompare (PyObject *self, PyObject *other, int op) { if (!PyObject_TypeCheck (other, &block_object_type) || (op != Py_EQ && op != Py_NE)) - { - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; - } + return py_notimplemented ().release (); bool expected = self == other; bool equal = op == Py_EQ; diff --git a/gdb/python/py-connection.c b/gdb/python/py-connection.c index 3f20e8876f9..43e03ad81f7 100644 --- a/gdb/python/py-connection.c +++ b/gdb/python/py-connection.c @@ -321,8 +321,7 @@ struct py_send_packet_callbacks : public send_remote_packet_callbacks else { /* We didn't get back any result data; set the result to None. */ - Py_INCREF (Py_None); - m_result.reset (Py_None); + m_result = py_none (); } } diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c index f85f4fff766..49e12c00054 100644 --- a/gdb/python/py-finishbreakpoint.c +++ b/gdb/python/py-finishbreakpoint.c @@ -127,10 +127,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj) gdbpy_print_stack (); } else - { - Py_INCREF (Py_None); - self_finishbp->return_value = Py_None; - } + self_finishbp->return_value = py_none ().release (); } catch (const gdb_exception &except) { diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c index 068b6260af5..374b934a0d9 100644 --- a/gdb/python/py-frame.c +++ b/gdb/python/py-frame.c @@ -153,8 +153,7 @@ frapy_name (PyObject *self, PyObject *args) } else { - result = Py_None; - Py_INCREF (Py_None); + result = py_none ().release (); } return result; @@ -724,10 +723,7 @@ frapy_richcompare (PyObject *self, PyObject *other, int op) if (!PyObject_TypeCheck (other, &frame_object_type) || (op != Py_EQ && op != Py_NE)) - { - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; - } + return py_notimplemented ().release (); frame_object *self_frame = (frame_object *) self; frame_object *other_frame = (frame_object *) other; diff --git a/gdb/python/py-lazy-string.c b/gdb/python/py-lazy-string.c index fe191451e54..ba3920e07c3 100644 --- a/gdb/python/py-lazy-string.c +++ b/gdb/python/py-lazy-string.c @@ -72,10 +72,7 @@ stpy_get_encoding (PyObject *self, void *closure) if (self_string->encoding) result = PyUnicode_FromString (self_string->encoding); else - { - result = Py_None; - Py_INCREF (result); - } + result = py_none ().release (); return result; } diff --git a/gdb/python/py-record-btrace.c b/gdb/python/py-record-btrace.c index bacb172fec4..f46b434313e 100644 --- a/gdb/python/py-record-btrace.c +++ b/gdb/python/py-record-btrace.c @@ -621,10 +621,7 @@ btpy_list_richcompare (PyObject *self, PyObject *other, int op) const btpy_list_object * const obj2 = (btpy_list_object *) other; if (Py_TYPE (self) != Py_TYPE (other)) - { - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; - } + return py_notimplemented ().release (); switch (op) { @@ -652,8 +649,7 @@ btpy_list_richcompare (PyObject *self, PyObject *other, int op) break; } - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; + return py_notimplemented ().release (); } /* Implementation of diff --git a/gdb/python/py-record.c b/gdb/python/py-record.c index 753826f88c4..3ceedecc165 100644 --- a/gdb/python/py-record.c +++ b/gdb/python/py-record.c @@ -416,10 +416,7 @@ recpy_element_richcompare (PyObject *self, PyObject *other, int op) const recpy_element_object * const obj2 = (recpy_element_object *) other; if (Py_TYPE (self) != Py_TYPE (other)) - { - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; - } + return py_notimplemented ().release (); switch (op) { @@ -443,8 +440,7 @@ recpy_element_richcompare (PyObject *self, PyObject *other, int op) break; } - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; + return py_notimplemented ().release (); } /* Create a new gdb.RecordGap object. */ diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c index 224e5d90f26..76255f53f85 100644 --- a/gdb/python/py-symbol.c +++ b/gdb/python/py-symbol.c @@ -68,10 +68,7 @@ sympy_get_type (PyObject *self, void *closure) SYMPY_REQUIRE_VALID (self, symbol); if (symbol->type () == NULL) - { - Py_INCREF (Py_None); - return Py_None; - } + return py_none ().release (); return type_to_type_object (symbol->type ()).release (); } diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c index 775145a8135..cbb984309eb 100644 --- a/gdb/python/py-type.c +++ b/gdb/python/py-type.c @@ -1118,10 +1118,7 @@ typy_richcompare (PyObject *self, PyObject *other, int op) /* We can only compare ourselves to another Type object, and only for equality or inequality. */ if (type2 == NULL || (op != Py_EQ && op != Py_NE)) - { - Py_INCREF (Py_NotImplemented); - return Py_NotImplemented; - } + return py_notimplemented ().release (); if (type1 == type2) result = true; diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c index 9443d0ed8c9..04b34758b90 100644 --- a/gdb/python/py-value.c +++ b/gdb/python/py-value.c @@ -416,8 +416,7 @@ valpy_get_address (PyObject *self, void *closure) } catch (const gdb_exception &except) { - val_obj->address = Py_None; - Py_INCREF (Py_None); + val_obj->address = py_none ().release (); } } -- 2.51.0